Page MenuHomePhabricator

sbarzowski (Stanisław Barzowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2016, 12:32 PM (182 w, 4 d)

Recent Activity

May 31 2017

sbarzowski added a comment to D19201: [clang-tidy] misc-throw-with-noexcept.

There is a patch (D33537) for a check which is a superset of this: [...] A more important difference is that we traverse the whole call-chain and check all the throw statements and try-catch blocks so indirectly throwing functions are also reported and no flase positives are caused by throw and catch in the same try block.

May 31 2017, 9:41 AM

May 21 2017

sbarzowski retitled D33379: New misc-bad-exception-type check. from New misc-bad-exception-type check. It warns about using non-class (or struct) types as an exception. It also blacklists STL smart pointers and std::string. I'm not sure if it's appropriate for mainline as it has very low chance of finding... to New misc-bad-exception-type check..
May 21 2017, 3:00 AM

May 20 2017

sbarzowski created D33379: New misc-bad-exception-type check..
May 20 2017, 12:10 PM
sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
May 20 2017, 6:37 AM
sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Cosmetic

May 20 2017, 6:35 AM

May 18 2017

sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Removed unnecessary colon from message

May 18 2017, 3:11 PM
sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Docs and cosmetic issues

May 18 2017, 2:55 PM

May 4 2017

sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Fixed false positive issues

May 4 2017, 11:49 AM

Mar 13 2017

sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
Mar 13 2017, 6:43 AM

Mar 6 2017

sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
Mar 6 2017, 12:49 PM

Feb 7 2017

sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
Feb 7 2017, 1:22 PM
sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
Feb 7 2017, 11:17 AM

Jan 26 2017

sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Improved messages, added tests with templates, fixed some typos.

Jan 26 2017, 3:27 AM

Jan 16 2017

sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

I took advantage of new getExceptionSpecSourceRange (it wasn't available before) instead of getting exception specification manually with the lexer.

Jan 16 2017, 10:49 AM

Dec 16 2016

sbarzowski added inline comments to D27806: [clang-tidy] Add obvious-invalid-range.
Dec 16 2016, 8:02 AM
sbarzowski requested changes to D27806: [clang-tidy] Add obvious-invalid-range.
Dec 16 2016, 3:29 AM

Dec 15 2016

sbarzowski accepted D27752: [clang] Use after move bug fixes.

LGTM

Dec 15 2016, 4:41 AM

Oct 7 2016

sbarzowski added a comment to D20428: Tracking exception specification source locations.

What's happening here? It's accepted, but not merged and the last activity is 3 months old while my change is waiting for it. Can I help somehow?

Oct 7 2016, 8:11 AM

Jun 10 2016

sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 10 2016, 6:08 AM

Jun 3 2016

sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 3 2016, 10:00 AM
sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 3 2016, 9:25 AM
sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 3 2016, 8:39 AM
sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 3 2016, 8:13 AM
sbarzowski added inline comments to D20964: [clang-tidy] Add modernize-use-emplace.
Jun 3 2016, 8:02 AM

Jun 1 2016

sbarzowski added inline comments to D19201: [clang-tidy] misc-throw-with-noexcept.
Jun 1 2016, 2:26 PM
sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.

Thanks for review, guys. I fixed as many easy problems as I had time for today, will continue later.

Jun 1 2016, 2:20 PM
sbarzowski added a comment to D19201: [clang-tidy] misc-throw-with-noexcept.

Note `FunctionProtoType::getNoExceptExpr` is weird. If you have the same expr in multiple noexcepts, then it returns the same object for all of them, so it is useless for determining the location in code.

Jun 1 2016, 1:16 AM
sbarzowski set the repository for D19201: [clang-tidy] misc-throw-with-noexcept to rL LLVM.
Jun 1 2016, 1:11 AM
sbarzowski updated the diff for D19201: [clang-tidy] misc-throw-with-noexcept.
Jun 1 2016, 1:10 AM

Apr 17 2016

sbarzowski added reviewers for D19201: [clang-tidy] misc-throw-with-noexcept: krystyna, mnbvmar, staronj.
Apr 17 2016, 1:28 PM
sbarzowski retitled D19201: [clang-tidy] misc-throw-with-noexcept from to [clang-tidy] misc-throw-with-noexcept.
Apr 17 2016, 1:25 PM