Page MenuHomePhabricator

sarveshtamba (Sarvesh Tamba)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2018, 10:03 PM (6 w, 4 h)

Recent Activity

Thu, Jan 17

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Any updates on this?

Thu, Jan 17, 10:15 PM

Wed, Jan 16

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

In https://reviews.llvm.org/D55503, we had extended the condition to include PPC.
However, the check required to build LLVM on PPC64LE was missed in SVN r348970.

Wed, Jan 16, 1:23 AM
sarveshtamba updated the diff for D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Extending the condition to include PPC

Wed, Jan 16, 1:15 AM

Fri, Jan 11

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, any updates on this one?

Fri, Jan 11, 5:13 AM

Tue, Jan 8

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, please review and let me know if this looks good.

Tue, Jan 8, 9:14 AM

Mon, Jan 7

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai Created a new diff - https://reviews.llvm.org/D56382
Please review.

Mon, Jan 7, 3:23 AM
sarveshtamba created D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).
Mon, Jan 7, 3:22 AM

Thu, Jan 3

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hello @nemanjai Any updates on verification of sanitizers on PPC64LE with this PR?

Thu, Jan 3, 9:56 PM

Dec 19 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai Thanks, please do let me know in case you need anything from my side.

Dec 19 2018, 10:45 PM

Dec 17 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hello @nemanjai @compnerd, please let me know how to proceed on this further.

Dec 17 2018, 4:10 AM

Dec 13 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, thanks for clarifying! Yes, and separating out PPC64LE from the platform check helps build and execute Swift on PPC64LE. Please suggest.

Dec 13 2018, 8:45 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

The Swift 5.0 toolchain on PowerPC64LE also works fine if we remove the "defined(ppc)" check altogether in the original code i.e keep only "!(defined(NetBSD) || defined(OpenBSD)))".
Would that affect other PPC platforms (32/64 and BE/LE PPC other than PowerPC64LE)?

Dec 13 2018, 5:22 AM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hi, The changes committed as a part of commit r348970 are different from the original patch which I submitted and which also fixed build issues while building Swift 5.0 toolchain (lldb component). The new patch committed still breaks the swift toolchain build as before:-

Dec 13 2018, 2:40 AM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Update for PowerPC64LE

Dec 13 2018, 2:40 AM

Dec 12 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@compnerd, thanks for the explanation and accepting this change revision. Yes, I would need someone to commit this on my behalf, as I might not have the rights to do a commit. Please go ahead and do it for me if you can. Thanks in advance!

Dec 12 2018, 10:20 AM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

As per the comments in the code:-

Dec 12 2018, 1:46 AM

Dec 11 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hi Reviewers,
Can you please review this? This change is resolving a blocker while building swift toolchain on PowerPC64LE and is a bit urgent. Since this is a small change, can you please take this up? Thanks!

Dec 11 2018, 10:00 PM

Dec 10 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Please review the suggested changes and approve/merge if this looks good. Thanks!

Dec 10 2018, 1:03 AM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Incorporating review comments.

Dec 10 2018, 12:01 AM

Dec 9 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Yes, the swift toolchain successfully gets built with this change.

Dec 9 2018, 10:55 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Previous review (for the swift-llvm GitHub repo): https://github.com/apple/swift-llvm/pull/129

Dec 9 2018, 10:47 PM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Earlier diff created was using the command "git show HEAD -U999999 > mypatch.patch" as mentioned in "https://llvm.org/docs/Phabricator.html#phabricator-request-review-web".
The updated patch is created using git diff and reflects the correct diff of the changes.

Dec 9 2018, 10:32 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Please review the attached change as this is a blocker for our development tasks.

Dec 9 2018, 10:26 PM
sarveshtamba created D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).
Dec 9 2018, 10:25 PM