- User Since
- Dec 9 2018, 10:03 PM (6 w, 4 h)
Thu, Jan 17
Any updates on this?
Wed, Jan 16
In https://reviews.llvm.org/D55503, we had extended the condition to include PPC.
However, the check required to build LLVM on PPC64LE was missed in SVN r348970.
Extending the condition to include PPC
Fri, Jan 11
@nemanjai, any updates on this one?
Tue, Jan 8
@nemanjai, please review and let me know if this looks good.
Mon, Jan 7
Thu, Jan 3
Hello @nemanjai Any updates on verification of sanitizers on PPC64LE with this PR?
Dec 19 2018
@nemanjai Thanks, please do let me know in case you need anything from my side.
Dec 17 2018
Dec 13 2018
@nemanjai, thanks for clarifying! Yes, and separating out PPC64LE from the platform check helps build and execute Swift on PPC64LE. Please suggest.
The Swift 5.0 toolchain on PowerPC64LE also works fine if we remove the "defined(ppc)" check altogether in the original code i.e keep only "!(defined(NetBSD) || defined(OpenBSD)))".
Would that affect other PPC platforms (32/64 and BE/LE PPC other than PowerPC64LE)?
Hi, The changes committed as a part of commit r348970 are different from the original patch which I submitted and which also fixed build issues while building Swift 5.0 toolchain (lldb component). The new patch committed still breaks the swift toolchain build as before:-
Update for PowerPC64LE
Dec 12 2018
@compnerd, thanks for the explanation and accepting this change revision. Yes, I would need someone to commit this on my behalf, as I might not have the rights to do a commit. Please go ahead and do it for me if you can. Thanks in advance!
As per the comments in the code:-
Dec 11 2018
Can you please review this? This change is resolving a blocker while building swift toolchain on PowerPC64LE and is a bit urgent. Since this is a small change, can you please take this up? Thanks!
Dec 10 2018
Please review the suggested changes and approve/merge if this looks good. Thanks!
Incorporating review comments.
Dec 9 2018
Yes, the swift toolchain successfully gets built with this change.
Previous review (for the swift-llvm GitHub repo): https://github.com/apple/swift-llvm/pull/129
Earlier diff created was using the command "git show HEAD -U999999 > mypatch.patch" as mentioned in "https://llvm.org/docs/Phabricator.html#phabricator-request-review-web".
The updated patch is created using git diff and reflects the correct diff of the changes.
Please review the attached change as this is a blocker for our development tasks.