- User Since
- Dec 9 2018, 10:03 PM (149 w, 18 h)
Apr 16 2019
The new patch for this bug is in https://reviews.llvm.org/D60811.
Apr 15 2019
I saw that this part of the code was introduced by you in commit - https://reviews.llvm.org/D26023
Can you please tell what this piece of code is doing and if at all the assert statement needs to be revisited?
Apr 11 2019
Mar 26 2019
Mar 21 2019
Filed bug at :- https://bugs.llvm.org/show_bug.cgi?id=41177
Can anyone confirm if this has been pushed upstream in the master branch? I pulled latest code for Apple Swift master, and did not see this change in swift-llvm repository.
Mar 20 2019
@jsji any inputs on how to produce a reduced testcase that can show the problem.
Mar 19 2019
@lebedev.ri, no, as explained in above comments. Need some help in resolving this issue.
@jsji can you please let me know how to produce a reduced testcase that can show the problem? Sorry, but I am quite new to this, any help would be greatly helpful.
Mar 13 2019
@dblaikie, anyone you know who can help here?
Sorry for the delayed response.
Yes you are right, the submitted change would not effect the behavior of the program. I think I misread / misinterpreted the condition earlier, took it to be e = ++i, not realising its a simple for loop increment.
Also the error that's being thrown up might be intermittent, since when I made this change from ++i to i++, the build seemed to have passed, though now it fails again.
Mar 4 2019
@compnerd Has this been pushed upstream? I pulled latest code for Apple Swift master, and did not see this change in swift-llvm repository. Please confirm.
Feb 28 2019
Hi, Can someone please review this? Thanks!
Feb 27 2019
Feb 25 2019
Hi, can someone point me the right repo to submit these changes?
Feb 19 2019
Any updates on this one?
Feb 18 2019
Feb 17 2019
Feb 13 2019
@compnerd - Please let me know once this is committed. Thanks.
Feb 11 2019
@compnerd - I got a confirmation that we can go ahead and merge this. Please go ahead and commit this on my behalf.
Jan 24 2019
@compnerd - I will check this and let you know. In the meanwhile can you please point towards the new license documentation/details?
Sure @compnerd, please go ahead and commit this on my behalf like last time. Thanks in advance!
Jan 17 2019
Any updates on this?
Jan 16 2019
In https://reviews.llvm.org/D55503, we had extended the condition to include PPC.
However, the check required to build LLVM on PPC64LE was missed in SVN r348970.
Extending the condition to include PPC
Jan 11 2019
@nemanjai, any updates on this one?
Jan 8 2019
@nemanjai, please review and let me know if this looks good.
Jan 7 2019
Jan 3 2019
Hello @nemanjai Any updates on verification of sanitizers on PPC64LE with this PR?
Dec 19 2018
@nemanjai Thanks, please do let me know in case you need anything from my side.
Dec 17 2018
Dec 13 2018
@nemanjai, thanks for clarifying! Yes, and separating out PPC64LE from the platform check helps build and execute Swift on PPC64LE. Please suggest.
The Swift 5.0 toolchain on PowerPC64LE also works fine if we remove the "defined(ppc)" check altogether in the original code i.e keep only "!(defined(NetBSD) || defined(OpenBSD)))".
Would that affect other PPC platforms (32/64 and BE/LE PPC other than PowerPC64LE)?
Hi, The changes committed as a part of commit r348970 are different from the original patch which I submitted and which also fixed build issues while building Swift 5.0 toolchain (lldb component). The new patch committed still breaks the swift toolchain build as before:-
Update for PowerPC64LE
Dec 12 2018
@compnerd, thanks for the explanation and accepting this change revision. Yes, I would need someone to commit this on my behalf, as I might not have the rights to do a commit. Please go ahead and do it for me if you can. Thanks in advance!
As per the comments in the code:-
Dec 11 2018
Can you please review this? This change is resolving a blocker while building swift toolchain on PowerPC64LE and is a bit urgent. Since this is a small change, can you please take this up? Thanks!
Dec 10 2018
Please review the suggested changes and approve/merge if this looks good. Thanks!
Incorporating review comments.
Dec 9 2018
Yes, the swift toolchain successfully gets built with this change.
Previous review (for the swift-llvm GitHub repo): https://github.com/apple/swift-llvm/pull/129
Earlier diff created was using the command "git show HEAD -U999999 > mypatch.patch" as mentioned in "https://llvm.org/docs/Phabricator.html#phabricator-request-review-web".
The updated patch is created using git diff and reflects the correct diff of the changes.
Please review the attached change as this is a blocker for our development tasks.