Page MenuHomePhabricator

sarveshtamba (Sarvesh Tamba)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2018, 10:03 PM (40 w, 3 d)

Recent Activity

Apr 16 2019

sarveshtamba abandoned D60564: Changes for LLVM PPCISelLowering function combineBVOfConsecutiveLoads.

The new patch for this bug is in https://reviews.llvm.org/D60811.

Apr 16 2019, 9:56 PM · Restricted Project

Apr 15 2019

sarveshtamba added a comment to D60564: Changes for LLVM PPCISelLowering function combineBVOfConsecutiveLoads.

Hi @nemanjai,
I saw that this part of the code was introduced by you in commit - https://reviews.llvm.org/D26023
Can you please tell what this piece of code is doing and if at all the assert statement needs to be revisited?

Apr 15 2019, 5:19 AM · Restricted Project

Apr 11 2019

sarveshtamba created D60564: Changes for LLVM PPCISelLowering function combineBVOfConsecutiveLoads.
Apr 11 2019, 4:45 AM · Restricted Project

Mar 26 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.
Mar 26 2019, 3:18 AM · Restricted Project
sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.
Mar 26 2019, 1:16 AM · Restricted Project

Mar 21 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

Filed bug at :- https://bugs.llvm.org/show_bug.cgi?id=41177

Mar 21 2019, 4:34 AM · Restricted Project
sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Can anyone confirm if this has been pushed upstream in the master branch? I pulled latest code for Apple Swift master, and did not see this change in swift-llvm repository.

Mar 21 2019, 4:17 AM · Restricted Project

Mar 20 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

@jsji any inputs on how to produce a reduced testcase that can show the problem.

Mar 20 2019, 5:44 AM · Restricted Project

Mar 19 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

@lebedev.ri, no, as explained in above comments. Need some help in resolving this issue.

Mar 19 2019, 6:09 AM · Restricted Project
sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

@jsji can you please let me know how to produce a reduced testcase that can show the problem? Sorry, but I am quite new to this, any help would be greatly helpful.

Mar 19 2019, 5:51 AM · Restricted Project

Mar 13 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

@dblaikie, anyone you know who can help here?

Mar 13 2019, 10:08 PM · Restricted Project
sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

Sorry for the delayed response.
Yes you are right, the submitted change would not effect the behavior of the program. I think I misread / misinterpreted the condition earlier, took it to be e = ++i, not realising its a simple for loop increment.
Also the error that's being thrown up might be intermittent, since when I made this change from ++i to i++, the build seemed to have passed, though now it fails again.

Mar 13 2019, 4:43 AM · Restricted Project

Mar 4 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.
Mar 4 2019, 10:36 PM · Restricted Project
sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@compnerd Has this been pushed upstream? I pulled latest code for Apple Swift master, and did not see this change in swift-llvm repository. Please confirm.

Mar 4 2019, 1:49 AM · Restricted Project

Feb 28 2019

sarveshtamba added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

Hi, Can someone please review this? Thanks!

Feb 28 2019, 8:30 PM · Restricted Project

Feb 27 2019

sarveshtamba created D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.
Feb 27 2019, 4:09 AM · Restricted Project

Feb 25 2019

sarveshtamba added a comment to D58339: Changes for running LLDB test suite for Swift on PowerPC64LE.

Hi, can someone point me the right repo to submit these changes?

Feb 25 2019, 7:00 AM · Restricted Project

Feb 19 2019

sarveshtamba added a comment to D58339: Changes for running LLDB test suite for Swift on PowerPC64LE.

Any updates on this one?

Feb 19 2019, 10:57 PM · Restricted Project

Feb 18 2019

sarveshtamba added a comment to D58339: Changes for running LLDB test suite for Swift on PowerPC64LE.

Hi @labath , Should I be submitting this patch request directly to "https://github.com/apple/swift-lldb"?

Feb 18 2019, 2:32 AM · Restricted Project

Feb 17 2019

sarveshtamba created D58339: Changes for running LLDB test suite for Swift on PowerPC64LE.
Feb 17 2019, 11:10 PM · Restricted Project

Feb 13 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@compnerd - Please let me know once this is committed. Thanks.

Feb 13 2019, 1:49 AM · Restricted Project

Feb 11 2019

Herald added a project to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le): Restricted Project.

@compnerd - I got a confirmation that we can go ahead and merge this. Please go ahead and commit this on my behalf.

Feb 11 2019, 9:03 PM · Restricted Project

Jan 24 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@compnerd - I will check this and let you know. In the meanwhile can you please point towards the new license documentation/details?

Jan 24 2019, 11:50 PM · Restricted Project
sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Sure @compnerd, please go ahead and commit this on my behalf like last time. Thanks in advance!

Jan 24 2019, 9:42 AM · Restricted Project

Jan 17 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Any updates on this?

Jan 17 2019, 10:15 PM · Restricted Project

Jan 16 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

In https://reviews.llvm.org/D55503, we had extended the condition to include PPC.
However, the check required to build LLVM on PPC64LE was missed in SVN r348970.

Jan 16 2019, 1:23 AM · Restricted Project
sarveshtamba updated the diff for D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

Extending the condition to include PPC

Jan 16 2019, 1:15 AM · Restricted Project

Jan 11 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, any updates on this one?

Jan 11 2019, 5:13 AM · Restricted Project

Jan 8 2019

sarveshtamba added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, please review and let me know if this looks good.

Jan 8 2019, 9:14 AM · Restricted Project

Jan 7 2019

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai Created a new diff - https://reviews.llvm.org/D56382
Please review.

Jan 7 2019, 3:23 AM
sarveshtamba created D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).
Jan 7 2019, 3:22 AM · Restricted Project

Jan 3 2019

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hello @nemanjai Any updates on verification of sanitizers on PPC64LE with this PR?

Jan 3 2019, 9:56 PM

Dec 19 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai Thanks, please do let me know in case you need anything from my side.

Dec 19 2018, 10:45 PM

Dec 17 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hello @nemanjai @compnerd, please let me know how to proceed on this further.

Dec 17 2018, 4:10 AM

Dec 13 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@nemanjai, thanks for clarifying! Yes, and separating out PPC64LE from the platform check helps build and execute Swift on PPC64LE. Please suggest.

Dec 13 2018, 8:45 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

The Swift 5.0 toolchain on PowerPC64LE also works fine if we remove the "defined(ppc)" check altogether in the original code i.e keep only "!(defined(NetBSD) || defined(OpenBSD)))".
Would that affect other PPC platforms (32/64 and BE/LE PPC other than PowerPC64LE)?

Dec 13 2018, 5:22 AM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hi, The changes committed as a part of commit r348970 are different from the original patch which I submitted and which also fixed build issues while building Swift 5.0 toolchain (lldb component). The new patch committed still breaks the swift toolchain build as before:-

Dec 13 2018, 2:40 AM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Update for PowerPC64LE

Dec 13 2018, 2:40 AM

Dec 12 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

@compnerd, thanks for the explanation and accepting this change revision. Yes, I would need someone to commit this on my behalf, as I might not have the rights to do a commit. Please go ahead and do it for me if you can. Thanks in advance!

Dec 12 2018, 10:20 AM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

As per the comments in the code:-

Dec 12 2018, 1:46 AM

Dec 11 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Hi Reviewers,
Can you please review this? This change is resolving a blocker while building swift toolchain on PowerPC64LE and is a bit urgent. Since this is a small change, can you please take this up? Thanks!

Dec 11 2018, 10:00 PM

Dec 10 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Please review the suggested changes and approve/merge if this looks good. Thanks!

Dec 10 2018, 1:03 AM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Incorporating review comments.

Dec 10 2018, 12:01 AM

Dec 9 2018

sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Yes, the swift toolchain successfully gets built with this change.

Dec 9 2018, 10:55 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Previous review (for the swift-llvm GitHub repo): https://github.com/apple/swift-llvm/pull/129

Dec 9 2018, 10:47 PM
sarveshtamba updated the diff for D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Earlier diff created was using the command "git show HEAD -U999999 > mypatch.patch" as mentioned in "https://llvm.org/docs/Phabricator.html#phabricator-request-review-web".
The updated patch is created using git diff and reflects the correct diff of the changes.

Dec 9 2018, 10:32 PM
sarveshtamba added a comment to D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).

Please review the attached change as this is a blocker for our development tasks.

Dec 9 2018, 10:26 PM
sarveshtamba created D55503: Change llvm call once check for building Swift for PowerPC(ppc64le).
Dec 9 2018, 10:25 PM