Page MenuHomePhabricator

salman-javed-nz (Salman Javed)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2021, 6:51 AM (74 w, 6 d)

Recent Activity

May 24 2022

salman-javed-nz committed rG9ff4f2dfea63: [clang-tidy] Fix #55134 (regression introduced by 5da7c04) (authored by salman-javed-nz).
[clang-tidy] Fix #55134 (regression introduced by 5da7c04)
May 24 2022, 4:33 PM · Restricted Project, Restricted Project
salman-javed-nz closed D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).
May 24 2022, 4:33 PM · Restricted Project, Restricted Project
salman-javed-nz updated the diff for D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).

Added release note.

May 24 2022, 2:55 PM · Restricted Project, Restricted Project

May 22 2022

salman-javed-nz added a comment to D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).

Thanks for preparing this revision @salman-javed-nz!

Do you think it could be worth adding a few more test cases to cover this? It turned out that this issue wasn't actually specific to multi-line macros (see this comment), so if the test case on line 96 was passing then it must not be fully/correctly testing NOLINT for single-line macros. I guess the only way to do this would be to add more checks to the nolint.cpp file, but I realise that's not a trivial change.

May 22 2022, 3:22 AM · Restricted Project, Restricted Project
salman-javed-nz updated the diff for D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).

Add another test, to test the specific code sample provided in the GitHub issue (check=cppcoreguidelines-pro-type-member-init).

May 22 2022, 3:12 AM · Restricted Project, Restricted Project

May 21 2022

salman-javed-nz updated the summary of D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).
May 21 2022, 10:55 PM · Restricted Project, Restricted Project
salman-javed-nz added a comment to D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).

The pre-merge checks are failing on the clang-format check. Not sure why it's complaining about the formatting of the lit test files - those files have never complied with the project style and have not been checked for style for as long as I remember. Has this policy changed recently?

May 21 2022, 10:35 PM · Restricted Project, Restricted Project
salman-javed-nz updated the diff for D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).

Renamed test case to better explain what it is that it's testing.

May 21 2022, 10:30 PM · Restricted Project, Restricted Project
salman-javed-nz added a comment to D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).


This screenshot shows the code snippet from the GitHub issue, and Clang-Tidy's behaviour before and after this fix.

May 21 2022, 9:21 PM · Restricted Project, Restricted Project
salman-javed-nz requested review of D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04).
May 21 2022, 9:17 PM · Restricted Project, Restricted Project

Feb 28 2022

salman-javed-nz added a comment to D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:)..

Hi @curdeius, have you had the chance to look at this since the last round of comments? The only thing I think this module still needs for now (until a new generic header guard check is developed), is a check that there aren't consecutive underscores in the output.

Feb 28 2022, 12:32 AM · Restricted Project

Feb 21 2022

salman-javed-nz accepted D120196: [clang-tidy][NFC] Remove Tristate from CachedGlobList.

LGTM

Feb 21 2022, 2:41 AM · Restricted Project

Feb 13 2022

salman-javed-nz added a comment to D119481: run-clang-tidy: Fix infinite loop on windows.

Just a drive-by comment to say, thank you for taking the time to make this fix. It's a bug I've triggered many times. Great to see it being resolved.

Feb 13 2022, 2:24 AM · Restricted Project, Restricted Project

Feb 4 2022

salman-javed-nz added a comment to D118104: Make run-clang-tidy.py print the configured checks correctly.

My bad. Test should have called run-clang-tidy with -checks=-some-check in the first test case, and with -config "Checks: -some-check" in the second. In both cases, the disabled check should not appear in the Enabled checks: printout.

Feb 4 2022, 5:17 AM · Restricted Project
salman-javed-nz added a comment to D118104: Make run-clang-tidy.py print the configured checks correctly.

Well, since this was more of source of confusion than actual incorrect behaviour, I don't think there should be a test for it.

In general though, I think the script is complex enough to warrant some testing. That being said: I don't think they should be part of this patch. Also, I'm doing this on company time and I don't think my boss would be to happy if I wrote a testsuite from scratch when I just wanted to fix one bug. :D

Feb 4 2022, 3:48 AM · Restricted Project

Feb 2 2022

salman-javed-nz added a comment to D118104: Make run-clang-tidy.py print the configured checks correctly.

Do you reckon it's worth expanding the test: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/clang-tidy/infrastructure/run-clang-tidy.cpp to look at this issue?
There isn't much testing of the run-clang-tidy.py at the moment, but it doesn't have to always remain that way.

Feb 2 2022, 11:58 AM · Restricted Project

Jan 29 2022

salman-javed-nz added inline comments to D118519: [clang-tidy] Organize the release notes a little better.
Jan 29 2022, 4:21 PM · Restricted Project

Jan 26 2022

salman-javed-nz committed rGc283c8dfb5a9: Rewrite Doxygen comment to resolve -Wdocumentation warning (NFC) (authored by salman-javed-nz).
Rewrite Doxygen comment to resolve -Wdocumentation warning (NFC)
Jan 26 2022, 5:21 AM
salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

This is causing buildbot failures with -Werror (i.e. https://lab.llvm.org/buildbot/#/builders/57/builds/14322/steps/5/logs/stdio). Please fix or revert.

Jan 26 2022, 4:46 AM · Restricted Project
salman-javed-nz committed rG5da7c040030c: Re-land "Cache the locations of NOLINTBEGIN/END blocks" with fix for build bot (authored by salman-javed-nz).
Re-land "Cache the locations of NOLINTBEGIN/END blocks" with fix for build bot
Jan 26 2022, 4:04 AM
salman-javed-nz committed rG8e29d19b8d29: Revert "[clang-tidy] Cache the locations of NOLINTBEGIN/END blocks" (authored by salman-javed-nz).
Revert "[clang-tidy] Cache the locations of NOLINTBEGIN/END blocks"
Jan 26 2022, 3:53 AM
salman-javed-nz committed rG19eaad94c47f: [clang-tidy] Cache the locations of NOLINTBEGIN/END blocks (authored by salman-javed-nz).
[clang-tidy] Cache the locations of NOLINTBEGIN/END blocks
Jan 26 2022, 3:24 AM
salman-javed-nz closed D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 26 2022, 3:24 AM · Restricted Project

Jan 25 2022

salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Review comment:
formNoLintBlocks() - drop the & so the vector must be std::moved in

Jan 25 2022, 3:10 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

ClangTidyContext::shouldSuppressDiagnostic():

  • Hook up AllowIO and EnableNoLintBlocks to NoLintDirectiveHandler::shouldSuppress()
Jan 25 2022, 12:21 AM · Restricted Project

Jan 23 2022

salman-javed-nz added inline comments to D117939: [clang-tidy] Add more documentation about check development.
Jan 23 2022, 5:52 AM · Restricted Project
salman-javed-nz accepted D117857: [clang-tidy] Remove gsl::at suggestion from cppcoreguidelines-pro-bounds-constant-array-index.

LGTM besides a couple of nits. I think the diagnostic message should just say what the problem is, not what the fix is - that's what the FixitHint is for.

Jan 23 2022, 5:30 AM · Restricted Project
salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Every review comment so far should be addressed now, with the exception of the 2 points below.

Jan 23 2022, 4:44 AM · Restricted Project
salman-javed-nz added inline comments to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 23 2022, 2:48 AM · Restricted Project
salman-javed-nz added inline comments to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 23 2022, 2:42 AM · Restricted Project
salman-javed-nz added inline comments to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 23 2022, 2:31 AM · Restricted Project
salman-javed-nz added inline comments to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 23 2022, 2:22 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Pass the NoLintErrors SmallVector all the way through the call stack, instead of storing it in the class

Jan 23 2022, 2:10 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Replace NoLintTokenizer class with a single function, getNoLints()

Jan 23 2022, 2:07 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Instead of defining a new error type for the NoLintDirectiveHandler, use the pre-existing error type clang::tooling::Diagnostic

Jan 23 2022, 2:03 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

NoLintToken:

  • remove public getter methods for Type and Pos - just use the fields directly
  • consolidate the constructors into one constructor
  • add comment about the difference about between Checks = None and Checks = ""
  • add back the comment about why negative globs are ignored
  • don't lazy compute the glob
Jan 23 2022, 2:03 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Fix errors in comments

Jan 23 2022, 2:01 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Put implementation-related classes in an anonymous namespace

Jan 23 2022, 1:59 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Inline short methods into classes

Jan 23 2022, 1:59 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Store the NoLintDirectiveHandler object directly in ClangTidyContext, instead of doing it through a unique_ptr.

Jan 23 2022, 1:57 AM · Restricted Project
salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Move AllowIO and EnableNoLintBlocks from ClangTidyContext() back to shouldSuppressDiagnostic().

Jan 23 2022, 1:55 AM · Restricted Project

Jan 21 2022

salman-javed-nz planned changes to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 21 2022, 6:16 PM · Restricted Project
salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Thank you very much to both of you for having a look at the patch. Yes, I agree it is a large patch, and I could have done a better job splitting it up into more manageable chunks.

Jan 21 2022, 6:06 PM · Restricted Project

Jan 20 2022

salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Update according to review (rename NoLintPragmaHandler class to NoLintDirectiveHandler)

Jan 20 2022, 2:57 AM · Restricted Project
salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Amazing job @salman-javed-nz ! Here's some initial comments. Reviewing the NoLintPragmaHandler.cpp will take some more time from me. It would have been easier to see the diff if the contents had been moved as an NFC patch to a separate file, and then applying the optimizations in this patch. But it's done now so I'll deal with it :)

Jan 20 2022, 2:02 AM · Restricted Project

Jan 17 2022

salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Friendly ping.

Jan 17 2022, 2:06 PM · Restricted Project

Jan 7 2022

salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Move comments

Jan 7 2022, 2:21 AM · Restricted Project
salman-javed-nz added a comment to D116378: [clang-tidy] Disable clang-tidy warnings from system macros.

By the way, the similar problem exists in Clang compiler. I have written in cfe-dev, Discourse and submitted an issue without any feedback so far (I understand it's been vacation). Do you think it would be beneficial to implement a similar fix there? I don't know if the fix is as straightforward as in clang-tidy or if it will have to be done on a per-check basis.

Jan 7 2022, 1:44 AM · Restricted Project

Jan 6 2022

salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Updated according to review comments

  • Move NoLintToken and other support classes to the CPP file.
  • Create a NoLintPragmaHandler class which owns the cache. Access this class through a PIMPL.
  • Use StringSwitch instead of StringMap.
  • Store the GlobList object instead of repeatedly constructing temporaries.
  • Remove Unknown from the NoLintType enum.
  • Add constructors to NoLintToken and NoLintBlockToken that can ensure that the objects are initialized with valid values.
  • Move shouldSuppressDiagnostic() into ClangTidyContext. This function took ClangTidyContext as a mutable ref anyway.
Jan 6 2022, 9:12 PM · Restricted Project
salman-javed-nz updated the summary of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 6 2022, 9:03 PM · Restricted Project
salman-javed-nz updated the summary of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Jan 6 2022, 8:58 PM · Restricted Project
salman-javed-nz added a comment to D116378: [clang-tidy] Disable clang-tidy warnings from system macros.

This resolves the long-standing gripe I have with clang-tidy raising warnings about GoogleTest macros expanded in my code. Good work.
Do you think we can close issues #44873, #43325, and #31587 now that we have this fix?

Jan 6 2022, 3:03 PM · Restricted Project
salman-javed-nz added inline comments to D116378: [clang-tidy] Disable clang-tidy warnings from system macros.
Jan 6 2022, 2:36 AM · Restricted Project

Dec 28 2021

salman-javed-nz planned changes to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 28 2021, 1:29 AM · Restricted Project

Dec 22 2021

salman-javed-nz committed rGd840f3edf029: Resolve -Wdocumentation warning in ClangTidyDiagnosticConsumer (NFC) (authored by salman-javed-nz).
Resolve -Wdocumentation warning in ClangTidyDiagnosticConsumer (NFC)
Dec 22 2021, 1:27 PM
salman-javed-nz committed rG86618e37bded: Resolve lint warning about converting unsigned to signed (NFC) (authored by salman-javed-nz).
Resolve lint warning about converting unsigned to signed (NFC)
Dec 22 2021, 12:52 PM
salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Thanks for taking a look. I will update the diff to address your comments. Have a good new years break.

Dec 22 2021, 12:24 PM · Restricted Project

Dec 21 2021

salman-javed-nz added a comment to D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Updated the review's edit permissions. Sorry about that, @kadircet.

Dec 21 2021, 12:46 PM · Restricted Project
salman-javed-nz changed the edit policy for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 21 2021, 12:37 PM · Restricted Project
salman-javed-nz added inline comments to rGb7d2d147477e: [clangd] Disable the NOLINTBBEGIN testcase in clangd..
Dec 21 2021, 1:54 AM

Dec 20 2021

salman-javed-nz updated the diff for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.

Remove unnecessary llvm:: qualification.

Dec 20 2021, 11:45 PM · Restricted Project
salman-javed-nz retitled D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks from *WIP* [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks to [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 11:27 PM · Restricted Project
salman-javed-nz changed the visibility for D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 11:03 PM · Restricted Project
salman-javed-nz updated the summary of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 10:29 PM · Restricted Project
salman-javed-nz updated the summary of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 10:29 PM · Restricted Project
salman-javed-nz updated the summary of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 10:28 PM · Restricted Project
salman-javed-nz retitled D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks from [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks to *WIP* [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 10:27 PM · Restricted Project
salman-javed-nz requested review of D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks.
Dec 20 2021, 10:26 PM · Restricted Project

Dec 14 2021

salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Hi @salman-javed-nz !
Also I am not sure what kind of timelines you have in mind for the performance improvements, but I think it would be great to have them before LLVM-14 release, as otherwise we might have some (extra) discrepancies between clang-tidy CLI vs clangd integration, which would be unfortunate.

Hi @kadircet. Today I fixed the last of the bugs in my caching implementation. I still need to run some tests to quantify the performance improvement before submitting the code for a review.

Dec 14 2021, 10:05 AM · Restricted Project
salman-javed-nz added a comment to D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:)..

It could be made to be useful outside of LLVM, but as it stands today, the check is only intended to be useful for LLVM. If we want to make it useful outside of LLVM, that's fine, but there's a bit more to do (for example, the check should be exposed outside of the llvm module) and that includes generalizing the check.

Dec 14 2021, 9:50 AM · Restricted Project
salman-javed-nz added inline comments to D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:)..
Dec 14 2021, 2:57 AM · Restricted Project
salman-javed-nz added inline comments to D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:)..
Dec 14 2021, 2:55 AM · Restricted Project
salman-javed-nz added a comment to D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:)..

The problem at the heart of all this is that llvm-header-guard isn't written flexible enough to support non-LLVM project structures.

Dec 14 2021, 2:15 AM · Restricted Project

Dec 8 2021

salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Hi, just giving a progress update. This is just a early heads-up - no action needed from you at this stage.

Dec 8 2021, 1:47 AM · Restricted Project

Dec 5 2021

salman-javed-nz added a comment to D115115: [doc] Fix namespace comment style in Coding Guidelines.

The ~6700 instances of // end namespace - do you observe any trend, e.g. are they concentrated in one of the LLVM sub-projects? Is it similar to the situation we have with the readability-identifier-naming check, where a number of sub-projects have disabled it in their sub-directory's .clang-tidy file?

Dec 5 2021, 12:40 PM · Restricted Project

Dec 3 2021

salman-javed-nz accepted D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h.

LGTM. The use of mutable with public inheritence is all over the clang-tools-extra code. See class SwapIndex : public SymbolIndex. I don't see why your use would be against the norm.

Dec 3 2021, 2:31 PM · Restricted Project

Dec 2 2021

salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Update: OK I see you have already changed your patch to make the feature enabled by default.
As far as the performance is concerned, I will have a go at improving it and hope to have something to share next week. How does that sound?

Dec 2 2021, 2:12 PM · Restricted Project
salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

With regards to reverting it, is the cat out of the bag? I already see some usage of the NOLINTBEGIN feature in other projects.
There's also a NOLINT check globbing feature that builds on top of this, so it's not as simple as just backing out one commit.

If this is the approach we take, I prefer the logic to be switched around: the NOLINT block feature should be enabled by default. Once (the worst of) this performance issue is resolved, it would be nice from a usability perspective if the user did not have to explicitly opt in to use the feature.

Dec 2 2021, 2:06 PM · Restricted Project
salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

If the current code stayed in the main repo, how long could you afford to wait for me to provide a patch?

I would say that for me personally, at a maximum, we have to either fix or revert before this goes out in a release of Clang (because Clang 13 did not have support for NOLINTBEGIN/NOLINTEND, so this is technically unreleased functionality).

Dec 2 2021, 12:42 PM · Restricted Project
salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

I can have a go at coming up with a solution where it does caching of the NOLINT marker positions when a diagnostic is generated in a file. That would probably help a lot with the performance. It wouldn't be too complicated to implement either. Would you be happy with something like that?

Dec 2 2021, 12:26 PM · Restricted Project
salman-javed-nz added a comment to D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Thanks for the investigation. Just exploring the options...

Dec 2 2021, 12:21 PM · Restricted Project

Nov 30 2021

salman-javed-nz added a comment to D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h.

Will aim to review and come back to you in a couple of days.

Nov 30 2021, 12:17 PM · Restricted Project

Nov 29 2021

salman-javed-nz committed rGc7aa358798e6: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier" (authored by salman-javed-nz).
[clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"
Nov 29 2021, 3:44 PM
salman-javed-nz closed D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".
Nov 29 2021, 3:44 PM · Restricted Project
salman-javed-nz updated the diff for D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".

Update "iff" comment based on review.

Nov 29 2021, 2:13 PM · Restricted Project
salman-javed-nz added a comment to D114427: [clang-tidy] Warn on functional C-style casts.

Nothing else that comes to mind that I want to see.
@Quuxplusone are you OK with the latest round of diffs?

Nov 29 2021, 12:32 PM · Restricted Project
salman-javed-nz added inline comments to D114427: [clang-tidy] Warn on functional C-style casts.
Nov 29 2021, 12:11 PM · Restricted Project
salman-javed-nz added a comment to D114427: [clang-tidy] Warn on functional C-style casts.

I think the primary goal is satisfied - in all cases the cast is identified and a warning is generated.

Nov 29 2021, 2:12 AM · Restricted Project
salman-javed-nz added inline comments to D114427: [clang-tidy] Warn on functional C-style casts.
Nov 29 2021, 1:29 AM · Restricted Project

Nov 27 2021

salman-javed-nz accepted D114427: [clang-tidy] Warn on functional C-style casts.

LGTM, thanks!

Nov 27 2021, 6:40 PM · Restricted Project

Nov 26 2021

salman-javed-nz added inline comments to D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions.
Nov 26 2021, 2:08 AM · Restricted Project
salman-javed-nz added inline comments to D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions.
Nov 26 2021, 2:05 AM · Restricted Project
salman-javed-nz added inline comments to D114427: [clang-tidy] Warn on functional C-style casts.
Nov 26 2021, 12:15 AM · Restricted Project
salman-javed-nz added a comment to D114427: [clang-tidy] Warn on functional C-style casts.

Thanks for the patch.

Nov 26 2021, 12:10 AM · Restricted Project

Nov 23 2021

salman-javed-nz added a comment to D114317: [clang-tidy][WIP] Do not run perfect alias checks.

What would you say are the key differences between this patch differ and previous attempts, e.g. https://reviews.llvm.org/D72566? How does this patch address the concerns raised in the previous reviews?

Nov 23 2021, 11:53 AM · Restricted Project, Restricted Project

Nov 22 2021

salman-javed-nz committed rGa82942dd07ea: Add missing clang-tidy args in index.rst (NFC) (authored by salman-javed-nz).
Add missing clang-tidy args in index.rst (NFC)
Nov 22 2021, 1:55 AM
salman-javed-nz committed rG83484f8472ad: Fix nits in clang-tidy's documentation (NFC) (authored by salman-javed-nz).
Fix nits in clang-tidy's documentation (NFC)
Nov 22 2021, 12:11 AM

Nov 20 2021

salman-javed-nz added a comment to D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".

I reverted my changes to do with the invalid character substitution. Doing something akin to isAllowedInitiallyIDChar() and isAllowedIDChar() in Lexer.cpp will require converting from char* to UTF32*. Windows complicates things by using its own code page (typically Windows-1252). Will require a lot of careful consideration to implement correctly.

Nov 20 2021, 5:34 AM · Restricted Project
salman-javed-nz updated the diff for D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".

Back out the changes to the "replace invalid characters in an identifier with underscores" feature.
Making this feature work with Unicode characters on different operating systems significantly increases the amount of code change required.
This can always be revisited in another patch.

Nov 20 2021, 5:04 AM · Restricted Project

Nov 19 2021

salman-javed-nz planned changes to D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier".
Nov 19 2021, 3:02 AM · Restricted Project