- User Since
- Feb 15 2019, 11:53 AM (30 w, 2 d)
Jun 24 2019
Jun 19 2019
Jun 6 2019
Jun 5 2019
Thank you! I did apply for committer status today but I don't know how long it takes to get it.
Could you be more specific about your concerns? I'm happy to fix any problems in this change.
Could someone please commit for me?
Jun 4 2019
Extracted lock/unlock code to util file, combined __llvm functions.
Forgot to declare a variable.
Jun 3 2019
Fixed lock/unlock code.
Added explicit merging API and test.
May 30 2019
On further thought, I don't think having a boolean that tells the runtime "user code is controlling locking so it is safe to merge" is a good idea, because typically __llvm_profile_write_file is invoked at exit. User code would have to ensure that it locks the file at the very end of its execution, when it has collected the desired profiling data, but before __lvm_profile_write_file is invoked. Also, in the current implementation, whether or not merging happens is controlled by the pattern of the profiling file name (whether or not it has a %m in it).
May 29 2019
@davidxl We could also have the openFileForMerging function invoke lprofLockFd on the user-provided file, rather than putting the onus for locking on the user. How would you feel about that?
Cleaned up logic and added safe-for-merge bool to API.
Added support for merging, docs, and test case.
May 28 2019
Mar 13 2019
I was debating whether I should pull -num-threads out of the docs for show and move it to the top-level options section, or make a copy of it in the export options section. I went with putting a copy of it in export because only show and export use it and the behavior is subtly different (show only uses it if -output-dir is set, export uses it unconditionally).
- Changed how -num-threads is documented.
- Added docs for new llvm-cov flags.
Thanks for all the feedback, Max and Vedant!
- Added tests for the -skip-* flags.
- Minor changes in response to code review.