- User Since
- Dec 7 2017, 3:22 PM (88 w, 3 d)
May 6 2019
Hey, still motivated to land this, but definitely don't want to break any existing workflows.
Apr 25 2019
Sorry, coming back to this - line-filters are _inclusive_, so how do you indicate a 0-length range from the command line?
Apr 11 2019
Thanks for the explanation! I do understand your philosophy on this, and agree with the desired behavior case you brought up where you have put in new braces.
Apr 1 2019
klimek: I'm sorry, I don't fully understand your proposed fix. Could you explain it in more detail?
Mar 22 2019
@MyDeveloperDay Thanks for the approve! Yes, this patch has been working for us as we've been using it on an internal fork since I opened the patch. As I mentioned, without this patch clang-format is useless for us in CI.
@MyDeveloperDay Thanks for the approve! I'm not sure what the lingering concerns are, as far as I know there have been no concerns since october of last year.
@djasper Do you have any further concerns about this patch?
Mar 21 2019
Yes, I don’t have commit access and would need someone else to land the patch. Thanks!
Sorry for the ambiguity. I meant, "running clang-format on the changed lines locally was not enough". I'll edit the description to clarify.
Ping! Still looking for help on this - I definitely don't want to diminish the complexity of this code, and would really appreciate any help getting this in. I've already apologized for the gap from feedback in July 2018 to response in October - and I'm happy to again - unfortunately sometimes life gets in the way! Please let me know if there's anything I can do to get this patch landed. As far as I understand, all outstanding comments on the code have been addressed.
Mar 14 2019
Bump! Still waiting feedback on this.
Bump! Still looking for help here - thanks for the consideration.
Feb 28 2019
Bump! Would really appreciate any feedback on this!
Feb 11 2019
Bump! Thanks for the consideration! Again, this is preventing us from rolling out automated style checking on diffs at work.
Bump! Still watching this space - thanks so much for your time!
Feb 4 2019
Bump! Thanks for the consideration
Bump! Thanks for the consideration.
Jan 18 2019
Thanks for the feedback! Does this mean that this won't be accepted? In my opinion, without these extra options, AllowAllParametersOfDeclarationOnNextLine is a very strange option. I don't think I'm the only one who feels this way, based on the stack overflow questions linked in the description. However, I fully understand if these changes are not wanted.
Thanks for the feedback! This actually isn't a new formatting option, rather it's fixing a bug where clang-format would change lines outside of the line range asked for by the user. This was preventing us from using clang-format in an automated setting.
Jan 14 2019
Ping! Thanks for your consideration. I'm still quite motivated to land this, please let me know if there's anything I can do, or if it's an unwanted patch.
Thanks for the feedback!
Respond to feedback
Dec 3 2018
Bump! Thanks for your consideration.
Bump! Thanks again for your time. As far as I can tell, it's ready for another round of review!
Nov 26 2018
Bump! Thanks again for your consideration
Nov 25 2018
Nov 20 2018
Bump! Thanks again for your consideration.
Nov 15 2018
bump! Thanks for your consideration.
Nov 5 2018
Bump! Still looking for feedback on the latest round of changes.
Oct 29 2018
Bump! Thanks for your time
Oct 18 2018
Bump! Thanks for your time!
Oct 11 2018
Sorry for dropping this for so long! Stuff got busy at work and I've been happily using my fork with this change for some time. I would really like this to get in, and promise to be responsive to feedback.
Added suggested for loops to the test
Jul 9 2018
Thanks again for your time.
Jun 11 2018
Bump! Thanks again for your feedback.
May 30 2018
May 16 2018
Bump! Thanks for your consideration
Apr 27 2018
Okay; I think I've responded to all feedback at this point. Thanks for your patience guiding me through my first contribution to this project. Let me know what else I can do to help get this merged!
Apr 26 2018
Further update doc comments, render rst file
Responded to review feedback.
Mar 22 2018
Bump again! Any feedback would be quite appreciated.
Mar 12 2018
Feb 20 2018
Bumping again - thanks so much for your time!
Feb 13 2018
Ping! I believe all feedback has been addressed - further consideration would be much appreciated.
Feb 7 2018
Thanks for the feedback! I'm very motivated to get some support for these features since they are required for my style guide. Let me know if my recent changes made sense to you.
Responded to review feedback:
- Fix bug where AllowAllArgumentsOnNextLine overrode AllowAllParametersOfDeclarationOnNextLine
- Add tests demonstrating independence of AllowAllArgumentsOnNextLine and AllowAllParametersOfDeclarationOnNextLine
- Add test showing AllowAllConstructorInitializersOnNextLine doesn't affect single-line constructors
- Removed unnecessary re-setting of llvm styles
- Removed bonus line from test
Jan 11 2018
ping! Thanks for your consideration