Page MenuHomePhabricator

russellmcc (Russell McClellan)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2017, 3:22 PM (79 w, 3 d)

Recent Activity

May 6 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Hey, still motivated to land this, but definitely don't want to break any existing workflows.

May 6 2019, 10:17 AM · Restricted Project

Apr 25 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Sorry, coming back to this - line-filters are _inclusive_, so how do you indicate a 0-length range from the command line?

Apr 25 2019, 8:47 AM · Restricted Project

Apr 11 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Thanks for the explanation! I do understand your philosophy on this, and agree with the desired behavior case you brought up where you have put in new braces.

Apr 11 2019, 8:26 AM · Restricted Project

Apr 1 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

klimek: I'm sorry, I don't fully understand your proposed fix. Could you explain it in more detail?

Apr 1 2019, 7:58 AM · Restricted Project

Mar 22 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

@MyDeveloperDay Thanks for the approve! Yes, this patch has been working for us as we've been using it on an internal fork since I opened the patch. As I mentioned, without this patch clang-format is useless for us in CI.

Mar 22 2019, 12:10 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

@MyDeveloperDay Thanks for the approve! I'm not sure what the lingering concerns are, as far as I know there have been no concerns since october of last year.

Mar 22 2019, 12:10 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

@djasper Do you have any further concerns about this patch?

Mar 22 2019, 10:03 AM · Restricted Project

Mar 21 2019

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Yes, I don’t have commit access and would need someone else to land the patch. Thanks!

Mar 21 2019, 6:46 PM · Restricted Project
russellmcc updated the summary of D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.
Mar 21 2019, 3:02 PM · Restricted Project
russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Sorry for the ambiguity. I meant, "running clang-format on the changed lines locally was not enough". I'll edit the description to clarify.

Mar 21 2019, 3:02 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Ping! Still looking for help on this - I definitely don't want to diminish the complexity of this code, and would really appreciate any help getting this in. I've already apologized for the gap from feedback in July 2018 to response in October - and I'm happy to again - unfortunately sometimes life gets in the way! Please let me know if there's anything I can do to get this patch landed. As far as I understand, all outstanding comments on the code have been addressed.

Mar 21 2019, 2:51 PM · Restricted Project

Mar 14 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Bump! Still waiting feedback on this.

Mar 14 2019, 3:26 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Still looking for help here - thanks for the consideration.

Mar 14 2019, 3:26 PM · Restricted Project

Feb 28 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Bump!

Feb 28 2019, 7:50 AM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Would really appreciate any feedback on this!

Feb 28 2019, 7:50 AM · Restricted Project

Feb 11 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Bump! Thanks for the consideration! Again, this is preventing us from rolling out automated style checking on diffs at work.

Feb 11 2019, 3:05 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Still watching this space - thanks so much for your time!

Feb 11 2019, 3:03 PM · Restricted Project

Feb 4 2019

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Bump! Thanks for the consideration

Feb 4 2019, 2:09 PM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks for the consideration.

Feb 4 2019, 2:09 PM · Restricted Project

Jan 18 2019

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Thanks for the feedback! Does this mean that this won't be accepted? In my opinion, without these extra options, AllowAllParametersOfDeclarationOnNextLine is a very strange option. I don't think I'm the only one who feels this way, based on the stack overflow questions linked in the description. However, I fully understand if these changes are not wanted.

Jan 18 2019, 1:41 PM · Restricted Project
russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Thanks for the feedback! This actually isn't a new formatting option, rather it's fixing a bug where clang-format would change lines outside of the line range asked for by the user. This was preventing us from using clang-format in an automated setting.

Jan 18 2019, 1:38 PM · Restricted Project

Jan 14 2019

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Ping! Thanks for your consideration. I'm still quite motivated to land this, please let me know if there's anything I can do, or if it's an unwanted patch.

Jan 14 2019, 8:15 AM · Restricted Project
russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Thanks for the feedback!

Jan 14 2019, 8:14 AM · Restricted Project
russellmcc updated the diff for D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Respond to feedback

Jan 14 2019, 8:14 AM · Restricted Project

Dec 3 2018

russellmcc added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

Bump! Thanks for your consideration.

Dec 3 2018, 7:31 AM · Restricted Project
russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks again for your time. As far as I can tell, it's ready for another round of review!

Dec 3 2018, 7:30 AM · Restricted Project

Nov 26 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks again for your consideration

Nov 26 2018, 7:15 AM · Restricted Project

Nov 25 2018

russellmcc updated the diff for D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.
Nov 25 2018, 2:34 PM · Restricted Project
russellmcc created D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.
Nov 25 2018, 2:32 PM · Restricted Project

Nov 20 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks again for your consideration.

Nov 20 2018, 3:41 PM · Restricted Project

Nov 15 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

bump! Thanks for your consideration.

Nov 15 2018, 10:04 AM · Restricted Project

Nov 5 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Still looking for feedback on the latest round of changes.

Nov 5 2018, 8:27 AM · Restricted Project

Oct 29 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks for your time

Oct 29 2018, 3:27 PM · Restricted Project

Oct 18 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks for your time!

Oct 18 2018, 4:35 PM · Restricted Project

Oct 11 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Sorry for dropping this for so long! Stuff got busy at work and I've been happily using my fork with this change for some time. I would really like this to get in, and promise to be responsive to feedback.

Oct 11 2018, 1:36 PM · Restricted Project
russellmcc updated the diff for D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Added suggested for loops to the test

Oct 11 2018, 1:11 PM · Restricted Project

Jul 9 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Thanks again for your time.

Jul 9 2018, 9:56 AM · Restricted Project

Jun 11 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks again for your feedback.

Jun 11 2018, 7:19 AM · Restricted Project

May 30 2018

russellmcc added inline comments to D40988: Clang-format: add finer-grained options for putting all arguments on one line.
May 30 2018, 7:57 AM · Restricted Project

May 16 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump! Thanks for your consideration

May 16 2018, 7:59 AM · Restricted Project

Apr 27 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Okay; I think I've responded to all feedback at this point. Thanks for your patience guiding me through my first contribution to this project. Let me know what else I can do to help get this merged!

Apr 27 2018, 9:52 AM · Restricted Project

Apr 26 2018

russellmcc updated the diff for D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Further update doc comments, render rst file

Apr 26 2018, 10:08 PM · Restricted Project
russellmcc updated the diff for D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Responded to review feedback.

Apr 26 2018, 8:47 PM · Restricted Project

Mar 22 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump again! Any feedback would be quite appreciated.

Mar 22 2018, 7:57 AM · Restricted Project

Mar 12 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bump!

Mar 12 2018, 1:38 PM · Restricted Project

Feb 20 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Bumping again - thanks so much for your time!

Feb 20 2018, 11:24 AM · Restricted Project

Feb 13 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Ping! I believe all feedback has been addressed - further consideration would be much appreciated.

Feb 13 2018, 10:21 AM · Restricted Project

Feb 7 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Thanks for the feedback! I'm very motivated to get some support for these features since they are required for my style guide. Let me know if my recent changes made sense to you.

Feb 7 2018, 12:56 PM · Restricted Project
russellmcc updated the diff for D40988: Clang-format: add finer-grained options for putting all arguments on one line.

Responded to review feedback:

  • Fix bug where AllowAllArgumentsOnNextLine overrode AllowAllParametersOfDeclarationOnNextLine
  • Add tests demonstrating independence of AllowAllArgumentsOnNextLine and AllowAllParametersOfDeclarationOnNextLine
  • Add test showing AllowAllConstructorInitializersOnNextLine doesn't affect single-line constructors
  • Removed unnecessary re-setting of llvm styles
  • Removed bonus line from test
Feb 7 2018, 12:50 PM · Restricted Project

Jan 11 2018

russellmcc added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

ping! Thanks for your consideration

Jan 11 2018, 7:27 AM · Restricted Project

Dec 20 2017

uohcsemaj awarded D40988: Clang-format: add finer-grained options for putting all arguments on one line a Like token.
Dec 20 2017, 5:29 PM · Restricted Project

Dec 7 2017

russellmcc created D40988: Clang-format: add finer-grained options for putting all arguments on one line.
Dec 7 2017, 3:29 PM · Restricted Project