- User Since
- Nov 11 2013, 8:38 PM (363 w, 1 d)
May 27 2014
Karthik, I do not have any objections to this patch. I think longer term we
should try to pursue the other cases but this is a good short-term step.
May 23 2014
Typo: "the common uses *are *on separate paths..."
I agree this is an improvement, but this approach is still failing to catch
cases where the common uses are not on separate paths on the tree. In those
cases no matter which order we take there will be a common use that can't
May 21 2014
Is it really the depth of the subtrees that is the fundamental issue? Or is it really the relative depths of the common uses? If the latter, this patch wouldn't be addressing the general case.
May 1 2014
I agree this combining can in theory be done as part of SLP vectorization,
targeting wider scalar registers as a limited form of vector hardware,
supporting wider loads/stores and some bitwise operations. That would
likely catch more cases than what can be done with a small standalone pass.