Page MenuHomePhabricator

rsilvera (Raul Silvera)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2013, 8:38 PM (363 w, 1 d)

Recent Activity

May 27 2014

rsilvera added a comment to D3800: Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads.

Karthik, I do not have any objections to this patch. I think longer term we
should try to pursue the other cases but this is a good short-term step.

May 27 2014, 10:21 PM

May 23 2014

rsilvera added a comment to D3800: Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads.

Typo: "the common uses *are *on separate paths..."

May 23 2014, 11:01 AM
rsilvera added a comment to D3800: Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads.

I agree this is an improvement, but this approach is still failing to catch
cases where the common uses are not on separate paths on the tree. In those
cases no matter which order we take there will be a common use that can't
be scheduled.

May 23 2014, 11:00 AM

May 21 2014

rsilvera added a comment to D3800: Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads.

Is it really the depth of the subtrees that is the fundamental issue? Or is it really the relative depths of the common uses? If the latter, this patch wouldn't be addressing the general case.

May 21 2014, 3:57 PM

May 1 2014

rsilvera added a comment to D3580: Add Load Combine Pass.

I agree this combining can in theory be done as part of SLP vectorization,
targeting wider scalar registers as a limited form of vector hardware,
supporting wider loads/stores and some bitwise operations. That would
likely catch more cases than what can be done with a small standalone pass.

May 1 2014, 4:59 PM

Apr 30 2014

rsilvera added inline comments to D3560: Vectorize math intrinsic calls in SLPVectorizer.
Apr 30 2014, 10:18 AM