Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

rpereira-dev (Romain PEREIRA)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2023, 12:29 PM (37 w, 3 d)

Recent Activity

Aug 24 2023

rpereira-dev updated the diff for D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.

Got trolled yet again by automatic format...

  • Fixed indentation of the 'list' version of the __kmp_depnode_link_successor routine
Aug 24 2023, 12:35 PM · Restricted Project, Restricted Project
rpereira-dev updated the diff for D158416: [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint.
  • Fixed tests comment that got formatted by previous git clang-format
  • Fixed throttling on the maximum number of tasks per thread; previous version would crash if this was larger than the original queue size: queues are now resizing
Aug 24 2023, 12:29 PM · Restricted Project, Restricted Project
rpereira-dev added a comment to D158416: [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint.

Few issues in this patch, fixing it, please wait

Aug 24 2023, 11:45 AM · Restricted Project, Restricted Project
rpereira-dev updated the diff for D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
  • Added missing RUN lines in the test files
  • Added REQUIRES: linux in the test files
  • Added an additional out: y node in the inoutset test
  • Manually fixed indentation failing on git clang-format
Aug 24 2023, 11:31 AM · Restricted Project, Restricted Project

Aug 23 2023

rpereira-dev updated the diff for D158416: [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint.

Added context with the patch

Aug 23 2023, 7:30 PM · Restricted Project, Restricted Project
rpereira-dev updated the diff for D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.

Added tests corresponding to the minimal code example attached previously

Aug 23 2023, 7:22 PM · Restricted Project, Restricted Project
rpereira-dev retitled D158416: [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint from Adding a throttling threshold to bound dependent tasking memory footprint to [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint.
Aug 23 2023, 12:09 PM · Restricted Project, Restricted Project
rpereira-dev updated the diff for D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.

Reverted (source, sink) names swap of the __kmp_depnode_link_successor function; added a comment instead

Aug 23 2023, 11:43 AM · Restricted Project, Restricted Project
rpereira-dev added a comment to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.

The semantically orthogonal patches should be submitted separately. Merged the changes are hard to review.
I really doubt that your changes have the suggested effect. Did you verify that there is any effect?

Aug 23 2023, 11:41 AM · Restricted Project, Restricted Project
rpereira-dev added inline comments to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 23 2023, 11:34 AM · Restricted Project, Restricted Project
rpereira-dev added inline comments to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 23 2023, 8:29 AM · Restricted Project, Restricted Project
rpereira-dev added inline comments to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 23 2023, 7:46 AM · Restricted Project, Restricted Project
rpereira-dev added inline comments to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 23 2023, 7:20 AM · Restricted Project, Restricted Project
rpereira-dev added inline comments to D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 23 2023, 1:31 AM · Restricted Project, Restricted Project

Aug 22 2023

rpereira-dev updated the summary of D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 22 2023, 1:18 PM · Restricted Project, Restricted Project
rpereira-dev requested review of D158544: [OpenMP] Optimized trivial multiple edges from task dependency graph.
Aug 22 2023, 1:15 PM · Restricted Project, Restricted Project

Aug 21 2023

rpereira-dev requested review of D158416: [OpenMP] Adding a throttling threshold to bound dependent tasking memory footprint.
Aug 21 2023, 5:14 AM · Restricted Project, Restricted Project