Page MenuHomePhabricator

rocallahan (Robert O'Callahan)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2018, 2:49 AM (51 w, 16 h)

Recent Activity

Jul 4 2019

rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Sorry for not responding earlier. Phabricator insists on sending me emails about all issues in the system, and I never figured out how to get GMail to show me only emails about Phabricator issues I'm CCed on.

Jul 4 2019, 2:16 PM · Restricted Project, lld

Apr 10 2019

rocallahan added inline comments to D60509: Mark non-alloc sections after marking alloc sections.
Apr 10 2019, 1:36 PM · Restricted Project
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

I don't have commit access so I believe someone has to commit this for me?

Apr 10 2019, 3:11 AM · Restricted Project, lld

Apr 9 2019

rocallahan added inline comments to D54747: Discard debuginfo for object files empty after GC.
Apr 9 2019, 3:33 AM · Restricted Project, lld
rocallahan updated the diff for D54747: Discard debuginfo for object files empty after GC.

The results are basically unchanged with the section type checks removed, so I've just gone ahead and done that.

Apr 9 2019, 12:25 AM · Restricted Project, lld

Apr 8 2019

rocallahan added inline comments to D54747: Discard debuginfo for object files empty after GC.
Apr 8 2019, 11:55 PM · Restricted Project, lld
rocallahan added inline comments to D54747: Discard debuginfo for object files empty after GC.
Apr 8 2019, 11:18 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

I am also pleased to report that for my real project, switching from ld.bfd to lld + this patch reduces the total size of our dist built binaries from 2.9GB to 2.0GB.

Apr 8 2019, 10:37 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Updated results for the rusoto test in https://github.com/rust-lang/rust/issues/56068#issue-382175735. The test changed a bit because I'm using an updated Rust toolchain and rusoto_core 0.37.0.

Apr 8 2019, 10:12 PM · Restricted Project, lld
rocallahan updated the diff for D54747: Discard debuginfo for object files empty after GC.

Addressed all comments AFAIK. I'll post some performance numbers in a moment.

Apr 8 2019, 10:00 PM · Restricted Project, lld

Mar 25 2019

rocallahan added inline comments to D54747: Discard debuginfo for object files empty after GC.
Mar 25 2019, 1:07 PM · Restricted Project, lld

Mar 24 2019

rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Another clarification:

DWARF type information currently shared between functions in the same CU would have to be duplicated.

Mar 24 2019, 6:37 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

To be clear, I think the best long-term solution is for LLD to rewrite the DWARF, but from my (admittedly limited) perspective that seems to be at best a distant prospect.

Mar 24 2019, 6:30 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Do you have numbers with ld.bfd and gold?

Mar 24 2019, 6:26 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

@rocallahan I find that people are discussing a generic approach in D59553

Mar 24 2019, 6:25 PM · Restricted Project, lld

Mar 20 2019

Herald added a project to D54747: Discard debuginfo for object files empty after GC: Restricted Project.

Ping?

Mar 20 2019, 10:31 PM · Restricted Project, lld

Dec 30 2018

rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

I agree that ideally the linker would be able to do fine-grained GC of DWARF at the granularity of individual DIEs and other data items. However, implementing that would be a huge project. Currently AFAICT lld does very little DWARF processing. Wholesale DWARF rewriting would expand the scope of the linker and require lots of testing against various DWARF producers and consumers. I definitely wouldn't want to implement that.

Dec 30 2018, 4:09 PM · Restricted Project, lld
rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Here are some results for the rusoto test in https://github.com/rust-lang/rust/issues/56068#issue-382175735:

Dec 30 2018, 4:05 PM · Restricted Project, lld

Dec 28 2018

rocallahan added a comment to D54747: Discard debuginfo for object files empty after GC.

Sorry for the delayed reply. I just discovered that Phabricator nofications were being buried by my mail filters.

Dec 28 2018, 11:17 PM · Restricted Project, lld

Nov 20 2018

rocallahan created D54747: Discard debuginfo for object files empty after GC.
Nov 20 2018, 3:02 AM · Restricted Project, lld