rkirsling (Ross Kirsling)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2018, 10:25 AM (16 w, 1 d)

Recent Activity

Jun 13 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

I'll need someone to commit. Thanks!

Jun 13 2018, 9:44 AM

Jun 12 2018

rkirsling updated the diff for D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Addressed feedback—thank you for the review!

Jun 12 2018, 11:22 AM

Jun 4 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

FWIW, please note that this space-before-brace style is not specific to WebKit; CppCoreGuidelines exhibits it as well:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax

Jun 4 2018, 10:49 AM

May 31 2018

rkirsling updated the diff for D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Resolved another rebase conflict to keep this patch mergeable.

May 31 2018, 9:29 PM

May 24 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

@klimek In our IRC discussion yesterday, I know you expressed disapproval of WebKit's choice, but given its reality, am I correct in concluding that this can be landed?

May 24 2018, 12:16 PM

May 16 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

If there are no objections to this change, may I request a commit based on the approval that @jfb provided?

May 16 2018, 3:07 PM

May 11 2018

rkirsling updated the diff for D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Updated patch to resolve conflict and include full diff context.

May 11 2018, 10:35 AM

May 7 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Any further commentary? :)

May 7 2018, 12:35 PM

Apr 30 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Rule has been published:
https://webkit.org/code-style-guidelines/#spacing-braced-init

Apr 30 2018, 2:10 PM

Apr 27 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Guidelines page has been updated (https://trac.webkit.org/changeset/231085), though it may take a bit for the website to update.

Apr 27 2018, 10:25 AM

Apr 26 2018

rkirsling added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Is this written down somewhere? https://webkit.org/code-style-guidelines/ doesn't seem to mention it.

Apr 26 2018, 10:02 AM

Apr 24 2018

rkirsling created D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..
Apr 24 2018, 10:56 AM