Page MenuHomePhabricator

rja (Joe)
User

Projects

User does not belong to any projects.

User Details

User Since
May 8 2018, 3:39 PM (58 w, 1 d)

Recent Activity

May 17 2018

rja added inline comments to D43424: [clang-doc] Implement a (simple) Markdown generator.
May 17 2018, 1:38 PM · Restricted Project
rja accepted D47012: [X86] Scalar mask and scalar move optimizations.

looks fine

May 17 2018, 1:37 PM
rja accepted D47015: [llvm-exegesis] Improve documentation..

LG

May 17 2018, 1:35 PM
rja accepted D46882: [X86][CET] Changing -fcf-protection behavior to comply with gcc (LLVM part).

LG

May 17 2018, 1:17 AM

May 16 2018

rja added a comment to D45736: [SimplifyLibcalls] Replace locked IO with unlocked IO.

LG

May 16 2018, 12:39 AM
rja accepted D46826: [VPlan] Add VPlan based sinkInstructions utility..

LGTM

May 16 2018, 12:37 AM

May 12 2018

rja accepted D45736: [SimplifyLibcalls] Replace locked IO with unlocked IO.

We should merge this patch to see the impact of this patch on real code bases. We can still revert it if too many problems.

May 12 2018, 5:15 AM

May 9 2018

rja accepted D45177: CStringChecker, check strlcpy/strlcat.

LG

May 9 2018, 12:56 AM

May 8 2018

rja accepted D46369: [llvm-objcopy] Add --strip-symbol (-N) option.

LGTM too

May 8 2018, 11:53 PM
rja added a comment to D41953: [LoopUnroll] Unroll and Jam.

Address feedback and added some pragma tests, with some related fixes. Split out some parts into other commits.

I'm still trying to work on making the analysis more accurate so this works on more loops. It would be good if LAA could be made to work here (to get versioning too) but it looks very vectoriser shaped and doesn't handle outer loop quite yet. DA as used here might be the only way, but may need to learn a few more tricks (or may need some fixes).

May 8 2018, 11:39 PM
rja accepted D46285: [InstCombine] snprintf optimizations.

LG.

May 8 2018, 5:33 PM
rja accepted D46567: [llvm-strip] Add support for -remove-section.

Add one more "defensive" cmp

May 8 2018, 3:52 PM
rja added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

+1 for JSON

May 8 2018, 3:48 PM · Restricted Project
rja added inline comments to D46285: [InstCombine] snprintf optimizations.
May 8 2018, 3:48 PM