Page MenuHomePhabricator

rgov (Ryan Govostes)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2013, 6:15 PM (326 w, 4 d)

Recent Activity

Jan 20 2017

rgov added a comment to D28955: [analyzer] Enable support for symbolic extension/truncation.

Are all the changes here related to the extension/truncation support, for instance the changes to test/Analysis/malloc.c? Can you move misc. cleanup changes to another review?

Jan 20 2017, 11:12 PM
rgov added a comment to D28952: [analyzer] Add new Z3 constraint manager backend.

Do you think you could upload the patch omitting all of the test case changes for now? Maybe include one as an example but it seems to be just adding %z3_cc1 so we don't need to see all of them right now.

Jan 20 2017, 11:04 PM
rgov awarded D28952: [analyzer] Add new Z3 constraint manager backend a Love token.
Jan 20 2017, 10:51 PM

Jan 6 2017

rgov committed rL291273: Replace smart quotes.
Replace smart quotes
Jan 6 2017, 12:04 PM

Jul 7 2016

rgov added a reviewer for D17954: Improvements to CFNumberCreate checker: NoQ.
Jul 7 2016, 1:43 PM

Jul 5 2016

rgov closed D21600: Add flag to control use of liveness tracking for global metadata.

I changed the flag to -asan-globals-live-support and committed as r274578 and r274579.

Jul 5 2016, 5:07 PM
rgov committed rL274579: [asan] Update tests according to r274578.
[asan] Update tests according to r274578
Jul 5 2016, 3:00 PM
rgov committed rL274578: [asan] Add a hidden option for Mach-O global metadata liveness tracking.
[asan] Add a hidden option for Mach-O global metadata liveness tracking
Jul 5 2016, 3:00 PM

Jun 26 2016

rgov committed rL273844: Move -ldl to the correct compiler invocation.
Move -ldl to the correct compiler invocation
Jun 26 2016, 10:51 PM

Jun 24 2016

rgov committed rL273741: [asan] Improve global-registration.c test.
[asan] Improve global-registration.c test
Jun 24 2016, 3:46 PM

Jun 23 2016

rgov committed rL273654: Change shared library load path to appease Android bot.
Change shared library load path to appease Android bot
Jun 23 2016, 11:55 PM
rgov committed rL273629: [asan] Add failure logging to global-registration.c test case.
[asan] Add failure logging to global-registration.c test case
Jun 23 2016, 4:33 PM

Jun 22 2016

rgov committed rL273476: [asan] Fix global-registration.c on Linux.
[asan] Fix global-registration.c on Linux
Jun 22 2016, 1:59 PM
rgov closed D20701: Test case for global registration.
Adding         test/asan/TestCases/Posix/global-registration.c
Transmitting file data .
Committed revision 273464.
Jun 22 2016, 1:07 PM
rgov committed rL273464: [asan] Add a test case for global registration.
[asan] Add a test case for global registration
Jun 22 2016, 1:06 PM
rgov updated the diff for D21600: Add flag to control use of liveness tracking for global metadata.
Jun 22 2016, 12:39 PM
rgov added a comment to D21600: Add flag to control use of liveness tracking for global metadata.

The dead-strip.c test is broken because:

Jun 22 2016, 12:37 PM
rgov added a comment to D21600: Add flag to control use of liveness tracking for global metadata.

I will also have to XFAIL the initialization-bug.cc test case again.

Jun 22 2016, 12:19 PM
rgov retitled D21600: Add flag to control use of liveness tracking for global metadata from to Add flag to control use of liveness tracking for global metadata.
Jun 22 2016, 1:43 AM

May 26 2016

rgov added inline comments to D20701: Test case for global registration.
May 26 2016, 2:12 PM
rgov retitled D20701: Test case for global registration from to Test case for global registration.
May 26 2016, 1:57 PM

May 6 2016

rgov committed rL268725: Fix whitespace and line wrapping. NFC..
Fix whitespace and line wrapping. NFC.
May 6 2016, 4:28 AM
rgov committed rL268724: [asan] add option to set shadow mapping offset.
[asan] add option to set shadow mapping offset
May 6 2016, 3:31 AM

May 4 2016

rgov added a comment to D18865: [asan] add option to set shadow mapping offset.

Not sure if I can re-open the revision. We got a failure on one of the PS4 buildbots:

May 4 2016, 6:34 PM
rgov committed rL268588: Revert "[asan] add option to set shadow mapping offset".
Revert "[asan] add option to set shadow mapping offset"
May 4 2016, 6:33 PM
rgov closed D18865: [asan] add option to set shadow mapping offset.
May 4 2016, 6:23 PM
rgov added a comment to D18865: [asan] add option to set shadow mapping offset.

Committed as r268586. git-svn lost the authorship information, sorry Aaron!

May 4 2016, 6:22 PM
rgov committed rL268586: [asan] add option to set shadow mapping offset.
[asan] add option to set shadow mapping offset
May 4 2016, 6:20 PM

Apr 7 2016

rgov accepted D18865: [asan] add option to set shadow mapping offset.

LGTM.

Apr 7 2016, 2:31 PM

Mar 31 2016

rgov added inline comments to D17954: Improvements to CFNumberCreate checker.
Mar 31 2016, 12:41 PM

Mar 30 2016

rgov committed rL264938: [asan] Mark the initialization-bug.cc unsupported on OS X Yosemite and older.
[asan] Mark the initialization-bug.cc unsupported on OS X Yosemite and older
Mar 30 2016, 3:27 PM

Mar 29 2016

rgov committed rL264766: [asan] Make the Darwin/dead-strip.c test require El Capitan or newer.
[asan] Make the Darwin/dead-strip.c test require El Capitan or newer
Mar 29 2016, 11:59 AM
rgov committed rL264764: Revert "[asan] Make the global_metadata_darwin.ll test require El Capitan or….
Revert "[asan] Make the global_metadata_darwin.ll test require El Capitan or…
Mar 29 2016, 11:32 AM
rgov committed rL264758: [asan] Make the global_metadata_darwin.ll test require El Capitan or newer.
[asan] Make the global_metadata_darwin.ll test require El Capitan or newer
Mar 29 2016, 11:04 AM

Mar 28 2016

rgov closed D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Committed as r264644.

Mar 28 2016, 2:03 PM
rgov closed D16737: Support for dead code stripping on Mach-O platforms.

Committed as r264645.

Mar 28 2016, 2:03 PM
rgov committed rL264652: [asan] Fix testcase for r264645.
[asan] Fix testcase for r264645
Mar 28 2016, 1:48 PM
rgov committed rL264645: [asan] Support dead code stripping on Mach-O platforms.
[asan] Support dead code stripping on Mach-O platforms
Mar 28 2016, 1:34 PM
rgov committed rL264644: [asan] Add runtime support for __asan_(un)register_image_globals.
[asan] Add runtime support for __asan_(un)register_image_globals
Mar 28 2016, 1:33 PM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

Added comments per @samsonov's requests. Renamed functions to use image instead of module which is consistent with LLDB. Changed AsanApplyToGlobals parameter back to const void *needle since it is not used as a flag within that function as @samsonov pointed out.

Mar 28 2016, 6:11 AM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

Renamed functions to __asan_(un)register_image_globals. image is the term used by lldb to refer to the main executable plus loaded libraries.

Mar 28 2016, 6:09 AM

Mar 9 2016

rgov updated the diff for D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Split into two functions per @samsonov's request. Just went with asan_register_module_globals and we can decide to rename it later if we care to.

Mar 9 2016, 5:54 AM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

Split into two functions per @samsonov's request.

Mar 9 2016, 5:52 AM

Mar 8 2016

rgov added inline comments to D17954: Improvements to CFNumberCreate checker.
Mar 8 2016, 3:52 AM
rgov retitled D17954: Improvements to CFNumberCreate checker from to Improvements to CFNumberCreate checker.
Mar 8 2016, 3:48 AM

Feb 10 2016

rgov added inline comments to D16841: Support for __asan_apply_to_globals in ASAN runtime library.
Feb 10 2016, 3:36 PM
rgov updated the diff for D16841: Support for __asan_apply_to_globals in ASAN runtime library.

I discovered that this change was incomplete due to duplicate registration of globals. I've changed this to use a per-library flag that indicates whether globals have been registered already, and ignores duplicate calls.

Feb 10 2016, 3:22 PM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

I added AddressSanitizerModule::ShouldUseMachOGlobalsSection and associated logic to disable this feature on unsupported target platforms.

Feb 10 2016, 3:13 PM
rgov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

I understand why: Globals are being registered repeatedly (once per object file that contains any globals).

Feb 10 2016, 2:13 AM
rgov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

Hm, holding off on committing. This regresses tests related to ODR.

Feb 10 2016, 12:58 AM

Feb 9 2016

rgov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

Thanks for review everyone, I'll commit shortly.

Feb 9 2016, 10:41 PM
rgov added a comment to D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Thanks for reviewing. It does need the LLVM change first. So I will wait to commit until after D16737: Support for dead code stripping on Mach-O platforms is approved.

Feb 9 2016, 9:46 AM

Feb 6 2016

rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

Add a test case, update the ABI version.

Feb 6 2016, 12:57 PM
rgov updated the diff for D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Update comment in test case to be more accurate.

Feb 6 2016, 12:06 PM
rgov updated the diff for D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Add a test case.

Feb 6 2016, 12:03 PM

Feb 5 2016

rgov updated the diff for D16841: Support for __asan_apply_to_globals in ASAN runtime library.

Update ABI version per @samsonov.

Feb 5 2016, 4:23 PM

Feb 2 2016

rgov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

To write a test, I'd use a source file like:

Feb 2 2016, 10:20 PM
rgov added a parent revision for D16737: Support for dead code stripping on Mach-O platforms: D16841: Support for __asan_apply_to_globals in ASAN runtime library.
Feb 2 2016, 10:11 PM
rgov retitled D16841: Support for __asan_apply_to_globals in ASAN runtime library from to Support for __asan_apply_to_globals in ASAN runtime library.
Feb 2 2016, 10:11 PM
rgov added inline comments to D16737: Support for dead code stripping on Mach-O platforms.
Feb 2 2016, 10:05 PM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.

Now this differential covers just the LLVM changes.

Feb 2 2016, 10:05 PM

Jan 31 2016

rgov added a comment to D16737: Support for dead code stripping on Mach-O platforms.

Quick illustration showing the idea:

Jan 31 2016, 11:25 PM
rgov added a reviewer for D16737: Support for dead code stripping on Mach-O platforms: beanz.
Jan 31 2016, 1:44 AM

Jan 29 2016

rgov added reviewers for D16737: Support for dead code stripping on Mach-O platforms: kubamracek, zaks.anna, samsonov, glider, kcc.
Jan 29 2016, 1:59 PM
rgov updated the diff for D16737: Support for dead code stripping on Mach-O platforms.
Jan 29 2016, 1:57 PM
rgov retitled D16737: Support for dead code stripping on Mach-O platforms from to Support for dead code stripping on Mach-O platforms.
Jan 29 2016, 1:55 PM

Dec 20 2015

rgov added a comment to D9600: Add scan-build python implementation.

I tried out intercept-build and found it very easy to use. I tried running it on projects that compile with both make and xcodebuild and it worked for both. Thanks for contributing this tool.

Dec 20 2015, 12:13 AM

Dec 17 2015

rgov added reviewers for D15609: [Patch 1/3]: Rebasing Ryan Govostes' STP patch for Clang SA: zaks.anna, dcoughlin.

Adding Anna and Devin as reviewers.

Dec 17 2015, 3:29 PM · Restricted Project
rgov added reviewers for D15611: [Patch 2/3]: Rebasing Ryan Govostes' STP patch for Clang SA: zaks.anna, dcoughlin.

Adding Anna and Devin as reviewers.

Dec 17 2015, 3:29 PM · Restricted Project
rgov added reviewers for D15612: [Patch 3/3]: Rebasing Ryan Govostes' STP patch for Clang SA: zaks.anna, dcoughlin.

Adding Anna and Devin as reviewers.

Dec 17 2015, 1:17 PM · Restricted Project