Page MenuHomePhabricator

reuk (Reuben Thomas)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2018, 2:58 PM (45 w, 4 d)

Recent Activity

Apr 15 2019

reuk committed rG407dd4d1693d: [clang-format] Fix -Wconversion-null warning in GCC (authored by reuk).
[clang-format] Fix -Wconversion-null warning in GCC
Apr 15 2019, 1:13 PM
reuk committed rC358441: [clang-format] Fix -Wconversion-null warning in GCC.
[clang-format] Fix -Wconversion-null warning in GCC
Apr 15 2019, 1:11 PM
reuk committed rL358441: [clang-format] Fix -Wconversion-null warning in GCC.
[clang-format] Fix -Wconversion-null warning in GCC
Apr 15 2019, 1:11 PM
reuk closed D60726: Fixed -Wconversion-null warning in GCC..
Apr 15 2019, 1:11 PM · Restricted Project, Restricted Project
reuk accepted D60726: Fixed -Wconversion-null warning in GCC..

LGTM

Apr 15 2019, 11:51 AM · Restricted Project, Restricted Project

Apr 9 2019

reuk added inline comments to D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Apr 9 2019, 2:25 AM · Restricted Project

Apr 8 2019

reuk closed D60320: [clang-format]: Add option to insert space after locical not operator.

Closed by https://reviews.llvm.org/rG91f60b44958f, https://reviews.llvm.org/rL357908, https://reviews.llvm.org/rC357908 (sorry, I forgot to update the body of the commit message to close this automatically)

Apr 8 2019, 5:57 AM · Restricted Project, Restricted Project
reuk committed rG91f60b44958f: [clang-format] Optionally insert a space after unary ! operator (authored by reuk).
[clang-format] Optionally insert a space after unary ! operator
Apr 8 2019, 5:55 AM
reuk committed rC357908: [clang-format] Optionally insert a space after unary ! operator.
[clang-format] Optionally insert a space after unary ! operator
Apr 8 2019, 5:53 AM
reuk committed rL357908: [clang-format] Optionally insert a space after unary ! operator.
[clang-format] Optionally insert a space after unary ! operator
Apr 8 2019, 5:53 AM

Apr 7 2019

reuk updated the diff for D60320: [clang-format]: Add option to insert space after locical not operator.

Fixed formatting nit.

Apr 7 2019, 5:34 AM · Restricted Project, Restricted Project
reuk added a comment to D60320: [clang-format]: Add option to insert space after locical not operator.

I updated ClangFormatStyleOptions.rst by hand, is there a way to do that automatically instead (for future patches)?

Apr 7 2019, 5:01 AM · Restricted Project, Restricted Project
reuk updated the diff for D60320: [clang-format]: Add option to insert space after locical not operator.

Updated with fixes. Thanks for pointing out that the options are ordered alphabetically, I hadn't noticed that!

Apr 7 2019, 5:01 AM · Restricted Project, Restricted Project

Apr 5 2019

reuk updated the diff for D60320: [clang-format]: Add option to insert space after locical not operator.
Apr 5 2019, 8:45 AM · Restricted Project, Restricted Project
reuk created D60320: [clang-format]: Add option to insert space after locical not operator.
Apr 5 2019, 8:42 AM · Restricted Project, Restricted Project

Mar 30 2019

reuk committed rG08a940d629fa: [clang-format]: Add NonEmptyParentheses spacing option (authored by reuk).
[clang-format]: Add NonEmptyParentheses spacing option
Mar 30 2019, 5:34 AM
reuk committed rC357344: [clang-format]: Add NonEmptyParentheses spacing option.
[clang-format]: Add NonEmptyParentheses spacing option
Mar 30 2019, 5:31 AM
reuk committed rL357344: [clang-format]: Add NonEmptyParentheses spacing option.
[clang-format]: Add NonEmptyParentheses spacing option
Mar 30 2019, 5:31 AM
reuk closed D55170: [clang-format]: Add NonEmptyParentheses spacing option.
Mar 30 2019, 5:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 20 2019

reuk updated the diff for D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Removed unnecessary parens.

Mar 20 2019, 12:38 PM · Restricted Project, Restricted Project, Restricted Project
reuk added inline comments to D55170: [clang-format]: Add NonEmptyParentheses spacing option.
Mar 20 2019, 6:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2019

reuk added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

@klimek I agree that the rule is somewhat arbitrary. However, it's the style rule of an established codebase with many users (I don't have a concrete number, but the project has 1400 stars on github). I've found this patch useful when contributing to JUCE and I thought others might too.

Mar 18 2019, 2:16 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2019

reuk updated the diff for D55170: [clang-format]: Add NonEmptyParentheses spacing option.
Mar 17 2019, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
reuk updated the diff for D55170: [clang-format]: Add NonEmptyParentheses spacing option.

@MyDeveloperDay I'm sorry, you're absolutely correct. I'd got some other JUCE-related changes mixed up in this PR. Should be fixed now.

Mar 17 2019, 6:01 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2019

reuk added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

@MyDeveloperDay I'm not sure you built this branch. Perhaps you applied this patch to an older version of the repo. For me, SpaceBeforeCpp11BracedListOptions is defined at Format.h:1570.

Mar 15 2019, 3:18 PM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2019

reuk accepted D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

LGTM

Mar 12 2019, 3:42 PM · Restricted Project, Restricted Project

Mar 11 2019

reuk added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

The code looks good now. There's just a few places left where the formatting looks a bit suspect (sorry for missing those last time). I think once that's fixed this will be good to go.

Mar 11 2019, 1:42 PM · Restricted Project, Restricted Project
reuk added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

This looks much better now, thanks for taking another look! I've flagged some formatting/spelling nits, and I think the tests/docs could be a little more explicit about the behaviour of WithoutElse. Other than that, looks great!

Mar 11 2019, 2:02 AM · Restricted Project, Restricted Project

Mar 10 2019

reuk added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Does it make sense to allow AllowShortIfElseStatementsOnASingleLine to be enabled when AllowShortIfStatementsOnASingleLine is not?

Mar 10 2019, 5:51 AM · Restricted Project, Restricted Project

Mar 9 2019

reuk added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Thanks for the review, and for approving this PR. It's very much appreciated!

Mar 9 2019, 12:34 PM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2019

reuk updated the diff for D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I've rebased onto master, and removed unrelated formatting changes. I've also tried to remove some of the duplicate parens-related expressions.

Mar 8 2019, 2:48 PM · Restricted Project, Restricted Project, Restricted Project

Dec 10 2018

reuk updated subscribers of D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Would someone review this please? I'm not sure who to add for review (sorry), maybe one of the following?
@klimek @Typz @krasimir

Dec 10 2018, 3:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2018

reuk created D55170: [clang-format]: Add NonEmptyParentheses spacing option.
Dec 1 2018, 3:26 PM · Restricted Project, Restricted Project, Restricted Project