- User Since
- Dec 1 2018, 2:58 PM (59 w, 6 d)
Apr 15 2019
Apr 9 2019
Apr 8 2019
Closed by https://reviews.llvm.org/rG91f60b44958f, https://reviews.llvm.org/rL357908, https://reviews.llvm.org/rC357908 (sorry, I forgot to update the body of the commit message to close this automatically)
Apr 7 2019
Fixed formatting nit.
I updated ClangFormatStyleOptions.rst by hand, is there a way to do that automatically instead (for future patches)?
Updated with fixes. Thanks for pointing out that the options are ordered alphabetically, I hadn't noticed that!
Apr 5 2019
Mar 30 2019
Mar 20 2019
Removed unnecessary parens.
Mar 18 2019
@klimek I agree that the rule is somewhat arbitrary. However, it's the style rule of an established codebase with many users (I don't have a concrete number, but the project has 1400 stars on github). I've found this patch useful when contributing to JUCE and I thought others might too.
Mar 17 2019
@MyDeveloperDay I'm sorry, you're absolutely correct. I'd got some other JUCE-related changes mixed up in this PR. Should be fixed now.
Mar 15 2019
@MyDeveloperDay I'm not sure you built this branch. Perhaps you applied this patch to an older version of the repo. For me, SpaceBeforeCpp11BracedListOptions is defined at Format.h:1570.
Mar 12 2019
Mar 11 2019
The code looks good now. There's just a few places left where the formatting looks a bit suspect (sorry for missing those last time). I think once that's fixed this will be good to go.
This looks much better now, thanks for taking another look! I've flagged some formatting/spelling nits, and I think the tests/docs could be a little more explicit about the behaviour of WithoutElse. Other than that, looks great!
Mar 10 2019
Does it make sense to allow AllowShortIfElseStatementsOnASingleLine to be enabled when AllowShortIfStatementsOnASingleLine is not?
Mar 9 2019
Thanks for the review, and for approving this PR. It's very much appreciated!
Mar 8 2019
I've rebased onto master, and removed unrelated formatting changes. I've also tried to remove some of the duplicate parens-related expressions.