Page MenuHomePhabricator

rcraik (Rachel Craik)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2015, 1:22 PM (247 w, 23 h)

Recent Activity

Wed, Oct 9

rcraik committed rL374209: Request commit access for rcraik.
Request commit access for rcraik
Wed, Oct 9, 1:10 PM

Sep 19 2017

rcraik committed rL313675: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values.
[OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values
Sep 19 2017, 2:08 PM
rcraik closed D38049: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values by committing rL313675: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values.
Sep 19 2017, 2:07 PM
rcraik created D38049: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values.
Sep 19 2017, 12:18 PM

Jul 24 2017

rcraik committed rL308932: Remove addtional parameters in function std::next() and std::prev().
Remove addtional parameters in function std::next() and std::prev()
Jul 24 2017, 3:17 PM
rcraik closed D34649: Remove addtional parameters in function std::next() and std::prev() by committing rL308932: Remove addtional parameters in function std::next() and std::prev().
Jul 24 2017, 3:17 PM

Sep 14 2015

rcraik committed rL247618: C11 _Bool bitfield diagnostic.
C11 _Bool bitfield diagnostic
Sep 14 2015, 2:29 PM
rcraik closed D10018: C11 _Bool bitfield diagnostic.
Sep 14 2015, 2:28 PM
rcraik committed rL247560: Test commit.
Test commit
Sep 14 2015, 7:09 AM

Sep 11 2015

rcraik added a comment to D10018: C11 _Bool bitfield diagnostic.
Sep 11 2015, 1:07 PM
rcraik updated the diff for D10018: C11 _Bool bitfield diagnostic.

switched to using getIntWidth instead of getTypeSize and updated the error and warning messages accordingly, as have the necessary test cases. The separate check for _Bool bitfields has been removed, so the check is now consistent for all types.

Sep 11 2015, 1:05 PM

Sep 10 2015

rcraik added inline comments to D10018: C11 _Bool bitfield diagnostic.
Sep 10 2015, 2:17 PM

Sep 9 2015

rcraik updated the diff for D10018: C11 _Bool bitfield diagnostic.

I've updated the message to make it a bit clearer that this is a portability concern. Are there any further concerns with this patch?

Sep 9 2015, 8:04 AM

Aug 31 2015

rcraik added a comment to D11582: Fix assertion failure in TransformOpaqueValueExpr.

Ping 3!

Aug 31 2015, 6:52 AM

Aug 12 2015

rcraik added a comment to D11582: Fix assertion failure in TransformOpaqueValueExpr.

ping 2!

Aug 12 2015, 7:43 AM

Aug 6 2015

rcraik added a comment to D10018: C11 _Bool bitfield diagnostic.
Aug 6 2015, 3:03 PM

Aug 5 2015

rcraik added a comment to D11582: Fix assertion failure in TransformOpaqueValueExpr.

ping!

Aug 5 2015, 6:45 AM

Jul 28 2015

rcraik retitled D11582: Fix assertion failure in TransformOpaqueValueExpr from to Fix assertion failure in TransformOpaqueValueExpr.
Jul 28 2015, 3:29 PM

Jun 22 2015

rcraik added a comment to D10018: C11 _Bool bitfield diagnostic.

Ping!

Jun 22 2015, 6:03 AM

Jun 11 2015

rcraik updated the diff for D10018: C11 _Bool bitfield diagnostic.

I've updated the patch to produce the warning in C99 as well as C11 modes

Jun 11 2015, 3:00 PM

Jun 1 2015

rcraik added a comment to D10018: C11 _Bool bitfield diagnostic.

Ping!

Jun 1 2015, 1:46 PM

May 25 2015

rcraik retitled D10018: C11 _Bool bitfield diagnostic from to C11 _Bool bitfield diagnostic.
May 25 2015, 2:06 PM

Apr 23 2015

rcraik abandoned D9113: Allow C11 static assert declaration as clause-1 in for loops..
Apr 23 2015, 7:38 AM

Apr 22 2015

rcraik added a comment to D9113: Allow C11 static assert declaration as clause-1 in for loops..

This seems much more likely to be a defect in C11 than a deliberate feature to me. Have you asked WG14 whether this was intentional?

Apr 22 2015, 12:10 PM

Apr 20 2015

rcraik updated D9113: Allow C11 static assert declaration as clause-1 in for loops..
Apr 20 2015, 10:45 AM
rcraik retitled D9113: Allow C11 static assert declaration as clause-1 in for loops. from to Allow C11 static assert declaration as clause-1 in for loops..
Apr 20 2015, 10:44 AM

Mar 20 2015

rcraik added a comment to D8308: Improved error recovery for _Pragma.

Ping

Mar 20 2015, 7:15 AM

Mar 13 2015

rcraik updated the diff for D8308: Improved error recovery for _Pragma.

I've updated the patch to address the first case mentioned by Hubert. The behaviour with this patch will now be the same as the current trunk

Mar 13 2015, 7:29 PM
rcraik added a comment to D8308: Improved error recovery for _Pragma.

In regards to the previous comment, a BalancedDelimiterTracker could (in theory) be used instead to eat all tokens until the closing ')', if it exists. However, _Pragma is handled by the preprocessor, and I believe BalancedDelimiterTracker can only used from within the parser.

Mar 13 2015, 10:57 AM

Mar 12 2015

rcraik retitled D8308: Improved error recovery for _Pragma from to Improved error recovery for _Pragma.
Mar 12 2015, 4:14 PM

Feb 24 2015

rcraik closed D7559: Fix sign of wide character literals in preprocessor conditions.
Feb 24 2015, 6:28 AM

Feb 11 2015

rcraik retitled D7559: Fix sign of wide character literals in preprocessor conditions from to Fix sign of wide character literals in preprocessor conditions.
Feb 11 2015, 7:04 AM