Page MenuHomePhabricator

randreshg (Rafael Herrera)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2022, 9:07 AM (40 w, 6 d)

Recent Activity

Apr 12 2023

randreshg added inline comments to D146642: [OpenMP] Implement task record and replay mechanism.
Apr 12 2023, 7:42 PM · Restricted Project, Restricted Project

Apr 3 2023

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

Test added

Apr 3 2023, 3:18 PM · Restricted Project, Restricted Project
randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Test updated.
This should work 🤞

Apr 3 2023, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Test updated.

Apr 3 2023, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2023

randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Test fixed

Apr 2 2023, 1:01 PM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2023

randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Test with filter clause added

Mar 30 2023, 8:52 PM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2023

randreshg added inline comments to D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Mar 24 2023, 9:01 PM · Restricted Project, Restricted Project, Restricted Project
randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Adding masked support to the device

Mar 24 2023, 8:53 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2023

randreshg added inline comments to D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Mar 23 2023, 4:36 PM · Restricted Project, Restricted Project, Restricted Project
randreshg added inline comments to D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Mar 23 2023, 3:57 PM · Restricted Project, Restricted Project, Restricted Project
randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

Generated functions included in the test

Mar 23 2023, 3:54 PM · Restricted Project, Restricted Project, Restricted Project
randreshg updated the diff for D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.

The parallel masked directive is emitted as a combined directive that consists of two implicit directives: 'parallel' with 'masked' directive.

Mar 23 2023, 12:59 PM · Restricted Project, Restricted Project, Restricted Project

Mar 20 2023

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

Patch updated to the trunk version.
Changes compared to the last patch:

  • the HasDataTransfer flag was added.
  • the functions AsyncInfoTy *get() was added to both AsyncInfoTy and TaskAsyncInfoWrapperTy
Mar 20 2023, 8:34 AM · Restricted Project, Restricted Project

Feb 8 2023

randreshg added inline comments to D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Feb 8 2023, 7:36 PM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2023

randreshg added inline comments to D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Feb 7 2023, 6:29 PM · Restricted Project, Restricted Project, Restricted Project
randreshg requested review of D143527: [OpenMP][5.1] Fix parallel masked is ignored #59939.
Feb 7 2023, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

Jan 7 2023

randreshg updated the diff for D141010: OpenMPOpt: Check nested parallelism in target region.

Invalid state of FnAA is now considered

Jan 7 2023, 11:40 AM · Restricted Project, Restricted Project
randreshg added inline comments to D141010: OpenMPOpt: Check nested parallelism in target region.
Jan 7 2023, 7:49 AM · Restricted Project, Restricted Project
randreshg updated the diff for D141010: OpenMPOpt: Check nested parallelism in target region.

Minor changes

Jan 7 2023, 4:06 AM · Restricted Project, Restricted Project

Jan 6 2023

randreshg updated the diff for D141010: OpenMPOpt: Check nested parallelism in target region.

This new patch addresses comments from reviewers

Jan 6 2023, 7:54 PM · Restricted Project, Restricted Project

Jan 5 2023

randreshg added inline comments to D141010: OpenMPOpt: Check nested parallelism in target region.
Jan 5 2023, 12:06 PM · Restricted Project, Restricted Project
randreshg added inline comments to D141010: OpenMPOpt: Check nested parallelism in target region.
Jan 5 2023, 11:44 AM · Restricted Project, Restricted Project

Jan 4 2023

randreshg requested review of D141010: OpenMPOpt: Check nested parallelism in target region.
Jan 4 2023, 12:02 PM · Restricted Project, Restricted Project

Dec 15 2022

randreshg added a comment to D132306: Automatic asynchronous execution of OpenMP Target Regions.

ping

Dec 15 2022, 4:57 PM · Restricted Project, Restricted Project

Dec 6 2022

randreshg added a comment to D132306: Automatic asynchronous execution of OpenMP Target Regions.

ping

Dec 6 2022, 8:14 AM · Restricted Project, Restricted Project

Nov 21 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

This patch addresses comments from reviewers:

  • Env var name is LIBOMPTARGET_INTRA_THREAD_ASYNC
  • The pattern to get and destroy the AsyncInfoTy object changed.
  • A DenseMap is used instead of the std::map.
Nov 21 2022, 8:00 AM · Restricted Project, Restricted Project

Oct 28 2022

randreshg added inline comments to D132306: Automatic asynchronous execution of OpenMP Target Regions.
Oct 28 2022, 12:28 PM · Restricted Project, Restricted Project

Oct 26 2022

randreshg added a comment to D132306: Automatic asynchronous execution of OpenMP Target Regions.

Ping

Oct 26 2022, 9:12 AM · Restricted Project, Restricted Project

Oct 21 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.
Oct 21 2022, 6:59 AM · Restricted Project, Restricted Project

Oct 20 2022

randreshg added inline comments to D132306: Automatic asynchronous execution of OpenMP Target Regions.
Oct 20 2022, 12:35 PM · Restricted Project, Restricted Project

Oct 19 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

This new patch addresses all previous comments from reviewers

Oct 19 2022, 8:50 AM · Restricted Project, Restricted Project

Oct 18 2022

randreshg added a comment to D132306: Automatic asynchronous execution of OpenMP Target Regions.

ping

Oct 18 2022, 9:19 AM · Restricted Project, Restricted Project

Sep 26 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

This new version has the following changes:

Sep 26 2022, 12:25 PM · Restricted Project, Restricted Project

Sep 19 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

Documentation added

Sep 19 2022, 10:04 AM · Restricted Project, Restricted Project

Sep 13 2022

randreshg updated the diff for D132306: Automatic asynchronous execution of OpenMP Target Regions.

diff updated.

  • The AsyncInfoManager is now part of the omptarget.h and not device.h
  • Global variable AIM was added in interface.cpp
  • Flag was added to the Synchronization in asyncinfo destructor
Sep 13 2022, 6:36 AM · Restricted Project, Restricted Project

Sep 5 2022

randreshg added inline comments to D132306: Automatic asynchronous execution of OpenMP Target Regions.
Sep 5 2022, 7:31 AM · Restricted Project, Restricted Project

Aug 20 2022

randreshg added a comment to D132306: Automatic asynchronous execution of OpenMP Target Regions.

As long as the RTL of the device provides a queue mechanism to execute target tasks sequentially, the dependencies among different tasks will be respected, for NVIDIA GPUs the queue mechanism is the stream. This patch, in contrast with the current OpenMP offloading implementation, launches the execution of tasks into the same stream.

Aug 20 2022, 5:36 PM · Restricted Project, Restricted Project
randreshg updated the summary of D132306: Automatic asynchronous execution of OpenMP Target Regions.
Aug 20 2022, 1:31 PM · Restricted Project, Restricted Project
randreshg requested review of D132306: Automatic asynchronous execution of OpenMP Target Regions.
Aug 20 2022, 9:50 AM · Restricted Project, Restricted Project