Page MenuHomePhabricator

ramana-nvr (Venkat)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2017, 9:52 PM (165 w, 1 d)

Recent Activity

Mon, Oct 12

ramana-nvr updated ramana-nvr.
Mon, Oct 12, 8:53 AM

Oct 3 2018

ramana-nvr added a comment to D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers.

I do not have the commit permission. Could someone help commit this patch?

Oct 3 2018, 9:32 PM

Sep 2 2018

ramana-nvr added a comment to D48704: [ExecutionContext] Return the target/process byte order..

Sorry, I don't have a test case for this and I am yet to understand lldb test suite to create one.

Sep 2 2018, 11:23 PM · Restricted Project, Restricted Project

Aug 7 2018

ramana-nvr updated the diff for D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers.

Yes, updated the patch accordingly.

Aug 7 2018, 8:41 AM

Aug 5 2018

ramana-nvr created D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers.
Aug 5 2018, 3:53 AM

Jul 24 2018

ramana-nvr added a comment to D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet.

Sorry, I am not helpful to you in providing a unit test case for this patch. I am still learning about test suite framework and/or trying to get the lldb test suite up and running.

Jul 24 2018, 4:34 AM

Jul 11 2018

ramana-nvr updated the diff for D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

The error messages now refer to the thread ID instead of the thread index.

Jul 11 2018, 10:38 PM
ramana-nvr updated the diff for D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet.

For now, leaving the m_thread_pcs.clear() in UpdateThreadIDList() unchanged as it is not causing any problems.

Jul 11 2018, 2:05 AM

Jul 10 2018

ramana-nvr added a comment to D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet.

Sorry, I wasn't clear in my previous comment.

Jul 10 2018, 10:17 PM
ramana-nvr added a reviewer for D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet: jasonmolenda.
Jul 10 2018, 6:41 PM
ramana-nvr added a comment to D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet.

If jThreadsInfo isn't implemented, we fall back to looking for the thread-pcs: and threads: key-value pairs in the stop packet that we received.
We look for the threads: list and if it is present, we call UpdateThreadIDsFromStopReplyThreadsValue which clears m_thread_pcs again (bug #2) and then adds any threads listed to the m_thread_ids.

Jul 10 2018, 9:28 AM

Jul 4 2018

ramana-nvr updated the diff for D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.
Jul 4 2018, 1:12 AM
ramana-nvr added a reviewer for D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID: jingham.

check should also use thread->GetID not m_options.m_thread_idx. This is all error reporting, so it's not a big deal. But having the error be "failed to resolve line table for frame 5 of thread 4294967295" would be confusing. Could you change those uses as well?

Jul 4 2018, 1:10 AM

Jul 3 2018

ramana-nvr created D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet.
Jul 3 2018, 2:07 AM
ramana-nvr created D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.
Jul 3 2018, 12:07 AM

Jun 27 2018

ramana-nvr updated the diff for D48704: [ExecutionContext] Return the target/process byte order..

Created the patch with more context.

Jun 27 2018, 10:05 PM · Restricted Project, Restricted Project
ramana-nvr created D48704: [ExecutionContext] Return the target/process byte order..
Jun 27 2018, 9:56 PM · Restricted Project, Restricted Project