User Details
- User Since
- Dec 20 2018, 4:47 PM (178 w, 3 d)
Thu, May 5
Mar 29 2022
looks good to me! you may want someone else to also approve this since I am not a regular LLVM contributor.
Mar 28 2022
Mar 22 2022
Mar 21 2022
Feb 23 2022
Feb 22 2022
As far as I can tell, this code seems to assume it's running on a little-endian system. I think it needs to correctly handle what happens when bigints are stored in the other endian (where the first word is the most-significant).
Dec 7 2020
As far as I can tell, this implemention incorrectly returns overflow for 32-bit time_t for 00:00:08 UTC Jan 1 2038 since you forgot to check that the month, day, hour, and minute are equal to the 32-bit overflow time before checking that the seconds overflow. likewise for day, hour and minute.
Feb 4 2020
From what I recall, the plan is to implement this by using fixed-size vector types combined with VL-based ops. MVL would be the size of those vector types.
Feb 2 2020
Oct 9 2019
Oct 1 2019
The __GNUG__ macro is defined to be 4 rather than matching __GNUC__
Sep 30 2019
Shouldn't __GNUG__ match __GNUC__?
Feb 13 2019
Feb 1 2019
We will also need to adjust gather/scatter and possibly other load/store kinds to allow the address vector length to be a divisor of the main vector length (similar to mask vector length). I didn't check if there are intrinsics for strided load/store, those will need to be changed too, to allow, for example, storing <scalable 3 x float> to var.v in: