Page MenuHomePhabricator

prakhar (Prakhar Bahuguna)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 1:31 AM (164 w, 4 d)

Recent Activity

Aug 29 2017

prakhar added inline comments to D37052: Add default address space for functions to the data layout (1/3).
Aug 29 2017, 1:29 AM · Restricted Project

Feb 21 2017

prakhar abandoned D27986: Print numeric section flag for OS/processor specific bits.

Abandoning as this is now being handled in https://reviews.llvm.org/D30169

Feb 21 2017, 12:32 AM

Jan 26 2017

prakhar added a comment to D27986: Print numeric section flag for OS/processor specific bits.

Yes, since no other OS/processor specific flag has a text equivalent, it might be better to not emit one for purecode at all. This is independent of the fact that these flags are being lost in the assembler output as LLVM currently does not emit them in numeric form.

Jan 26 2017, 1:43 AM
prakhar updated the diff for D27986: Print numeric section flag for OS/processor specific bits.

Style and formatting fix

Jan 26 2017, 1:39 AM

Jan 17 2017

prakhar added a comment to D27986: Print numeric section flag for OS/processor specific bits.

@rengolin Ping again for this review

Jan 17 2017, 8:02 AM

Jan 11 2017

prakhar added a comment to D27986: Print numeric section flag for OS/processor specific bits.

Ping for this review

Jan 11 2017, 5:56 AM

Jan 5 2017

prakhar added a comment to D27986: Print numeric section flag for OS/processor specific bits.

None of the other target-specific flags have textual representations though, and the y symbol for ARM pure code was a proposal that was ultimately rejected. Hence, if these flags are present in the code, their information will be lost in the assembler output as they do not have a textual representation. It is therefore safer to default to a numeric representation that is already understood by both toolchains if these flags are present.

Jan 5 2017, 3:35 AM

Dec 20 2016

prakhar set the repository for D27986: Print numeric section flag for OS/processor specific bits to rL LLVM.
Dec 20 2016, 6:13 AM
prakhar retitled D27986: Print numeric section flag for OS/processor specific bits from to Print numeric section flag for OS/processor specific bits.
Dec 20 2016, 6:11 AM

Dec 19 2016

prakhar committed rL290110: [ARM] Add missing -backend-option for -arm-execute-only.
[ARM] Add missing -backend-option for -arm-execute-only
Dec 19 2016, 7:54 AM

Dec 15 2016

prakhar committed rL289798: Add missing triple target for numeric section flag test.
Add missing triple target for numeric section flag test
Dec 15 2016, 2:31 AM
prakhar closed D27449: [ARM] Implement execute-only support in CodeGen.

Closed by commit rL289784

Dec 15 2016, 12:57 AM
prakhar committed rL289788: Fix for build warning in execute-only support.
Fix for build warning in execute-only support
Dec 15 2016, 12:52 AM
prakhar committed rL289786: [ARM] Implement execute-only support in CodeGen.
[ARM] Implement execute-only support in CodeGen
Dec 15 2016, 12:10 AM
prakhar committed rL289785: Allow ELF section flags to be specified numerically.
Allow ELF section flags to be specified numerically
Dec 15 2016, 12:09 AM
prakhar closed D27450: [ARM] Implement execute-only support in CodeGen by committing rL289786: [ARM] Implement execute-only support in CodeGen.
Dec 15 2016, 12:09 AM
prakhar committed rL289784: [ARM] Implement execute-only support in CodeGen.
[ARM] Implement execute-only support in CodeGen
Dec 15 2016, 12:09 AM
prakhar closed D27451: Allow ELF section flags to be specified numerically by committing rL289785: Allow ELF section flags to be specified numerically.
Dec 15 2016, 12:09 AM

Dec 14 2016

prakhar updated the diff for D27450: [ARM] Implement execute-only support in CodeGen.

Message about why long calls are not supported in execute-only

Dec 14 2016, 9:17 AM
prakhar updated the diff for D27450: [ARM] Implement execute-only support in CodeGen.

Make execute-only a codegen option instead of a subtarget feature

Dec 14 2016, 9:10 AM
prakhar updated the diff for D27449: [ARM] Implement execute-only support in CodeGen.

Make execute-only a codegen option instead of a subtarget feature

Dec 14 2016, 9:10 AM

Dec 13 2016

prakhar updated the diff for D27450: [ARM] Implement execute-only support in CodeGen.

Fixes for test and commit message

Dec 13 2016, 6:05 AM
prakhar updated the diff for D27449: [ARM] Implement execute-only support in CodeGen.

Fixed mistake with assert

Dec 13 2016, 5:31 AM
prakhar updated D27449: [ARM] Implement execute-only support in CodeGen.
Dec 13 2016, 5:26 AM
prakhar updated D27450: [ARM] Implement execute-only support in CodeGen.
Dec 13 2016, 5:25 AM
prakhar updated D27449: [ARM] Implement execute-only support in CodeGen.
Dec 13 2016, 5:25 AM
prakhar updated the diff for D27450: [ARM] Implement execute-only support in CodeGen.

Allow ARMv6T2, and provide diagnostics if combined with -mno-movt or -mlong-calls

Dec 13 2016, 5:19 AM
prakhar updated the diff for D27449: [ARM] Implement execute-only support in CodeGen.

Changed execute-only/no-movt error back to an assert

Dec 13 2016, 5:17 AM
prakhar added inline comments to D27450: [ARM] Implement execute-only support in CodeGen.
Dec 13 2016, 4:02 AM
prakhar added inline comments to D27449: [ARM] Implement execute-only support in CodeGen.
Dec 13 2016, 3:03 AM

Dec 8 2016

prakhar updated the diff for D27449: [ARM] Implement execute-only support in CodeGen.

Additional tests, error reporting, and explanatory comments

Dec 8 2016, 5:36 AM
prakhar added a comment to D27449: [ARM] Implement execute-only support in CodeGen.

Actually, MOVT was introduced in ARMv6T2, but execute-only seems to be an M thing, mostly ARMv7M and ARMv8M. Maybe advertise it that way instead of MOVT-dependent.

Dec 8 2016, 4:17 AM

Dec 6 2016

prakhar retitled D27451: Allow ELF section flags to be specified numerically from to Allow ELF section flags to be specified numerically.
Dec 6 2016, 3:19 AM
prakhar retitled D27450: [ARM] Implement execute-only support in CodeGen from to [ARM] Implement execute-only support in CodeGen.
Dec 6 2016, 2:59 AM
prakhar retitled D27449: [ARM] Implement execute-only support in CodeGen from to [ARM] Implement execute-only support in CodeGen.
Dec 6 2016, 2:59 AM

Aug 16 2016

prakhar committed rL278788: [Thumb] Validate branch target for CBZ/CBNZ instructions..
[Thumb] Validate branch target for CBZ/CBNZ instructions.
Aug 16 2016, 3:50 AM
prakhar committed rL278789: Correct the upper bound for a CBZ/CBNZ branch target..
Correct the upper bound for a CBZ/CBNZ branch target.
Aug 16 2016, 3:50 AM
prakhar closed D23501: Correct the upper bound for a CBZ/CBNZ branch target. by committing rL278789: Correct the upper bound for a CBZ/CBNZ branch target..
Aug 16 2016, 3:49 AM
prakhar updated the diff for D23501: Correct the upper bound for a CBZ/CBNZ branch target..

CHECK-NOT added

Aug 16 2016, 12:14 AM

Aug 15 2016

prakhar updated the diff for D23501: Correct the upper bound for a CBZ/CBNZ branch target..

Clarify the upper bound tests

Aug 15 2016, 8:05 AM
prakhar added inline comments to D23501: Correct the upper bound for a CBZ/CBNZ branch target..
Aug 15 2016, 8:02 AM
prakhar updated the diff for D23501: Correct the upper bound for a CBZ/CBNZ branch target..

Use the offset bounds before 4-byte correction

Aug 15 2016, 7:30 AM
prakhar added inline comments to D23501: Correct the upper bound for a CBZ/CBNZ branch target..
Aug 15 2016, 7:26 AM
prakhar retitled D23501: Correct the upper bound for a CBZ/CBNZ branch target. from to Correct the upper bound for a CBZ/CBNZ branch target..
Aug 15 2016, 4:44 AM
prakhar committed rL278659: [Thumb] Validate branch target for CBZ/CBNZ instructions..
[Thumb] Validate branch target for CBZ/CBNZ instructions.
Aug 15 2016, 1:05 AM
prakhar closed D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions. by committing rL278659: [Thumb] Validate branch target for CBZ/CBNZ instructions..
Aug 15 2016, 1:05 AM

Aug 10 2016

prakhar added a comment to D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions..
Aug 10 2016, 3:51 AM
prakhar updated the diff for D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions..

Immediate operand is 6 bits and should have cleared LSB.

Aug 10 2016, 3:05 AM

Aug 9 2016

prakhar added a comment to D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions..
Aug 9 2016, 6:54 AM
prakhar updated the diff for D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions..

Use isUnsignedOffset() directly and add upper bound checking with tests.

Aug 9 2016, 6:52 AM
prakhar set the repository for D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions. to rL LLVM.
Aug 9 2016, 5:37 AM
prakhar retitled D23312: [Thumb] Validate branch target for CBZ/CBNZ instructions. from to [Thumb] Validate branch target for CBZ/CBNZ instructions..
Aug 9 2016, 5:27 AM

Jul 29 2016

prakhar committed rL277128: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates.
[Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates
Jul 29 2016, 2:24 AM
prakhar closed D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates by committing rL277128: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates.
Jul 29 2016, 2:24 AM

Jul 28 2016

prakhar updated the diff for D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates.

Clean up other uses of IsThumb1 and IsThumb2

Jul 28 2016, 7:41 AM
prakhar added a comment to D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates.

I'll clean up the other uses of IsThumb1/IsThumb2 while I'm at it.

Jul 28 2016, 7:40 AM

Jul 27 2016

prakhar added reviewers for D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates: t.p.northover, rengolin.
Jul 27 2016, 7:25 AM
prakhar retitled D22865: [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates from to [Thumb] Emit Thumb move in both Thumb modes for struct_byval predicates.
Jul 27 2016, 7:10 AM