Abandoning as this is now being handled in https://reviews.llvm.org/D30169

Yes, since no other OS/processor specific flag has a text equivalent, it might be better to not emit one for purecode at all. This is independent of the fact that these flags are being lost in the assembler output as LLVM currently does not emit them in numeric form.

Style and formatting fix

@rengolin Ping again for this review

Ping for this review

None of the other target-specific flags have textual representations though, and the y symbol for ARM pure code was a proposal that was ultimately rejected. Hence, if these flags are present in the code, their information will be lost in the assembler output as they do not have a textual representation. It is therefore safer to default to a numeric representation that is already understood by both toolchains if these flags are present.

Closed by commit rL289784

Message about why long calls are not supported in execute-only

Make execute-only a codegen option instead of a subtarget feature

Make execute-only a codegen option instead of a subtarget feature

Fixes for test and commit message

Fixed mistake with assert

Allow ARMv6T2, and provide diagnostics if combined with -mno-movt or -mlong-calls

Changed execute-only/no-movt error back to an assert

Additional tests, error reporting, and explanatory comments

Actually, MOVT was introduced in ARMv6T2, but execute-only seems to be an M thing, mostly ARMv7M and ARMv8M. Maybe advertise it that way instead of MOVT-dependent.

CHECK-NOT added

Clarify the upper bound tests

Use the offset bounds before 4-byte correction

Immediate operand is 6 bits and should have cleared LSB.

Use isUnsignedOffset() directly and add upper bound checking with tests.

Clean up other uses of IsThumb1 and IsThumb2

I'll clean up the other uses of IsThumb1/IsThumb2 while I'm at it.