Page MenuHomePhabricator

pjeeva01 (Jeeva P.)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2018, 7:55 AM (47 w, 8 h)

Recent Activity

Aug 29 2019

pjeeva01 added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.
  1. *_massv functions serve as place holder for math functions during loop vectorization. They are not actual entries in the MASS library. I think lowering them to actual entries in the MASS library deserves a separate pass rather than polluting the TargetLowering.cpp, which is already big as it is.

Why this has to be in TargetLowering.cpp, they can be in PPCISelLowering.cpp.

  1. If we were to use setLibcallName, we would need to repeat the list of all supported MASS entries in TargetLowering as well. With the current structure, we are reusing the list in VecFuncs.def. Also, this structure sits well with vectorization of math functions with other libraries too, namely: SVML and Accelerate.

Why we can't reusing the list in VecFuncs.def with setLibcallName?

Aug 29 2019, 6:52 AM · Restricted Project

Aug 28 2019

pjeeva01 added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

A separate pass for MASSV lowering is worthwhile because it allows better separation of concerns.
In the future, if need be, other PPC sub-target specific lowering decisions for MASSV may be encapsulated in this pass too.

What is the benefits other than allows better separation of concerns?
I don't see this compelling reason to be a pass, especially considering the unnecessary compile time it will cost.

Aug 28 2019, 11:03 AM · Restricted Project
pjeeva01 updated the diff for D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

Addressed review comments in this diff:

  1. use -mattr instead of relying attributes on the caller; separate the tests to a separate .ll file
  2. add -verify-machineinstrs to the run line
  3. combine multiple check-prefix into one check-prefixes
  4. remove datalayout and triple from the .ll file
Aug 28 2019, 8:59 AM · Restricted Project
pjeeva01 added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

Why we need a new pass to do this simple lowering?
Why can't we do it similar to InitLibcalls and change the suffixes for subtarget using setLibcallName?

Aug 28 2019, 8:03 AM · Restricted Project

Jul 22 2019

pjeeva01 updated the diff for D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

Re-basing this patch off of the patch in https://reviews.llvm.org/D59881

Jul 22 2019, 12:19 PM · Restricted Project
pjeeva01 added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

ping @nemanjai @jsji

Jul 22 2019, 12:19 PM · Restricted Project

Jun 5 2019

pjeeva01 added a comment to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

The LLVM portion of this patch committed in https://reviews.llvm.org/rL362568.

Jun 5 2019, 6:09 AM · Restricted Project

May 16 2019

pjeeva01 updated the diff for D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

This patch includes following updates:

  1. sqrt (f32 and f64) intrinsics are lowered to their vector counterparts; lowering them to massv entries is beyond the scope of this patch. Relevant tests are added to massv-unsupported.ll
  2. The test files includes relevant comments to portray their intent.
May 16 2019, 7:12 AM · Restricted Project

May 7 2019

pjeeva01 updated the diff for D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

Thank you for your comments @jsji
This patch includes following updates:

  • negative tests for math functions lacking vector counterparts, for altivec targets, and for nobuiltin attributes.
May 7 2019, 8:24 AM · Restricted Project

Apr 8 2019

pjeeva01 updated the diff for D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

Updated the patch assuming a base that has D60211 incorporated.

Apr 8 2019, 12:40 PM · Restricted Project

Apr 5 2019

pjeeva01 added a comment to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

ping

Apr 5 2019, 12:24 PM · Restricted Project

Apr 4 2019

pjeeva01 updated the diff for D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.

This updated patch uses a single macro to define the mapping from scalar maths functions to their vector counterparts ( as suggested in the earlier review of the original patch).

Apr 4 2019, 8:27 AM · Restricted Project

Apr 3 2019

pjeeva01 added inline comments to D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.
Apr 3 2019, 12:38 PM · Restricted Project
pjeeva01 added reviewers for D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts: nemanjai, hfinkel.
Apr 3 2019, 11:53 AM · Restricted Project
pjeeva01 added inline comments to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Apr 3 2019, 9:27 AM · Restricted Project
pjeeva01 created D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.
Apr 3 2019, 9:24 AM · Restricted Project

Mar 29 2019

pjeeva01 added inline comments to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Mar 29 2019, 6:32 AM · Restricted Project

Mar 27 2019

pjeeva01 created D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.
Mar 27 2019, 8:09 AM · Restricted Project
pjeeva01 created D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Mar 27 2019, 8:06 AM · Restricted Project

Nov 19 2018

pjeeva01 created D54708: [OPENMP] NFC: Refactor code for parsing omp declare target directive and its clauses.
Nov 19 2018, 9:15 AM · Restricted Project, Restricted Project