Page MenuHomePhabricator
People phisiart

phisiart (Zhixun Tan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2022, 3:56 PM (10 w, 2 d)

Recent Activity
View All

Thu, Aug 11

phisiart added a reviewer for D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize().: Mogball.
Thu, Aug 11, 7:37 PM · Restricted Project, Restricted Project
phisiart retitled D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize(). from Remove the unused AnalysisState::defaultInitialize(). to [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize()..
Thu, Aug 11, 7:36 PM · Restricted Project, Restricted Project
phisiart requested review of D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize()..
Thu, Aug 11, 7:35 PM · Restricted Project, Restricted Project
phisiart added a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: Mogball.
Thu, Aug 11, 5:11 PM · Restricted Project, Restricted Project
phisiart added a comment to D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.
In D131660#3716480, @aartbik wrote:

I am added as reviewer due to the trigger word "sparse" ;-), but this changes looks acceptable (perhap make it a bit more clear that is does change semantics beyond just removing the function in the title)

Thu, Aug 11, 4:55 PM · Restricted Project, Restricted Project
phisiart retitled D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API from Remove isAtFixpoint(). to [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.
Thu, Aug 11, 4:53 PM · Restricted Project, Restricted Project
phisiart updated the diff for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.

Also remove isAtFixpoint() from dense analysis.

Thu, Aug 11, 4:31 PM · Restricted Project, Restricted Project
phisiart removed a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: aartbik.
Thu, Aug 11, 2:16 AM · Restricted Project, Restricted Project
phisiart removed a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: aartbik.
Thu, Aug 11, 2:16 AM · Restricted Project, Restricted Project
phisiart requested review of D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.
Thu, Aug 11, 1:58 AM · Restricted Project, Restricted Project
phisiart added a comment to D128868: [mlir][dataflow] (WIP) Overhaul analysis state management to support composability.

I think update() is better than manually calling propagateIfChanged() because it reduces the chance of misuse without requiring more code.

Thu, Aug 11, 1:25 AM · Restricted Project, Restricted Project

Jun 24 2022

phisiart accepted D127173: [mlir] An implementation of dense data-flow analysis.
Jun 24 2022, 1:59 AM · Restricted Project, Restricted Project
phisiart added inline comments to D127139: [mlir] An implementation of sparse data-flow analysis.
Jun 24 2022, 1:09 AM · Restricted Project, Restricted Project
phisiart accepted D127139: [mlir] An implementation of sparse data-flow analysis.
Jun 24 2022, 12:47 AM · Restricted Project, Restricted Project

Jun 23 2022

phisiart accepted D127064: [mlir] Add Dead Code Analysis.
Jun 23 2022, 10:24 PM · Restricted Project, Restricted Project

Jun 13 2022

phisiart accepted D126751: [mlir] Add a generic data-flow analysis framework.
Jun 13 2022, 3:03 PM · Restricted Project, Restricted Project

Jun 9 2022

phisiart added inline comments to D126751: [mlir] Add a generic data-flow analysis framework.
Jun 9 2022, 12:58 AM · Restricted Project, Restricted Project

Jun 7 2022

phisiart added a comment to D126751: [mlir] Add a generic data-flow analysis framework.

Sorry for the delay, I'll leave some more comments tomorrow.

Jun 7 2022, 9:58 PM · Restricted Project, Restricted Project

Jun 2 2022

phisiart requested changes to D126751: [mlir] Add a generic data-flow analysis framework.
Jun 2 2022, 4:52 PM · Restricted Project, Restricted Project