Page MenuHomePhabricator

philipginsbach (Philip Ginsbach)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2017, 7:59 AM (161 w, 5 d)

Recent Activity

Nov 7 2018

philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Nov 7 2018, 9:19 AM

Oct 21 2018

philipginsbach added a comment to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

Now, I just wanted to point out that there are more opportunities to generalize the rematerialization. The obvious one to me is rematerializing everything (like pulling chain of computations, full instructions (with both definitions and arguments)) and in that sense, only the instruction or chain of instructions carry the right level of information. Right now we often introduce pseudo instruction to work around this limitation and that's what I would like to solve.

Oct 21 2018, 4:36 PM

Oct 18 2018

philipginsbach added a comment to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

I am not sure the enum approach is desirable as it basically hard code the kind of constraints we can report and will grow very quickly if we want to extend it.
For instance, let say that on top of physreg defs we want to report virtual reg defs, now we would need “yes”, “no”, “yes_phys”, “yes_virt”, “yes_phys_virt” and the list grows with the cross product of everything we may want/need to report.

Oct 18 2018, 2:21 AM

Oct 17 2018

philipginsbach added a comment to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

I think I have addressed all your previous concerns, @qcolombet, is there anything else you'd like to see clarified?
Sam Parker suggested I add you as a reviewer, @MatzeB, do you have any suggestions?

Oct 17 2018, 3:30 AM

Oct 12 2018

philipginsbach added a reviewer for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts: aadg.
Oct 12 2018, 6:02 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Oct 12 2018, 6:00 AM
philipginsbach added inline comments to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Oct 12 2018, 5:58 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

Uses range based loop now.

Oct 12 2018, 5:58 AM

Oct 9 2018

philipginsbach edited reviewers for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts, added: MatzeB; removed: javed.absar.
Oct 9 2018, 10:10 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

I have rebased onto the master branch at 244c796c894f50fb53f9dbe7627702661dfe69c2.

Oct 9 2018, 10:06 AM
philipginsbach updated the diff for D35481: Fix documentation of MachineInstr::getNumOperands.

Rebased to current llvm master branch. Quentin, I have worked in your suggestion.

Oct 9 2018, 6:08 AM

Jul 19 2017

philipginsbach added reviewers for D35481: Fix documentation of MachineInstr::getNumOperands: samparker, stoklund.
Jul 19 2017, 2:28 AM

Jul 17 2017

philipginsbach created D35481: Fix documentation of MachineInstr::getNumOperands.
Jul 17 2017, 5:40 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 17 2017, 5:31 AM
philipginsbach added a comment to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

Hi Quentin,

Jul 17 2017, 5:30 AM
philipginsbach added a comment to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

Hi Quentin,

Jul 17 2017, 1:49 AM

Jul 14 2017

philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 14 2017, 3:27 AM
philipginsbach added inline comments to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 14 2017, 3:14 AM
philipginsbach added inline comments to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 14 2017, 3:06 AM
philipginsbach added inline comments to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 14 2017, 3:01 AM

Jul 13 2017

philipginsbach added a comment to D33936: Allow rematerialization of ARM Thumb literal pool loads.

Thanks a lot Sam!

Jul 13 2017, 7:49 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 13 2017, 7:43 AM
philipginsbach added inline comments to D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 7:41 AM
philipginsbach updated the diff for D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 7:40 AM
philipginsbach added inline comments to D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 7:21 AM
philipginsbach updated the diff for D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 7:19 AM
philipginsbach added inline comments to D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 7:05 AM
philipginsbach added inline comments to D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 5:44 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 13 2017, 4:18 AM
philipginsbach added a comment to D33936: Allow rematerialization of ARM Thumb literal pool loads.

Hi Sam,

Jul 13 2017, 4:10 AM
philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 13 2017, 4:06 AM
philipginsbach updated the diff for D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 13 2017, 3:40 AM

Jul 10 2017

philipginsbach updated the diff for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jul 10 2017, 2:55 AM
philipginsbach updated the diff for D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jul 10 2017, 2:55 AM

Jun 21 2017

philipginsbach added a reviewer for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts: samparker.
Jun 21 2017, 5:09 AM
philipginsbach added a reviewer for D33936: Allow rematerialization of ARM Thumb literal pool loads: samparker.
Jun 21 2017, 5:09 AM

Jun 8 2017

philipginsbach added reviewers for D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts: jmolloy, wmi.
Jun 8 2017, 2:11 AM
philipginsbach added reviewers for D33936: Allow rematerialization of ARM Thumb literal pool loads: t.p.northover, jmolloy.
Jun 8 2017, 2:09 AM

Jun 6 2017

philipginsbach created D33936: Allow rematerialization of ARM Thumb literal pool loads.
Jun 6 2017, 5:17 AM
philipginsbach created D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.
Jun 6 2017, 5:13 AM