- User Since
- Jun 12 2016, 7:26 AM (182 w, 19 h)
Tue, Nov 26
Fri, Nov 22
Wed, Nov 20
Updated the patch as per review comments.
Thanks for highlighting the nit. Corrected it.
Tue, Nov 19
Sun, Nov 17
Btw., do you have commit access?
Updated the function comments.
Thanks @jdoerfert for the helpful corrections. I have removed the files. (I should have removed them in the last patch.)
I will start working on the next part.
Fri, Nov 15
@jdoerfert Thank you suggesting the corrections.
Updating the corrected patch.
Thu, Nov 14
Oct 3 2016
Thanks for splitting the code. LGTM.
Oct 2 2016
Thanks for asking.
The first part of changes i.e. 'Fuse CMN, CMP, TST followed by Bcc', is applicable for Vulcan as well.
But, the second part i.e. 'Fuse ALU operations followed by CBZ/CBNZ' is not applicable for Vulcan, i.e. we don't fuse these. Is it possible to make this only Apple specific ?
Jul 19 2016
Removed the CacheLineSize (set to 64) for Vulcan, as three other parameters are required for LoopDataPrefetch to be effective.
Will include CacheLineSize & 3 other parameters in another patch, after they are finalized.
Jul 17 2016
Jul 8 2016
Removed fusion of additional instructions for Vulcan.
Default instructions supported by 'Macrofusion subtarget feature' will be fused.
The approach of adding a new sub-feature for Macro-op fusion, by categorizing the instructions (my presumption) doesn't seem a good option. It will end up adding too many subfeature such as FeatureMacroOpFusionArith/FeatureMacroOpFusionLogical. Please correct me.
Jul 7 2016
Jul 6 2016
Jun 29 2016
Corrected & updated the diff.
But the code looks good to me with the extra comment removed.
Removed the extra comments (comments in 3.11 & 3.12 FP Load/store).
Modified comments part of 3.6 & 3.7 (Load/Store) to say that they are valid for 3.11 & 3.12 (FP Load/Store) as well.
Out of curiosity, what are the performance improvements with this model?
Actually, this is a functional patch and we are currently validating it on the simulators. So, we will update performance numbers later.
While submitting, I had added 'llvm-commits' as subscriber, as per the guidelines. (>> pgode added subscribers: echristo, aemerson, MatzeB, llvm-commits.)
Additionally, I also got a mail from the list llvm-commits: 'Your message entitled [PATCH] D21728: [AARCH64] Add Broadcom Vulcan scheduling modelwas successfully received by the llvm-commits mailing list.'
I can resend the patch, if it is required. Kindly suggest.
Jun 25 2016
Jun 23 2016