Page MenuHomePhabricator

pfaffe (Philip Pfaffe)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 21 2020, 1:53 AM (19 w, 4 d)

Recent Activity

Feb 15 2021

pfaffe added a comment to D96520: Reduce time spent parsing support files.

Looks good to me as well, but please also get some feedback from Pavel.

Feb 15 2021, 5:39 AM · Restricted Project
pfaffe added a reviewer for D96520: Reduce time spent parsing support files: labath.
Feb 15 2021, 5:38 AM · Restricted Project

Feb 5 2021

pfaffe accepted D94347: [WebAssembly] locals can now be indirect in DWARF.
Feb 5 2021, 12:26 AM · Restricted Project

Feb 2 2021

pfaffe added inline comments to D94347: [WebAssembly] locals can now be indirect in DWARF.
Feb 2 2021, 9:05 AM · Restricted Project

Jan 25 2021

pfaffe committed rGda489946a9d8: [llvm-dwp] Automatically set the target triple (authored by pfaffe).
[llvm-dwp] Automatically set the target triple
Jan 25 2021, 3:00 AM
pfaffe closed D93749: [llvm-dwp] Add a command line option to set the target triple.
Jan 25 2021, 2:59 AM · Restricted Project

Jan 22 2021

pfaffe abandoned D95226: Rebase and improve testcase: The file can just be empty..
Jan 22 2021, 5:35 AM · Restricted Project
pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Restore changes lost in previous patchset.

Jan 22 2021, 5:34 AM · Restricted Project
pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Rebase and improve testcase: The file can just be empty.

Jan 22 2021, 5:33 AM · Restricted Project
pfaffe requested review of D95226: Rebase and improve testcase: The file can just be empty..
Jan 22 2021, 5:32 AM · Restricted Project

Jan 15 2021

pfaffe added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

OP_deref would work if the structs are small enough. Leaving out OP_stack_value should just work. It's a terminator of sorts for values that aren't in memory, like registers on native or locals or globals in wasm land.

Jan 15 2021, 12:13 PM · Restricted Project
pfaffe added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

DW_OP_deref loads 32bit (64bit if the address size is 8), is that what's intended here? The struct passed by value could be bigger than that, couldn't it?

Jan 15 2021, 12:55 AM · Restricted Project

Jan 14 2021

pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Replace binary test with an assembly test.

Jan 14 2021, 2:08 AM · Restricted Project

Jan 13 2021

pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Read triple from first dwo file instead of from command line and add a test.

Jan 13 2021, 7:22 AM · Restricted Project

Jan 12 2021

pfaffe added a comment to D93621: [lldb][wasm] Parse DWO section names.

Thanks! Would you mind landing the change for me? I'm not a github comitter.

Jan 12 2021, 8:07 AM · Restricted Project

Dec 23 2020

pfaffe added a reviewer for D93749: [llvm-dwp] Add a command line option to set the target triple: dblaikie.
Dec 23 2020, 12:46 AM · Restricted Project
pfaffe requested review of D93749: [llvm-dwp] Add a command line option to set the target triple.
Dec 23 2020, 12:45 AM · Restricted Project

Dec 22 2020

pfaffe added a reviewer for D93621: [lldb][wasm] Parse DWO section names: labath.
Dec 22 2020, 6:38 AM · Restricted Project
pfaffe updated the diff for D93621: [lldb][wasm] Parse DWO section names.

Add the new dwo sections to the testcase.

Dec 22 2020, 6:37 AM · Restricted Project

Dec 21 2020

pfaffe requested review of D93621: [lldb][wasm] Parse DWO section names.
Dec 21 2020, 2:06 AM · Restricted Project