Page MenuHomePhabricator

pfaffe (Philip Pfaffe)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 21 2020, 1:53 AM (101 w, 23 h)

Recent Activity

Tue, Nov 22

pfaffe committed rGc08d3b08f6d7: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions (authored by pfaffe).
[lldb] Allow plugins to extend DWARF expression parsing for vendor extensions
Tue, Nov 22, 6:39 AM · Restricted Project
pfaffe closed D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.
Tue, Nov 22, 6:38 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

Override new functions in DWOs.

Tue, Nov 22, 1:21 AM · Restricted Project, Restricted Project

Thu, Nov 17

pfaffe added a comment to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

I threaded dwarf_cu down to where it's really used and added the necessary check, so if it is nullptr, the fallback will be skipped.

Thu, Nov 17, 3:49 AM · Restricted Project, Restricted Project

Tue, Nov 15

pfaffe updated the diff for D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

Stray change.

Tue, Nov 15, 2:48 AM · Restricted Project, Restricted Project

Thu, Nov 3

pfaffe added inline comments to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.
Thu, Nov 3, 1:01 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

Address comments.

Thu, Nov 3, 12:59 AM · Restricted Project, Restricted Project

Wed, Nov 2

pfaffe added a comment to D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.

Yes, you got the context right! Although technically speaking this change isn't limited to wasm, plugins can implement any vendor extension on top of this change.

Wed, Nov 2, 9:30 AM · Restricted Project, Restricted Project
pfaffe requested review of D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions.
Wed, Nov 2, 5:41 AM · Restricted Project, Restricted Project
pfaffe committed rGd839f654586a: [wasm] Always treat DWARF expression addresses as load addresses (authored by pfaffe).
[wasm] Always treat DWARF expression addresses as load addresses
Wed, Nov 2, 5:15 AM · Restricted Project
pfaffe closed D135664: [wasm] Always treat DWARF expression addresses as load addresses.
Wed, Nov 2, 5:15 AM · Restricted Project, Restricted Project

Oct 28 2022

pfaffe updated the diff for D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Add unittest for DW_OP_addrx as well.

Oct 28 2022, 7:09 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Bring back lost changes...

Oct 28 2022, 4:03 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Add comments.

Oct 28 2022, 4:02 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Full context with arcanist

Oct 28 2022, 3:59 AM · Restricted Project, Restricted Project

Oct 17 2022

pfaffe added a comment to D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Sorry for the missing context, I forgot that's manual!

Oct 17 2022, 4:10 AM · Restricted Project, Restricted Project
pfaffe updated the diff for D135664: [wasm] Always treat DWARF expression addresses as load addresses.

Managed to add a unit test for the DW_OP_addr path!

Oct 17 2022, 1:49 AM · Restricted Project, Restricted Project

Oct 14 2022

pfaffe added a comment to D135664: [wasm] Always treat DWARF expression addresses as load addresses.

I'm having some trouble coming up with a good test for this in the absence of a real wasm target. any suggestions appreciated!

Oct 14 2022, 3:52 AM · Restricted Project, Restricted Project

Oct 11 2022

pfaffe requested review of D135664: [wasm] Always treat DWARF expression addresses as load addresses.
Oct 11 2022, 6:28 AM · Restricted Project, Restricted Project

Sep 1 2021

pfaffe added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

Not fixable? Not sure I follow. In the case of cwd-relative (old behavior) you can fix the behavior by changing where you invoke the debugger from, and in the case of exe-relative you can fix the behavior by moving the executable? (once both source and dwo lookup is implemented consistently, at least)

Sep 1 2021, 4:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2021

pfaffe added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

This doesn't solve all use cases/it's not a terribly general purpose situation - using -fdebug-prefix-map/-fdebug-compilation-dir requires knowledge of these limitations/how to use these features together. (though I agree that changes in this area should apply to all relative comp_dir lookups - source and dwo files alike, rather than handling one group differently from the other when they're all defined as comp_dir relative)

Aug 31 2021, 1:47 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2021

pfaffe added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

This change breaks all existing uses of relative comp_dirs that don't accidentally make all of them relative to the executable's directory already.

Aug 30 2021, 6:04 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2021

pfaffe added a comment to D96520: Reduce time spent parsing support files.

Looks good to me as well, but please also get some feedback from Pavel.

Feb 15 2021, 5:39 AM · Restricted Project
pfaffe added a reviewer for D96520: Reduce time spent parsing support files: labath.
Feb 15 2021, 5:38 AM · Restricted Project

Feb 5 2021

pfaffe accepted D94347: [WebAssembly] locals can now be indirect in DWARF.
Feb 5 2021, 12:26 AM · Restricted Project

Feb 2 2021

pfaffe added inline comments to D94347: [WebAssembly] locals can now be indirect in DWARF.
Feb 2 2021, 9:05 AM · Restricted Project

Jan 25 2021

pfaffe committed rGda489946a9d8: [llvm-dwp] Automatically set the target triple (authored by pfaffe).
[llvm-dwp] Automatically set the target triple
Jan 25 2021, 3:00 AM
pfaffe closed D93749: [llvm-dwp] Add a command line option to set the target triple.
Jan 25 2021, 2:59 AM · Restricted Project

Jan 22 2021

pfaffe abandoned D95226: Rebase and improve testcase: The file can just be empty..
Jan 22 2021, 5:35 AM · Restricted Project
pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Restore changes lost in previous patchset.

Jan 22 2021, 5:34 AM · Restricted Project
pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Rebase and improve testcase: The file can just be empty.

Jan 22 2021, 5:33 AM · Restricted Project
pfaffe requested review of D95226: Rebase and improve testcase: The file can just be empty..
Jan 22 2021, 5:32 AM · Restricted Project

Jan 15 2021

pfaffe added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

OP_deref would work if the structs are small enough. Leaving out OP_stack_value should just work. It's a terminator of sorts for values that aren't in memory, like registers on native or locals or globals in wasm land.

Jan 15 2021, 12:13 PM · Restricted Project
pfaffe added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

DW_OP_deref loads 32bit (64bit if the address size is 8), is that what's intended here? The struct passed by value could be bigger than that, couldn't it?

Jan 15 2021, 12:55 AM · Restricted Project

Jan 14 2021

pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Replace binary test with an assembly test.

Jan 14 2021, 2:08 AM · Restricted Project

Jan 13 2021

pfaffe updated the diff for D93749: [llvm-dwp] Add a command line option to set the target triple.

Read triple from first dwo file instead of from command line and add a test.

Jan 13 2021, 7:22 AM · Restricted Project

Jan 12 2021

pfaffe added a comment to D93621: [lldb][wasm] Parse DWO section names.

Thanks! Would you mind landing the change for me? I'm not a github comitter.

Jan 12 2021, 8:07 AM · Restricted Project

Dec 23 2020

pfaffe added a reviewer for D93749: [llvm-dwp] Add a command line option to set the target triple: dblaikie.
Dec 23 2020, 12:46 AM · Restricted Project
pfaffe requested review of D93749: [llvm-dwp] Add a command line option to set the target triple.
Dec 23 2020, 12:45 AM · Restricted Project

Dec 22 2020

pfaffe added a reviewer for D93621: [lldb][wasm] Parse DWO section names: labath.
Dec 22 2020, 6:38 AM · Restricted Project
pfaffe updated the diff for D93621: [lldb][wasm] Parse DWO section names.

Add the new dwo sections to the testcase.

Dec 22 2020, 6:37 AM · Restricted Project

Dec 21 2020

pfaffe requested review of D93621: [lldb][wasm] Parse DWO section names.
Dec 21 2020, 2:06 AM · Restricted Project