Page MenuHomePhabricator

pcwalton (Patrick Walton)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 12 2016, 3:40 PM (354 w, 5 d)

Recent Activity

Dec 19 2022

pcwalton updated the summary of D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..
Dec 19 2022, 4:36 PM · Restricted Project, Restricted Project
pcwalton added a comment to D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..

Should be ready for re-review now.

Dec 19 2022, 4:35 PM · Restricted Project, Restricted Project
pcwalton retitled D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together. from [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together, disabled by default. to [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..
Dec 19 2022, 4:32 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..

Updated per comments. The optimization is now enabled by default and tests have been updated accordingly.

Dec 19 2022, 4:31 PM · Restricted Project, Restricted Project

Dec 15 2022

pcwalton added a comment to D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..

I know this is a big patch. Please feel free to let me know if it's too much to review and I can hand it to someone else. Thanks for your time :)

Dec 15 2022, 2:03 AM · Restricted Project, Restricted Project
pcwalton added a reviewer for D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together.: nikic.
Dec 15 2022, 2:02 AM · Restricted Project, Restricted Project
pcwalton requested review of D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..
Dec 15 2022, 2:01 AM · Restricted Project, Restricted Project

Nov 7 2022

pcwalton added a comment to D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata..

FWIW, that is rather exactly what i'm doing in https://reviews.llvm.org/D113520. It seems to work, but is needs some legality check, because it can end up trying to promote backing alloca, over and over again.

Nov 7 2022, 11:30 AM · Restricted Project, Restricted Project

Nov 5 2022

pcwalton added a comment to D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata..

As an alternative, I wonder if we could teach SROA to do a form of argument promotion for nocapture noalias readonly dereferenceable aligned arguments. If the only thing blocking an alloca from SROA is being passed into a function by nocapture noalias readonly dereferenceable aligned pointer, insert a new alloca and memcpy to "reform" the structure right before the call, change the call to pass a pointer to the new alloca containing the "reformed" structure, and then the original alloca becomes SROAable. This could avoid all those ugly spills and reloads in the drop_in_place function bodies... assuming we could come up with some kind of heuristic to know when it's worth inserting copies to perform SROA in these instances.

Nov 5 2022, 10:39 PM · Restricted Project, Restricted Project
pcwalton added a comment to D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata..

Looking at this again, there are still quite a few spills that turn into effectively memcpys, so this isn't a panacea, but I'll take a ~25% stack size win. In any case turning the fields into SSA values will probably be a prerequisite for further optimizations.

Nov 5 2022, 7:45 PM · Restricted Project, Restricted Project
pcwalton added a comment to D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata..

No argument promotion: https://gist.github.com/pcwalton/38ff053dd1973ca383b85183e13de0fc

Nov 5 2022, 5:22 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata.: nikic.
Nov 5 2022, 1:29 PM · Restricted Project, Restricted Project
pcwalton requested review of D137497: [ArgumentPromotion] Allow the frontend to specify the maximum number of elements to promote on a per-function basis via metadata..
Nov 5 2022, 1:25 PM · Restricted Project, Restricted Project

Oct 31 2022

pcwalton committed rG01859da84bad: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of… (authored by pcwalton).
[AliasAnalysis] Introduce getModRefInfoMask() as a generalization of…
Oct 31 2022, 1:04 PM · Restricted Project, Restricted Project
pcwalton closed D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 31 2022, 1:04 PM · Restricted Project, Restricted Project
pcwalton updated the summary of D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 31 2022, 10:49 AM · Restricted Project, Restricted Project
pcwalton updated the summary of D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 31 2022, 10:48 AM · Restricted Project, Restricted Project

Oct 30 2022

pcwalton committed rG36bbd68667db: [InstCombine] Allow memcpys from constant memory to readonly nocapture… (authored by pcwalton).
[InstCombine] Allow memcpys from constant memory to readonly nocapture…
Oct 30 2022, 2:41 PM · Restricted Project, Restricted Project
pcwalton closed D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 30 2022, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton added a comment to D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Failure seems like an unrelated Windows Fortran build error.

Oct 30 2022, 2:40 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Rebased to make sure CI succeeds.

Oct 30 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton committed rGc5ea9b8a51dd: [test][asan] Make the printf-5.c test case actually emit a volatile memcpy. (authored by pcwalton).
[test][asan] Make the printf-5.c test case actually emit a volatile memcpy.
Oct 30 2022, 1:21 PM · Restricted Project, Restricted Project
pcwalton closed D137042: [test][asan] Make the printf-5.c test case actually emit a volatile memcpy..
Oct 30 2022, 1:20 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Address review comments.

Oct 30 2022, 1:19 PM · Restricted Project, Restricted Project
pcwalton requested review of D137042: [test][asan] Make the printf-5.c test case actually emit a volatile memcpy..
Oct 30 2022, 11:10 AM · Restricted Project, Restricted Project
pcwalton retitled D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided. from [InstCombine] Allow memcpys from constant memory to readonly noalias parameters to be elided. to [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 30 2022, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Rebased. This should be ready for sign off now.

Oct 30 2022, 2:48 AM · Restricted Project, Restricted Project
pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Rebased. This should be ready for sign off now.

Oct 30 2022, 2:47 AM · Restricted Project, Restricted Project, Restricted Project
pcwalton committed rG86c95dca5c1b: [test][InstCombine] Add tests for removing memcpy to an alloca that is passed… (authored by pcwalton).
[test][InstCombine] Add tests for removing memcpy to an alloca that is passed…
Oct 30 2022, 2:46 AM · Restricted Project, Restricted Project
pcwalton closed D137033: [test][InstCombine] Add tests for removing memcpy to an alloca that is passed to a readonly nocapture function parameter, in preparation for D136822..
Oct 30 2022, 2:46 AM · Restricted Project, Restricted Project
pcwalton committed rGcb2cb2d20181: [InstCombine] Avoid deleting volatile memcpys. (authored by pcwalton).
[InstCombine] Avoid deleting volatile memcpys.
Oct 30 2022, 2:41 AM · Restricted Project, Restricted Project
pcwalton closed D137031: [InstCombine] Avoid deleting volatile memcpys..
Oct 30 2022, 2:40 AM · Restricted Project, Restricted Project
pcwalton committed rG8357ff6f3d6d: [test][InstCombine] Add a test case for volatile memcpy forwarding in… (authored by pcwalton).
[test][InstCombine] Add a test case for volatile memcpy forwarding in…
Oct 30 2022, 2:39 AM · Restricted Project, Restricted Project
pcwalton closed D137029: [test][InstCombine] Add a test case for volatile memcpy forwarding in InstCombine, which is currently optimized incorrectly..
Oct 30 2022, 2:39 AM · Restricted Project, Restricted Project

Oct 29 2022

pcwalton retitled D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory(). from [AliasAnalysis] Introduce getModRefMask() as a generalization of pointsToConstantMemory(). to [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 29 2022, 7:11 PM · Restricted Project, Restricted Project
pcwalton added a comment to D137033: [test][InstCombine] Add tests for removing memcpy to an alloca that is passed to a readonly nocapture function parameter, in preparation for D136822..

I'm unsure if this needs review, but I thought I would ask to be safe.

Oct 29 2022, 7:08 PM · Restricted Project, Restricted Project
pcwalton added a comment to D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

I split the tests out to D137033.

Oct 29 2022, 7:07 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton added a reviewer for D137033: [test][InstCombine] Add tests for removing memcpy to an alloca that is passed to a readonly nocapture function parameter, in preparation for D136822.: nikic.
Oct 29 2022, 7:07 PM · Restricted Project, Restricted Project
pcwalton requested review of D137033: [test][InstCombine] Add tests for removing memcpy to an alloca that is passed to a readonly nocapture function parameter, in preparation for D136822..
Oct 29 2022, 7:07 PM · Restricted Project, Restricted Project
pcwalton added a comment to D137031: [InstCombine] Avoid deleting volatile memcpys..

I noticed that the memcpy in the asan test case is volatile without any changes, so I shouldn't need to touch that test case now.

Oct 29 2022, 5:54 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D137031: [InstCombine] Avoid deleting volatile memcpys.: nikic.
Oct 29 2022, 5:37 PM · Restricted Project, Restricted Project
pcwalton requested review of D137031: [InstCombine] Avoid deleting volatile memcpys..
Oct 29 2022, 5:37 PM · Restricted Project, Restricted Project
pcwalton added a comment to D137029: [test][InstCombine] Add a test case for volatile memcpy forwarding in InstCombine, which is currently optimized incorrectly..

Wasn't sure if this needed review, but I wanted to be safe.

Oct 29 2022, 5:16 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D137029: [test][InstCombine] Add a test case for volatile memcpy forwarding in InstCombine, which is currently optimized incorrectly.: nikic.
Oct 29 2022, 5:16 PM · Restricted Project, Restricted Project
pcwalton requested review of D137029: [test][InstCombine] Add a test case for volatile memcpy forwarding in InstCombine, which is currently optimized incorrectly..
Oct 29 2022, 5:15 PM · Restricted Project, Restricted Project
pcwalton added a comment to D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

OK, I pushed the baseline test changes. @nikic Let me know if this looks good and I can push this.

Oct 29 2022, 3:10 PM · Restricted Project, Restricted Project
pcwalton committed rG81767f2d180d: [test][AliasAnalysis] Add some baseline tests in preparation for… (authored by pcwalton).
[test][AliasAnalysis] Add some baseline tests in preparation for…
Oct 29 2022, 3:09 PM · Restricted Project, Restricted Project
pcwalton closed D136993: [test][AliasAnalysis] Add some baseline tests in preparation for getModRefInfoMask()..
Oct 29 2022, 3:09 PM · Restricted Project, Restricted Project
pcwalton committed rGf3d49dbcb13a: [test] Remove readonly from some parameters that are written through in tests. (authored by pcwalton).
[test] Remove readonly from some parameters that are written through in tests.
Oct 29 2022, 3:07 PM · Restricted Project, Restricted Project
pcwalton closed D136880: [test] Remove readonly from some parameters that are written through in tests..
Oct 29 2022, 3:07 PM · Restricted Project, Restricted Project
pcwalton added inline comments to D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 29 2022, 3:00 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Addresses comments.

Oct 29 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Rebased on top of updated D136993.

Oct 29 2022, 11:28 AM · Restricted Project, Restricted Project
pcwalton updated the diff for D136993: [test][AliasAnalysis] Add some baseline tests in preparation for getModRefInfoMask()..

Addressed review comments.

Oct 29 2022, 11:27 AM · Restricted Project, Restricted Project
pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Addressed review comments.

Oct 29 2022, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Review comments addressed. I tried to fix the asan test as well; let me know if that approach looks good.

Oct 28 2022, 11:22 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton added inline comments to D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 28 2022, 9:03 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Addressed comments. Note that D136993 contains the diff this is now based on top of.

Oct 28 2022, 5:03 PM · Restricted Project, Restricted Project
pcwalton added a comment to D136993: [test][AliasAnalysis] Add some baseline tests in preparation for getModRefInfoMask()..

I'm not sure if this needs review or not, but I thought I'd ask to be safe.

Oct 28 2022, 3:16 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D136993: [test][AliasAnalysis] Add some baseline tests in preparation for getModRefInfoMask().: nikic.
Oct 28 2022, 3:16 PM · Restricted Project, Restricted Project
pcwalton requested review of D136993: [test][AliasAnalysis] Add some baseline tests in preparation for getModRefInfoMask()..
Oct 28 2022, 3:16 PM · Restricted Project, Restricted Project

Oct 27 2022

pcwalton added inline comments to D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 27 2022, 8:03 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Updated to address review comments.

Oct 27 2022, 8:02 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D136880: [test] Remove readonly from some parameters that are written through in tests.: nikic.
Oct 27 2022, 1:09 PM · Restricted Project, Restricted Project
pcwalton requested review of D136880: [test] Remove readonly from some parameters that are written through in tests..
Oct 27 2022, 1:08 PM · Restricted Project, Restricted Project
pcwalton added inline comments to D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 27 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton updated the diff for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..

Addressed review comments.

Oct 27 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
pcwalton added a reviewer for D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided.: nikic.
Oct 27 2022, 1:52 AM · Restricted Project, Restricted Project, Restricted Project
pcwalton requested review of D136822: [InstCombine] Allow memcpys from constant memory to readonly nocapture parameters to be elided..
Oct 27 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Fix AMDGPU alias analysis and new test failure.

Oct 26 2022, 2:56 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Fix AMDGPU alias analysis.

Oct 26 2022, 12:50 PM · Restricted Project, Restricted Project
pcwalton added a comment to D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Should be ready for review again. I'll look at the failing test cases in the meantime.

Oct 26 2022, 12:03 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..

Merge pointsToConstantMemory() into getModRefMask().

Oct 26 2022, 12:00 PM · Restricted Project, Restricted Project

Oct 25 2022

pcwalton added inline comments to D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 25 2022, 5:09 PM · Restricted Project, Restricted Project
pcwalton added inline comments to D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory()..
Oct 25 2022, 5:08 PM · Restricted Project, Restricted Project

Oct 24 2022

pcwalton published D136659: [AliasAnalysis] Introduce getModRefInfoMask() as a generalization of pointsToConstantMemory(). for review.
Oct 24 2022, 8:54 PM · Restricted Project, Restricted Project
pcwalton added a comment to D136218: [DSE] Sink a memory access if it is only alive in one successor..

This is great! A couple of things I noticed on my test case:

Oct 24 2022, 6:12 PM · Restricted Project, Restricted Project

Jun 24 2022

pcwalton added a comment to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

I verified that the failing tests don't break locally.

Jun 24 2022, 5:24 PM · Restricted Project, Restricted Project

Jun 23 2022

pcwalton added a comment to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

The test failures in libomp don't look related to me.

Jun 23 2022, 4:56 PM · Restricted Project, Restricted Project

Jun 17 2022

pcwalton updated the summary of D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..
Jun 17 2022, 5:57 PM · Restricted Project, Restricted Project
pcwalton added a comment to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

This should be ready for review now.

Jun 17 2022, 5:56 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

So this was a fun one. The previous version of this patch accidentally caused a
pre-existing bug to surface and break Chromium. In certain circumstances
including the Chromium test case, available_externally symbols would cause
invalid lookups in the SymSize table. Before this patch, the lookups were
done with the [] operator, which would succeed but cause an unspecified value
to be emitted in the .debug_aranges table. But this patch moves those lookups
to be done by dereferencing the result of the .find() method, which causes
asserts if the key is not found.

Jun 17 2022, 5:54 PM · Restricted Project, Restricted Project

Jun 16 2022

pcwalton added a comment to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

Minimal reproduction:

Jun 16 2022, 11:12 AM · Restricted Project, Restricted Project

Jun 8 2022

pcwalton updated the diff for D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

Updated the diff to address comments.

Jun 8 2022, 11:50 AM · Restricted Project, Restricted Project

Jun 7 2022

pcwalton added inline comments to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..
Jun 7 2022, 2:44 PM · Restricted Project, Restricted Project

Jun 2 2022

pcwalton added a comment to D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..

Test failures look unrelated?

Jun 2 2022, 10:38 AM · Restricted Project, Restricted Project

Jun 1 2022

pcwalton added a reviewer for D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic).: dblaikie.
Jun 1 2022, 3:48 PM · Restricted Project, Restricted Project
pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

Abandoned in favor of D126835.

Jun 1 2022, 3:47 PM · Restricted Project, Restricted Project
pcwalton requested review of D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic)..
Jun 1 2022, 3:45 PM · Restricted Project, Restricted Project

May 31 2022

pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

I see. I don't have commit access unfortunately.

May 31 2022, 2:12 AM · Restricted Project, Restricted Project
pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

Sorry for the delay. I was looking at this on Friday but didn't get around to finishing it. Feel free to revert in the meantime.

May 31 2022, 1:36 AM · Restricted Project, Restricted Project

May 25 2022

pcwalton abandoned D126010: Make sure the AsmPrinter doesn't emit any zero-sized symbols to `.debug_aranges`..

Closing in favor of D126257.

May 25 2022, 1:17 PM · Restricted Project, Restricted Project
pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

Oh, what I mean is that our choices in the case in which zero-sized global symbols are forbidden at the IR level would be (1) don't emit source-level zero-sized symbols into LLVM IR (or don't emit DWARF metadata for them), or (2) round all zero-sized symbols up to one byte. If we pick (1), I don't think they would show up in the debug info, which could be confusing for programmers. If we pick (2), then certain abstractions which are zero-cost today in Rust become non-zero-cost.

May 25 2022, 1:03 PM · Restricted Project, Restricted Project

May 24 2022

pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

Wouldn't that mean that those zero-sized data symbols won't show up in the debugger anymore? That might be confusing for Rust users, who do use zero-sized globals reasonably commonly (to attach methods to).

May 24 2022, 5:13 PM · Restricted Project, Restricted Project
pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

How's this?

May 24 2022, 4:35 PM · Restricted Project, Restricted Project
pcwalton updated the diff for D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

Emit a constant 1 instead of a more complicated MCExpr when emitting symbols of length 1.

May 24 2022, 4:34 PM · Restricted Project, Restricted Project

May 23 2022

pcwalton added inline comments to D126010: Make sure the AsmPrinter doesn't emit any zero-sized symbols to `.debug_aranges`..
May 23 2022, 4:35 PM · Restricted Project, Restricted Project
pcwalton added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

@dblaikie Here's a new version of the patch that takes the alternate approach you suggested of rounding lengths up to 1 byte. Feel free to take either diff and I'll close the other.

May 23 2022, 4:34 PM · Restricted Project, Restricted Project
pcwalton added a reviewer for D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`.: dblaikie.
May 23 2022, 4:33 PM · Restricted Project, Restricted Project
pcwalton requested review of D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..
May 23 2022, 4:32 PM · Restricted Project, Restricted Project