Page MenuHomePhabricator

pcanal (Philippe Canal)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2017, 3:08 AM (120 w, 6 d)

Recent Activity

May 29 2017

pcanal added inline comments to D33529: Allow clients to specify search order of DynamicLibraries..
May 29 2017, 2:07 PM
pcanal added inline comments to D33529: Allow clients to specify search order of DynamicLibraries..
May 29 2017, 1:45 PM

May 27 2017

pcanal added a comment to D33529: Allow clients to specify search order of DynamicLibraries..

The new version looks promising. We are going to give a try. Thanks.

May 27 2017, 2:37 AM
pcanal added a comment to D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called..

The new version looks promising. We are going to give a try. Thanks.

May 27 2017, 2:36 AM

May 26 2017

pcanal added a comment to D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called..

I assume you guys aren't arguing to going back to undefined behavior just because it worked better for you.

May 26 2017, 3:18 PM
pcanal added a comment to D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called..

Why does https://reviews.llvm.org/D33529 not address your concerns?

May 26 2017, 9:10 AM
pcanal added a comment to D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called..

You should test it with ROOT, there we do a dlopen(libcling, RTLD_LAZY|RTLD_LOCAL) and I think there the symbol resolution doesn't work as before.

RTLD_LOCAL means any symbols loaded will not be available for lookup.
If you are relying on symbol lookup via a process handle [ dlsym(dlopen(NULL, Flags), "Symbol") ] then you need to use RTLD_GLOBAL.

May 26 2017, 3:28 AM