Page MenuHomePhabricator

pbhatu (Pratik Bhatu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2015, 9:41 AM (246 w, 4 h)

Recent Activity

Aug 16 2018

pbhatu added a comment to D48913: [llvm-mc-assemble-fuzzer] Update API - Pass MCObjectWriter instead of a stream.

I guess a buildbot should exist for this as this build failure was undetected for almost 3 months.
Anyways, since I don't have commit access, could you please commit it for me?

Aug 16 2018, 9:05 PM
pbhatu added reviewers for D48913: [llvm-mc-assemble-fuzzer] Update API - Pass MCObjectWriter instead of a stream: bogner, lhames.
Aug 16 2018, 12:38 AM

Jul 3 2018

pbhatu created D48913: [llvm-mc-assemble-fuzzer] Update API - Pass MCObjectWriter instead of a stream.
Jul 3 2018, 11:33 PM

Mar 1 2018

pbhatu added a comment to D42358: [X86][x32] Save callee-save register used as base pointer for x32 ABI.

Can you please commit it for me? I don't have commit access.

Mar 1 2018, 9:13 PM

Feb 7 2018

pbhatu added a comment to D42358: [X86][x32] Save callee-save register used as base pointer for x32 ABI.

Ping!

Feb 7 2018, 1:14 AM

Jan 29 2018

pbhatu updated the diff for D42183: [LLD] [ELF] Pass CPU string to LTO pipeline..

Addressed comments: clang-formatted the patch and removed the -m option from the test case.

Jan 29 2018, 11:19 PM

Jan 21 2018

pbhatu created D42358: [X86][x32] Save callee-save register used as base pointer for x32 ABI.
Jan 21 2018, 8:46 PM

Jan 18 2018

pbhatu added a comment to D42183: [LLD] [ELF] Pass CPU string to LTO pipeline..

You should add a testcase as Rafael pointed out. Overall it looks fine.
We used mllvm in lld to pass this kind of options to the backend but this seems justifiable.
BTW, if you're using lld or the gold plugin you might consider implementing the linker counterpart as well (if you have your proprietary linker, just ignore this last bit).

Jan 18 2018, 10:09 PM
pbhatu updated the diff for D42183: [LLD] [ELF] Pass CPU string to LTO pipeline..

I added a test case. Since znver1 supports NOPW, it should be generated when we specify it as the CPU.

Jan 18 2018, 10:04 PM

Jan 17 2018

pbhatu created D42183: [LLD] [ELF] Pass CPU string to LTO pipeline..
Jan 17 2018, 7:09 AM

Aug 27 2015

pbhatu updated the diff for D12268: Do not detect Scops with only one loop..

I have added back the previously removed options and it now passes make check-polly.

Aug 27 2015, 9:26 AM

Aug 23 2015

pbhatu updated the diff for D12268: Do not detect Scops with only one loop..

Removal of -polly-detect-scops-in-regions-without-loops causes these test-cases to fail.

Polly :: Isl/CodeGen/20120316-InvalidCast.ll
Polly :: Isl/CodeGen/constant_condition.ll
Polly :: Isl/CodeGen/simple_non_single_entry.ll
Polly :: ScopDetect/parametric-multiply-in-scev.ll
Polly :: ScopDetect/simple_non_single_entry.ll
Polly :: ScopDetectionDiagnostics/ReportLoopBound-01.ll
Aug 23 2015, 4:13 AM

Aug 22 2015

pbhatu retitled D12268: Do not detect Scops with only one loop. from to Do not detect Scops with only one loop..
Aug 22 2015, 10:54 PM

Aug 20 2015

pbhatu updated the diff for D12198: Removal of Intersection with AssumedContext in calculateMinMaxAccess.

Don't pass the assumedContext to calculateMinMaxAccess.

Aug 20 2015, 9:45 AM
pbhatu retitled D12198: Removal of Intersection with AssumedContext in calculateMinMaxAccess from to Removal of Intersection with AssumedContext in calculateMinMaxAccess.
Aug 20 2015, 9:28 AM

Aug 18 2015

pbhatu closed D12101: Calculate Dependences using Schedule Trees..

Commited in r245300.

Aug 18 2015, 9:42 AM
pbhatu retitled D12101: Calculate Dependences using Schedule Trees. from Calculate dependences using schedule trees. to Calculate Dependences using Schedule Trees..
Aug 18 2015, 7:17 AM
pbhatu added a comment to D12101: Calculate Dependences using Schedule Trees..

Performance results from lnt.
Base: http://gcc12.fsffrance.org:8011/builders/perf-x86_64-penryn-O3-polly/builds/189/steps/lnt.nightly-test/logs/report.json
Patched: http://gcc12.fsffrance.org:8011/builders/perf-x86_64-penryn-O3-polly/builds/183/steps/lnt.nightly-test/logs/report.json

Aug 18 2015, 7:13 AM
pbhatu retitled D12101: Calculate Dependences using Schedule Trees. from to Calculate dependences using schedule trees..
Aug 18 2015, 7:00 AM

Jul 22 2015

pbhatu updated the diff for D11362: [Polly] Removed redundant alias checks generated during run time..

Added comment that AG only contains non read only accesses

Jul 22 2015, 1:00 AM
pbhatu added inline comments to D11362: [Polly] Removed redundant alias checks generated during run time..
Jul 22 2015, 12:58 AM

Jul 21 2015

pbhatu removed a reviewer for D11362: [Polly] Removed redundant alias checks generated during run time.: pollydev.
Jul 21 2015, 1:45 AM

Jul 20 2015

pbhatu added a comment to D11362: [Polly] Removed redundant alias checks generated during run time..

Here are the performance reports from the buildbots.
There seems to be
One compile time regression: 42.8% (SingleSource/Benchmarks/Polybench/stencils/fdtd-apml/fdtd-apml) and
11 execution time regressions.
On the other hand there is
One compile time improvement:-40.28% (SingleSource/Benchmarks/McGill/misr) and
5 execution time improvements.
Surprisingly improvement in 3mm does not show up here.

Jul 20 2015, 10:50 PM
pbhatu retitled D11362: [Polly] Removed redundant alias checks generated during run time. from to [Polly] Removed redundant alias checks generated during run time..
Jul 20 2015, 11:24 AM