Page MenuHomePhabricator

patricklyster (Patrick Lyster)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 8:30 AM (54 w, 6 d)

Recent Activity

Mar 13 2019

patricklyster added a comment to D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit.

Please note this change set broke the following buildbot and has yet to be fixed: http://lab.llvm.org:8011/builders/openmp-clang-ppc64le-linux-rhel/builds/140

I don't think that's true, did you look at the error message?

-- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR
-- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR - Failed
CMake Error at cmake/modules/CheckCompilerVersion.cmake:102 (message):
  libstdc++ version should be at least 5.1 because LLVM will soon use new C++
  features which your toolchain version doesn't support.  You can temporarily
  opt out using LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN, but very soon your
  toolchain won't be supported.
Call Stack (most recent call first):
  cmake/config-ix.cmake:13 (include)
  CMakeLists.txt:629 (include)

This is when compiling Clang and I'd guess that's because of https://github.com/llvm/llvm-project/commit/51dcfdbba334fbd6c84fdf652023106d6714c73b. This problem needs to be fixed by the bot owner!

Mar 13 2019, 12:37 PM · Restricted Project
patricklyster added a comment to D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit.

Please note this change set broke the following buildbot and has yet to be fixed: http://lab.llvm.org:8011/builders/openmp-clang-ppc64le-linux-rhel/builds/140

Mar 13 2019, 10:16 AM · Restricted Project

Feb 6 2019

patricklyster committed rG16471947f519: Test commit. NFC (authored by patricklyster).
Test commit. NFC
Feb 6 2019, 10:19 AM

Jan 2 2019

patricklyster closed D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer.
Jan 2 2019, 11:47 AM · Restricted Project, Restricted Project
patricklyster added 1 commit(s) for D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer: rC350252: [OpenMP] Added support for explicit mapping of classes using 'this' pointer..
Jan 2 2019, 11:47 AM · Restricted Project, Restricted Project
patricklyster added an edge to rC350252: [OpenMP] Added support for explicit mapping of classes using 'this' pointer.: D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer.
Jan 2 2019, 11:47 AM

Dec 20 2018

patricklyster created D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer.
Dec 20 2018, 7:19 PM · Restricted Project, Restricted Project

Nov 19 2018

patricklyster closed D54493: [OPENMP] Check target architecture supports unified shared memory for requires directive.
Nov 19 2018, 7:17 AM · Restricted Project, Restricted Project
patricklyster added an edge to rL347214: [OpenMP] Check target architecture supports unified shared memory for requires…: D54493: [OPENMP] Check target architecture supports unified shared memory for requires directive.
Nov 19 2018, 7:17 AM
patricklyster added 1 commit(s) for D54493: [OPENMP] Check target architecture supports unified shared memory for requires directive: rL347214: [OpenMP] Check target architecture supports unified shared memory for requires….
Nov 19 2018, 7:17 AM · Restricted Project, Restricted Project

Nov 13 2018

patricklyster created D54493: [OPENMP] Check target architecture supports unified shared memory for requires directive.
Nov 13 2018, 1:21 PM · Restricted Project, Restricted Project

Nov 5 2018

patricklyster closed D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive.
Nov 5 2018, 8:17 AM · Restricted Project, Restricted Project
patricklyster added 1 commit(s) for D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive: rL345967: Add support for 'atomic_default_mem_order' clause on 'requires' directive. Also….
Nov 5 2018, 8:17 AM · Restricted Project, Restricted Project
patricklyster added an edge to rL345967: Add support for 'atomic_default_mem_order' clause on 'requires' directive. Also…: D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive.
Nov 5 2018, 8:17 AM

Oct 22 2018

patricklyster added inline comments to D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive.
Oct 22 2018, 12:14 PM · Restricted Project, Restricted Project
patricklyster created D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive.
Oct 22 2018, 10:28 AM · Restricted Project, Restricted Project

Oct 18 2018

patricklyster closed D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC.
Oct 18 2018, 7:52 AM · Restricted Project, Restricted Project
patricklyster added 1 commit(s) for D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC: rC344740: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC..
Oct 18 2018, 7:52 AM · Restricted Project, Restricted Project
patricklyster added an edge to rC344740: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC.: D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC.
Oct 18 2018, 7:52 AM
patricklyster retitled D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC from [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp NFC to [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC.
Oct 18 2018, 6:18 AM · Restricted Project, Restricted Project
patricklyster retitled D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC from [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp to [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp NFC.
Oct 18 2018, 6:18 AM · Restricted Project, Restricted Project
patricklyster set the repository for D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC to rC Clang.
Oct 18 2018, 6:18 AM · Restricted Project, Restricted Project
patricklyster created D53395: [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp - NFC.
Oct 18 2018, 6:18 AM · Restricted Project, Restricted Project
patricklyster abandoned D53394: Initial commit moving OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp.
Oct 18 2018, 6:10 AM
patricklyster created D53394: Initial commit moving OMPClausePrinter to OpenMPClause.h/OpenMPClause.cpp.
Oct 18 2018, 6:10 AM

Oct 11 2018

patricklyster closed D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive.

Closed by commit rL344249 sha: 851f70b951e5e068b0afa6f69ec58e0e80b0a1a4

Oct 11 2018, 10:10 AM · Restricted Project
patricklyster added an edge to rL344249: Add support for 'dynamic_allocators' clause on 'requires' directive.: D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive.
Oct 11 2018, 10:10 AM
patricklyster added 1 commit(s) for D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive: rL344249: Add support for 'dynamic_allocators' clause on 'requires' directive..
Oct 11 2018, 10:10 AM · Restricted Project

Oct 10 2018

patricklyster created D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive.
Oct 10 2018, 7:05 AM · Restricted Project

Oct 5 2018

patricklyster closed D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive.
Oct 5 2018, 5:34 AM · Restricted Project, Restricted Project
patricklyster added 1 commit(s) for D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive: rC343711: [OPENMP] Add reverse_offload clause to requires directive.
Oct 5 2018, 5:34 AM · Restricted Project, Restricted Project
patricklyster added an edge to rC343711: [OPENMP] Add reverse_offload clause to requires directive: D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive.
Oct 5 2018, 5:34 AM

Oct 2 2018

patricklyster created D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive.
Oct 2 2018, 7:23 AM · Restricted Project, Restricted Project
patricklyster added 1 commit(s) for D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive: rC343472: Add support for unified_shared_memory clause on requires directive.
Oct 2 2018, 7:14 AM · Restricted Project, Restricted Project
patricklyster closed D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive.
Oct 2 2018, 7:14 AM · Restricted Project, Restricted Project
patricklyster added an edge to rC343472: Add support for unified_shared_memory clause on requires directive: D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive.
Oct 2 2018, 7:14 AM

Sep 28 2018

patricklyster updated the diff for D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive.

Added AST print test for unified_shared_memory clause

Sep 28 2018, 6:15 AM · Restricted Project, Restricted Project
patricklyster added a comment to D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive.

I forgot to mention that you need an ast print test (the positive test)

Sep 28 2018, 6:06 AM · Restricted Project, Restricted Project

Sep 27 2018

patricklyster created D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive.
Sep 27 2018, 12:45 PM · Restricted Project, Restricted Project

Sep 21 2018

patricklyster created D52359: [OPENMP] Add support for OMP5 requires directive + unified_address clause.
Sep 21 2018, 6:54 AM · Restricted Project, Restricted Project

Sep 14 2018

patricklyster created D52097: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer - NFC.
Sep 14 2018, 8:00 AM · Restricted Project, Restricted Project

Sep 5 2018

patricklyster updated the diff for D51378: [OPENMP] Add support for nested 'declare target' directives.

Previous implementation only supported immediately nested declare targets such as below:

Sep 5 2018, 7:33 AM

Aug 30 2018

patricklyster added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

I did not see the code where check is done if Nestingdepth is 0 at end of compilation.

Aug 30 2018, 11:45 AM
patricklyster added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

We should just go with generating an error if the DeclareTargetNestingLevel is not 0 at the end of compilation unit.
Hard to detect if user accidentally forgot to have end declare in header file and had it in the include file or it was intentional.

Aug 30 2018, 8:33 AM

Aug 29 2018

patricklyster added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

Is there a way to tell if the header files have matching omp declare target/omp end declare target.
The reason is if one of the header files is missing a matching omp end declare target all files which include it will end up having everything marked with declare target

Aug 29 2018, 12:32 PM

Aug 28 2018

patricklyster created D51378: [OPENMP] Add support for nested 'declare target' directives.
Aug 28 2018, 1:09 PM