Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People pateldeev

pateldeev (Deev Patel)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2022, 7:35 PM (68 w, 5 d)

Recent Activity
View All

Jul 18 2023

pateldeev added a comment to D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
In D135548#4511146, @Mordante wrote:
In D135548#4507586, @pateldeev wrote:

cc @Mordante to merge.

Thanks I can now pick it without conflicts. I noticed the attribution is "pateldeev <pateldeev@nevada.unr.edu>" Can you provide they name you want me to attribute this patch too or confirm "pateldeev" is intended?

Jul 18 2023, 9:00 AM · Restricted Project, Restricted Project

Jul 17 2023

pateldeev added a comment to D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

cc @Mordante to merge.

Jul 17 2023, 1:02 PM · Restricted Project, Restricted Project

Jul 16 2023

pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Rebase

Jul 16 2023, 11:29 AM · Restricted Project, Restricted Project

May 24 2023

pateldeev updated the summary of D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
May 24 2023, 7:44 PM · Restricted Project, Restricted Project
pateldeev added a comment to D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Could you rebased this again and upload it to test the CI.

Done

May 24 2023, 7:44 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Rebase

May 24 2023, 7:43 PM · Restricted Project, Restricted Project

Feb 16 2023

pateldeev accepted D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Rebased diff and addressed all comments. Should be ready to merge. But it seems I don't have the ability to do this.

Feb 16 2023, 10:29 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Rebase

Feb 16 2023, 10:27 PM · Restricted Project, Restricted Project

Jan 14 2023

pateldeev removed a reviewer for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads.: Restricted Project.
Jan 14 2023, 5:20 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Review. Rebase

Jan 14 2023, 5:16 PM · Restricted Project, Restricted Project
pateldeev retitled D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads. from [libc++] Implement c++20 shared_ptr rvalue overloads. to [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
Jan 14 2023, 4:52 PM · Restricted Project, Restricted Project

Nov 13 2022

pateldeev added reviewers for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads.: philnik, Mordante.
Nov 13 2022, 11:45 PM · Restricted Project, Restricted Project
pateldeev removed reviewers for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads.: philnik, Restricted Project, Mordante.
Nov 13 2022, 11:43 PM · Restricted Project, Restricted Project

Oct 18 2022

pateldeev updated the summary of D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
Oct 18 2022, 2:32 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Comments

Oct 18 2022, 2:31 PM · Restricted Project, Restricted Project

Oct 12 2022

pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Review

Oct 12 2022, 5:47 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Review

Oct 12 2022, 5:45 PM · Restricted Project, Restricted Project
pateldeev added inline comments to D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
Oct 12 2022, 5:45 PM · Restricted Project, Restricted Project

Oct 9 2022

pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

new line.

Oct 9 2022, 11:12 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Unit tests.

Oct 9 2022, 11:10 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Fix

Oct 9 2022, 10:15 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

Unit tests.

Oct 9 2022, 10:13 PM · Restricted Project, Restricted Project
pateldeev updated the diff for D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..

variable name.

Oct 9 2022, 8:57 PM · Restricted Project, Restricted Project
pateldeev updated the summary of D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads..
Oct 9 2022, 5:40 PM · Restricted Project, Restricted Project
pateldeev published D135548: [libc++][LWG 2996] Implement c++20 shared_ptr rvalue overloads. for review.
Oct 9 2022, 5:39 PM · Restricted Project, Restricted Project