Page MenuHomePhabricator

patcheng (Patrick Cheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2018, 8:13 AM (93 w, 3 d)

Recent Activity

May 10 2019

patcheng added a comment to D42564: [WebAssembly] ignore non-SymbolRef MCExpr..

https://github.com/apple/swift-llvm/pull/155/files has an alternative fix.

May 10 2019, 9:52 PM
patcheng added a comment to D42233: [WebAssembly] Better support for WASM Object format.

I haven't had the time to working on this project recently.

May 10 2019, 9:48 PM

Feb 12 2018

patcheng added a comment to D42564: [WebAssembly] ignore non-SymbolRef MCExpr..

I rolled back the changes to ignore non-MCSymbolExpr.

Feb 12 2018, 10:15 PM
patcheng updated the diff for D42564: [WebAssembly] ignore non-SymbolRef MCExpr..
Feb 12 2018, 10:10 PM

Feb 2 2018

patcheng added a comment to D42233: [WebAssembly] Better support for WASM Object format.

Hopefully, the code should be good now.

Feb 2 2018, 1:30 AM
patcheng updated the diff for D42233: [WebAssembly] Better support for WASM Object format.
Feb 2 2018, 1:21 AM

Jan 29 2018

patcheng added a comment to D42564: [WebAssembly] ignore non-SymbolRef MCExpr..

I messed up the diff. I will upload a correct one soon. hopefully with detail on the case that were hitting the code in the original diff.

Jan 29 2018, 7:11 AM

Jan 28 2018

patcheng updated the diff for D42233: [WebAssembly] Better support for WASM Object format.

Changes suggested by sbc100

Jan 28 2018, 4:50 PM
patcheng updated the diff for D42564: [WebAssembly] ignore non-SymbolRef MCExpr..

Changes suggested by sbc100

Jan 28 2018, 4:50 PM
patcheng added inline comments to D42233: [WebAssembly] Better support for WASM Object format.
Jan 28 2018, 1:53 PM

Jan 26 2018

patcheng created D42564: [WebAssembly] ignore non-SymbolRef MCExpr..
Jan 26 2018, 12:02 AM

Jan 25 2018

patcheng updated the diff for D42233: [WebAssembly] Better support for WASM Object format.

Now only align when the segment name is "__clangast"

Jan 25 2018, 11:37 PM

Jan 20 2018

patcheng updated the diff for D42233: [WebAssembly] Better support for WASM Object format.

Updated llvm-readobj and obj2yaml so that output in similar format as previously.

Jan 20 2018, 11:09 AM

Jan 18 2018

patcheng added a comment to D42233: [WebAssembly] Better support for WASM Object format.

Is it only used for unit tests?
Before I process, just want to make sure I am causing issues. Basically, I am thinking changing the output from one block for entire Data section

Jan 18 2018, 10:56 AM
patcheng added a comment to D42233: [WebAssembly] Better support for WASM Object format.

This commit is not ready. wasm2yaml is relying on WasmObjectFile::sections() to return only 1 Data Section. Now, we are returning each DataSegment. As a result, some of the tests are failing currently.

Jan 18 2018, 1:58 AM
patcheng retitled D42233: [WebAssembly] Better support for WASM Object format from Better support for WASM Object format to [WebAssembly] Better support for WASM Object format.
Jan 18 2018, 12:52 AM
patcheng created D42233: [WebAssembly] Better support for WASM Object format.
Jan 18 2018, 12:51 AM

Jan 12 2018

patcheng added a comment to D41937: [WebAssembly] supports -stdlib=libc++ switch.

BTW I don't have commit access. When it's ready to be committed, I would need help with that.

Jan 12 2018, 8:01 AM

Jan 11 2018

patcheng updated the diff for D41937: [WebAssembly] supports -stdlib=libc++ switch.

Added -lc++abi per @sbc100 's suggestion

Jan 11 2018, 7:05 PM
patcheng added inline comments to D41937: [WebAssembly] supports -stdlib=libc++ switch.
Jan 11 2018, 3:06 PM

Jan 10 2018

patcheng created D41937: [WebAssembly] supports -stdlib=libc++ switch.
Jan 10 2018, 11:24 PM