Page MenuHomePhabricator

palmer (Chris Palmer)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2019, 12:03 PM (77 w, 3 d)

Recent Activity

Fri, May 7

palmer updated the diff for D89353: Enable overriding `__libcpp_debug_function` invocation.

Rebased against the new origin/main.

Fri, May 7, 10:59 AM · Restricted Project

Nov 11 2020

palmer added a comment to D89353: Enable overriding `__libcpp_debug_function` invocation.

Thanks, jdoerrie! Does anyone else have thoughts?

Nov 11 2020, 5:19 PM · Restricted Project

Oct 13 2020

palmer added a comment to D89353: Enable overriding `__libcpp_debug_function` invocation.

This is following up on the discussion at https://reviews.llvm.org/D70343. Does this overall direction make sense to you? I have hacked it into Chromium and it seems to work.

Oct 13 2020, 5:03 PM · Restricted Project
palmer requested review of D89353: Enable overriding `__libcpp_debug_function` invocation.
Oct 13 2020, 5:02 PM · Restricted Project

Oct 6 2020

palmer added a comment to D88864: Add assert in `constexpr string_view::operator[]`.

Thanks, everyone. Please commit it as "Chris Palmer <palmer@google.com>".

Oct 6 2020, 10:13 AM · Restricted Project

Oct 5 2020

palmer requested review of D88864: Add assert in `constexpr string_view::operator[]`.
Oct 5 2020, 5:17 PM · Restricted Project
palmer abandoned D70343: Add a `_LIBCPP_HARDEN` define.

I'll start a new revision to add the missing string_view assert.

Oct 5 2020, 5:07 PM

May 13 2020

palmer added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

There's a confusing distinction in libc++ between _LIBCPP_DEBUG_LEVEL and _LIBCPP_DEBUG. `
_LIBCPP_DEBUG_LEVEL is always one more that _LIBCPP_DEBUG. So libcpp-debug-level-0, shouldn't enable anything,
But I assume you correctly set _LIBCPP_DEBUG to zero.

May 13 2020, 2:11 PM
palmer added inline comments to D70343: Add a `_LIBCPP_HARDEN` define.
May 13 2020, 11:25 AM
palmer added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

Here are some binary size numbers, from a Chromium release build. Here is the build configuration (likely meaningful only to Chromium people; but this basically means "fully optimized except for the final PGO phase"):

May 13 2020, 11:25 AM
palmer updated the summary of D70343: Add a `_LIBCPP_HARDEN` define.
May 13 2020, 10:17 AM

May 12 2020

palmer added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

Yes, I am still testing the binary size question. I hope to get back to you on that this week, and in any case won't land this until I have got some answer.

May 12 2020, 1:27 PM

May 8 2020

palmer updated the diff for D70343: Add a `_LIBCPP_HARDEN` define.

Going back to the return-expression form.

May 8 2020, 12:20 PM
palmer added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

We had some discussion in email, but it didn't show up here. New patch coming up, using the return-expression form, as discussed.

May 8 2020, 12:20 PM

Nov 26 2019

palmer updated the diff for D70343: Add a `_LIBCPP_HARDEN` define.

Respond to comments.

Nov 26 2019, 2:21 PM
palmer added a comment to D70343: Add a `_LIBCPP_HARDEN` define.

Yes, jdoerrie has the motivation right. Thanks!

Nov 26 2019, 2:17 PM

Nov 15 2019

palmer created D70343: Add a `_LIBCPP_HARDEN` define.
Nov 15 2019, 2:58 PM