- User Since
- Mar 9 2016, 5:56 PM (288 w, 3 d)
Jul 12 2021
That's fair enough. I don't know if I'm qualified to review this, but this I think this is a better solution than my fix.
I tested my reproducer and it also fixes it, thanks. Should it be an error to specify -fno-dwarf-directory-asm together with -gdwarf-5, since that produces incorrect results?
Thank you! How do I get this landed?
Jul 9 2021
It is opt-in in the sense that you have to opt in to DWARF 5, though. And if you're asking for DWARF 5 with -no-integrated-as, then your assembler better support the directives needed for DWARF 5.
I'm not passing any flags to opt in to hashes, and I'm getting them:
Jul 8 2021
The existing CodeGen tests already cover this, so I updated them.
Got a link to conversations, patches, etc, that confirm this claim:
Apr 10 2020
Thank you! I don't have commit access. How can I get this committed?
Apr 9 2020
Update summary and test case to better reflect the issue
Apr 8 2020
The style guide I'm following (the Linux kernel style) wants AfterEnum: false. A cursory search suggests that people treat this trailing comma behavior as a feature (https://stackoverflow.com/questions/23072223/clang-format-style-options-for-enums). However, I think this is separate from my issue. Consider the following example which doesn't have a trailing comma and doesn't fit on one line:
Apr 7 2020
Nov 17 2016
Rebase. @chandlerc, could you please take a look?
Aug 12 2016
Aug 10 2016
I don't have commit access, please commit this on my behalf. Thank you!
Thanks for getting around to this, @compnerd, this should take care of your comments.