Page MenuHomePhabricator

osandov (Omar Sandoval)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2016, 5:56 PM (288 w, 3 d)

Recent Activity

Jul 12 2021

osandov accepted D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm.

That's fair enough. I don't know if I'm qualified to review this, but this I think this is a better solution than my fix.

Jul 12 2021, 3:11 PM · Restricted Project
osandov added a comment to D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm.

I tested my reproducer and it also fixes it, thanks. Should it be an error to specify -fno-dwarf-directory-asm together with -gdwarf-5, since that produces incorrect results?

Jul 12 2021, 2:57 PM · Restricted Project
osandov added a comment to D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.

Thank you! How do I get this landed?

Jul 12 2021, 10:23 AM · Restricted Project

Jul 9 2021

osandov added a comment to D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.

It is opt-in in the sense that you have to opt in to DWARF 5, though. And if you're asking for DWARF 5 with -no-integrated-as, then your assembler better support the directives needed for DWARF 5.

Jul 9 2021, 12:24 PM · Restricted Project
osandov added a comment to D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.

I'm not passing any flags to opt in to hashes, and I'm getting them:

Jul 9 2021, 12:19 PM · Restricted Project

Jul 8 2021

osandov updated the diff for D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.

The existing CodeGen tests already cover this, so I updated them.

Jul 8 2021, 4:47 PM · Restricted Project
osandov added a comment to D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.

Got a link to conversations, patches, etc, that confirm this claim:

Jul 8 2021, 3:20 PM · Restricted Project
osandov added a reviewer for D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as: probinson.
Jul 8 2021, 2:44 PM · Restricted Project
osandov requested review of D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as.
Jul 8 2021, 2:38 PM · Restricted Project

Apr 10 2020

osandov added a comment to D77682: [clang-format] Always break line after enum opening brace.

Thank you! I don't have commit access. How can I get this committed?

Apr 10 2020, 8:53 AM · Restricted Project, Restricted Project

Apr 9 2020

osandov updated the diff for D77682: [clang-format] Always break line after enum opening brace.

Update summary and test case to better reflect the issue

Apr 9 2020, 12:11 PM · Restricted Project, Restricted Project

Apr 8 2020

osandov added a comment to D77682: [clang-format] Always break line after enum opening brace.

The style guide I'm following (the Linux kernel style) wants AfterEnum: false. A cursory search suggests that people treat this trailing comma behavior as a feature (https://stackoverflow.com/questions/23072223/clang-format-style-options-for-enums). However, I think this is separate from my issue. Consider the following example which doesn't have a trailing comma and doesn't fit on one line:

Apr 8 2020, 11:25 AM · Restricted Project, Restricted Project

Apr 7 2020

osandov created D77682: [clang-format] Always break line after enum opening brace.
Apr 7 2020, 3:16 PM · Restricted Project, Restricted Project

Nov 17 2016

osandov updated the diff for D23457: Don't break curses applications in terminalHasColors().

Rebase. @chandlerc, could you please take a look?

Nov 17 2016, 4:59 PM

Aug 12 2016

osandov updated D23457: Don't break curses applications in terminalHasColors().
Aug 12 2016, 5:53 PM
osandov retitled D23457: Don't break curses applications in terminalHasColors() from to Don't break curses applications in terminalHasColors().
Aug 12 2016, 11:00 AM

Aug 10 2016

osandov added a comment to D18021: libclang: expose diagnostic formatting to Python bindings.

I don't have commit access, please commit this on my behalf. Thank you!

Aug 10 2016, 9:54 PM
osandov added a comment to D18021: libclang: expose diagnostic formatting to Python bindings.
Aug 10 2016, 7:05 PM
osandov updated the diff for D18021: libclang: expose diagnostic formatting to Python bindings.

Thanks for getting around to this, @compnerd, this should take care of your comments.

Aug 10 2016, 7:04 PM

Mar 9 2016

osandov retitled D18021: libclang: expose diagnostic formatting to Python bindings from to libclang: expose diagnostic formatting to Python bindings.
Mar 9 2016, 6:05 PM