oren_ben_simhon (Oren Ben Simhon)
SW Engineer - Intel Israel

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 6:49 AM (51 w, 4 d)

Recent Activity

Aug 3 2017

oren_ben_simhon accepted D36081: [X86] Improved X86::CMOV to Branch heuristic.

LGTM

Aug 3 2017, 7:23 AM

Jul 17 2017

oren_ben_simhon accepted D35466: [llvm] Remove redundant check-prefix=CHECK from tests. NFC..

LGTM

Jul 17 2017, 4:15 AM

Jul 16 2017

oren_ben_simhon accepted D34602: [GlobalISel][X86] Support call ABI..

LGTM

Jul 16 2017, 7:22 AM

Jul 11 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 11 2017, 3:55 AM

Jul 3 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 3 2017, 12:23 PM

Jul 2 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 2 2017, 3:56 AM

May 25 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/25 (Thanks Simon and Craig)

May 25 2017, 2:07 AM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Any idea why phabricator is showing so many unchanged lines from X86InstrInfo.cpp? Have you changed the line endings or something? They aren't appearing in the the downloaded diff FWIW.

May 25 2017, 1:57 AM

May 24 2017

oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

I will appreciate any additional comments.
Please help me finish the review.

May 24 2017, 6:37 AM

May 21 2017

oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 21 2017, 3:34 AM
oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 21 2017, 3:32 AM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/20 (Thanks Craig)

May 21 2017, 12:06 AM

May 18 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Updated the tests (Thanks Simon)

May 18 2017, 12:47 AM

May 17 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Removed TB_NO_REVERSE flag (Thanks Simon)

May 17 2017, 7:09 AM
oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/16 (Thanks again Simon and Craig)

May 17 2017, 6:57 AM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

A possible addition would be to custom lower i8/i16 vectors with a trunc(popcnt(zext))) pattern.

I agree with you, Will it be OK to create a separate patch for it?

May 17 2017, 6:56 AM
oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 17 2017, 5:41 AM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/16 (Thanks Craig)

May 17 2017, 5:41 AM

May 15 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Reverted clang-format for lib/Target/X86/X86InstrInfo.cpp and removed NoVLX predicate (Thanks Simon)

May 15 2017, 1:11 PM
oren_ben_simhon added inline comments to D33169: [X86] Adding vpopcntd and vpopcntq instructions.
May 15 2017, 12:52 PM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/15 (Thanks Craig and Simon)

May 15 2017, 12:50 PM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Please notice that clang-format reformatted some lists that I modified in the file lib/Target/X86/X86InstrInfo.cpp.
It caused major cosmetic changes which introduce many diffs in that file.

May 15 2017, 12:44 PM
oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/15 (Thanks Simon and Craig)

May 15 2017, 12:35 PM

May 14 2017

oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Removed files properties

May 14 2017, 5:44 AM
oren_ben_simhon created D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 14 2017, 5:17 AM
oren_ben_simhon added a reviewer for D33169: [X86] Adding vpopcntd and vpopcntq instructions: m_zuckerman.
May 14 2017, 5:11 AM
oren_ben_simhon created D33169: [X86] Adding vpopcntd and vpopcntq instructions.
May 14 2017, 5:09 AM

May 3 2017

oren_ben_simhon updated the diff for D32430: [X86] Disabling PLT in Regcall CC Functions.

Added the fix to all SystemV ELF based operating systems (Thanks Rafael and David)

May 3 2017, 7:00 AM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Updated the tests.

May 3 2017, 5:17 AM
oren_ben_simhon updated the diff for D32697: Reusing an existing attribute diagnostic.

Implemented comments posted until 05/02 (Thanks Aaron)

May 3 2017, 12:13 AM

May 1 2017

oren_ben_simhon created D32697: Reusing an existing attribute diagnostic.
May 1 2017, 1:43 AM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/30 (Thanks Amjad)

May 1 2017, 12:10 AM
oren_ben_simhon added inline comments to D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.
May 1 2017, 12:03 AM

Apr 30 2017

oren_ben_simhon updated the diff for D32430: [X86] Disabling PLT in Regcall CC Functions.

Implemented comments posted until 04/30 (Thanks Amjad)

Apr 30 2017, 11:12 PM

Apr 27 2017

oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/28 (Thanks Amjad and Matthias)

Apr 27 2017, 2:19 PM
oren_ben_simhon added a comment to D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.
Apr 27 2017, 2:13 PM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/27 (Thanks Amjad)

Apr 27 2017, 8:18 AM

Apr 26 2017

oren_ben_simhon added a comment to D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Hi Aaron, Please let me know if you have additional comments.

The missing test case is my last remaining issue with the patch.

Apr 26 2017, 6:42 AM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/25 (Thanks Amjad)

Apr 26 2017, 4:26 AM
oren_ben_simhon added a comment to D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Hi Aaron, Please let me know if you have additional comments.

Apr 26 2017, 4:17 AM

Apr 24 2017

oren_ben_simhon created D32430: [X86] Disabling PLT in Regcall CC Functions.
Apr 24 2017, 6:25 AM

Apr 23 2017

oren_ben_simhon added inline comments to D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Apr 23 2017, 12:47 PM
oren_ben_simhon updated the diff for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Implemented comments posted until 04/23 (10x Aaron)

Apr 23 2017, 12:45 PM

Apr 20 2017

oren_ben_simhon added a reviewer for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart: MatzeB.
Apr 20 2017, 3:35 AM
oren_ben_simhon updated the diff for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Implemented comments posted until 04/20 (Thanks Aaron)

Apr 20 2017, 3:32 AM

Apr 19 2017

oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Updated the test

Apr 19 2017, 8:35 AM
oren_ben_simhon updated the diff for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Implemented comments posted until 04/19 (Thank you Aaron again)

Apr 19 2017, 8:33 AM

Apr 18 2017

oren_ben_simhon added a comment to D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

A kind reminder for reviewing this patch :-) Thanks in advance.

Apr 18 2017, 5:00 AM
oren_ben_simhon updated the diff for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Implemented comments posted until 04/17 (Thank you Aaron for reviewing, Thank you Erich for helping me)

Apr 18 2017, 4:58 AM

Apr 12 2017

oren_ben_simhon updated the diff for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

Implemented comments posted until 04/10 (Thank you Aaron)

Apr 12 2017, 6:00 AM
oren_ben_simhon added a comment to D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.

aaron.ballman added a comment:
Please remove the svn prop changes for the two test files. Also, I'd like to see a test that this is properly diagnosed as both a function and a type attribute on a non-x86 architecture, as well as tests that it is properly diagnosed on a type other than a function pointer as well as with arguments on a function pointer (the current tests only test on a declaration rather than a type).

Apr 12 2017, 5:47 AM

Apr 10 2017

oren_ben_simhon created D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.
Apr 10 2017, 1:50 AM

Apr 9 2017

oren_ben_simhon updated the summary of D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Apr 9 2017, 11:09 PM
oren_ben_simhon removed a dependent revision for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart: D22045: [X86] Support of no_caller_saved_registers attribute (Clang part).
Apr 9 2017, 11:07 PM
oren_ben_simhon removed a dependency for D22045: [X86] Support of no_caller_saved_registers attribute (Clang part): D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Apr 9 2017, 11:07 PM
oren_ben_simhon added a dependency for D22045: [X86] Support of no_caller_saved_registers attribute (Clang part): D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Apr 9 2017, 11:06 PM
oren_ben_simhon added a dependent revision for D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart: D22045: [X86] Support of no_caller_saved_registers attribute (Clang part).
Apr 9 2017, 11:06 PM
oren_ben_simhon created D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Apr 9 2017, 11:04 PM

Apr 3 2017

oren_ben_simhon updated the diff for D31577: Add 64 bit pattern matching for PSADBW.

Added new function to test file and added ANY_EXTEND option as well (Thanks again Michael)

Apr 3 2017, 4:16 AM
oren_ben_simhon added inline comments to D31577: Add 64 bit pattern matching for PSADBW.
Apr 3 2017, 4:13 AM
oren_ben_simhon updated the diff for D31577: Add 64 bit pattern matching for PSADBW.

Added support for zext (instead of just sext) and added a test case (Thank you Michael)

Apr 3 2017, 12:47 AM
oren_ben_simhon added inline comments to D31577: Add 64 bit pattern matching for PSADBW.
Apr 3 2017, 12:34 AM
oren_ben_simhon updated the diff for D31577: Add 64 bit pattern matching for PSADBW.

Implemented comments posted until 03/04 (Thank You Michael)

Apr 3 2017, 12:15 AM
oren_ben_simhon added inline comments to D31577: Add 64 bit pattern matching for PSADBW.
Apr 3 2017, 12:11 AM

Apr 2 2017

oren_ben_simhon created D31577: Add 64 bit pattern matching for PSADBW.
Apr 2 2017, 5:33 AM

Mar 28 2017

oren_ben_simhon added a comment to D31102: Rename AttributeSet to AttributeList.

If i understand correctly AttributeSet is a list of attribute sets. If this is correct why not changing the name to AttributeSetList?

Mar 28 2017, 8:15 AM

Mar 16 2017

oren_ben_simhon updated the diff for D30971: [MIR] Support Customed Register Mask and CSRs.

Implemented comments posted until 03/15 (Thank you Matthias).

Mar 16 2017, 6:49 AM

Mar 15 2017

oren_ben_simhon added a reviewer for D30971: [MIR] Support Customed Register Mask and CSRs: mehdi_amini.
Mar 15 2017, 4:06 AM
oren_ben_simhon created D30971: [MIR] Support Customed Register Mask and CSRs.
Mar 15 2017, 2:15 AM

Mar 13 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments posted by Matthias (Thank you).

Mar 13 2017, 12:24 PM
oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Fixed a typo in dynamic CSR test.

Mar 13 2017, 6:05 AM
oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Updated the dynamic CSR test.

Mar 13 2017, 5:54 AM
oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments posted until 03/13 (Thanks Amjad).

Mar 13 2017, 3:34 AM

Mar 12 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments posted until 03/11 (Thank You, Amjad).

Mar 12 2017, 7:31 AM

Feb 26 2017

oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

Hi Guys, I would kindly like to remind of the review. Thanks in advance.

Feb 26 2017, 4:03 AM

Feb 22 2017

oren_ben_simhon added inline comments to D28975: [LV] Introducing VPlan to model the vectorized code and drive its transformation.
Feb 22 2017, 1:41 AM

Feb 21 2017

oren_ben_simhon created D30194: DAZ Macros Relocation.
Feb 21 2017, 4:41 AM

Feb 15 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments posted until 2/14 (Thank You Matthias & Quentin).

Feb 15 2017, 8:33 AM

Feb 6 2017

oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

Please assist in reviewing the patch.

Feb 6 2017, 11:26 AM

Feb 2 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments submitted until 02/01 (Thank you Matthias).

Feb 2 2017, 12:39 AM

Feb 1 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Implemented comments posted until 01/31

Feb 1 2017, 1:47 AM
oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

I will create a wrapper function to be used instead of getCalleeSavedRegs().

Feb 1 2017, 1:10 AM

Jan 29 2017

oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

If there are no additional comments please finish the review.

Jan 29 2017, 2:02 AM

Jan 19 2017

oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

A kindly reminder. I will appreciate your inputs on the review.

Jan 19 2017, 4:58 AM

Jan 16 2017

oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Updated lit test.

Jan 16 2017, 5:53 AM

Jan 12 2017

oren_ben_simhon added a comment to D28566: Disable Callee Saved Registers.

Thanks Krzysztof for pointing it out. I updated the patch to use LiveIns to populate CalleeSaveDisableRegs List.
Notice that they are not the same because:

  1. Each target may populate different Callee Saved Registers that should be disabled (not necessarily arguments).
  2. For x86, it includes LiveIns and also return values - only for Regcall Calling Convention.
Jan 12 2017, 8:24 AM
oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Populated CalleeSaveDisableRegs list from LiveIns list (if in regcall calling convention).

Jan 12 2017, 8:19 AM
oren_ben_simhon updated the diff for D28566: Disable Callee Saved Registers.

Using the MF Allocator to allocate the register mask.

Jan 12 2017, 5:12 AM

Jan 11 2017

oren_ben_simhon retitled D28566: Disable Callee Saved Registers from to Dynamic Callee Saved Registers.
Jan 11 2017, 8:21 AM

Dec 18 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented comments submitted until 12/16.

Dec 18 2016, 12:47 AM
oren_ben_simhon added inline comments to D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.
Dec 18 2016, 12:38 AM

Dec 15 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented comments submitted until 12/14 (Thank you Reid)

Dec 15 2016, 7:59 AM

Dec 14 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented comments posted until 12/13 (Thank you Reid)

Dec 14 2016, 3:47 AM
oren_ben_simhon added inline comments to D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.
Dec 14 2016, 3:14 AM

Dec 12 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented changes posted until 12/12 (Thank you David)

Dec 12 2016, 5:22 AM

Dec 11 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented comments submitted until 12/10 (Thank you, David/Reid/Amjad)

Dec 11 2016, 1:38 PM
oren_ben_simhon added inline comments to D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.
Dec 11 2016, 1:38 PM

Dec 8 2016

oren_ben_simhon updated the diff for D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support.

Implemented comments posted by David (Thank You)

Dec 8 2016, 8:53 AM

Dec 7 2016

oren_ben_simhon added a comment to D27148: Regcall - Adding support for mask types.

Can I commit this patch or you have additional comments?

Dec 7 2016, 1:32 AM
oren_ben_simhon added a reviewer for D27148: Regcall - Adding support for mask types: craig.topper.
Dec 7 2016, 1:30 AM