oren_ben_simhon (Oren Ben Simhon)
SW Engineer - Intel Israel

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 6:49 AM (73 w, 21 h)

Recent Activity

Thu, Feb 15

oren_ben_simhon added inline comments to D41880: Adding nocf_check attribute for cf-protection fine tuning .
Thu, Feb 15, 2:14 PM
oren_ben_simhon added inline comments to D41880: Adding nocf_check attribute for cf-protection fine tuning .
Thu, Feb 15, 7:13 AM
oren_ben_simhon updated the diff for D41880: Adding nocf_check attribute for cf-protection fine tuning .

Implemented comments posted until 02/15 (Thanks Aaron)

Thu, Feb 15, 5:16 AM
oren_ben_simhon added inline comments to D41880: Adding nocf_check attribute for cf-protection fine tuning .
Thu, Feb 15, 5:16 AM

Wed, Feb 14

oren_ben_simhon updated the diff for D41880: Adding nocf_check attribute for cf-protection fine tuning .

Implemented comments posted until 2/14 (Thanks Aaron and Craig)

Wed, Feb 14, 1:48 AM
oren_ben_simhon added inline comments to D41880: Adding nocf_check attribute for cf-protection fine tuning .
Wed, Feb 14, 1:45 AM

Tue, Feb 13

oren_ben_simhon added a comment to D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

ping

Tue, Feb 13, 1:05 AM
oren_ben_simhon added a comment to D41880: Adding nocf_check attribute for cf-protection fine tuning .

ping

Tue, Feb 13, 1:05 AM

Tue, Feb 6

oren_ben_simhon added a reviewer for D41880: Adding nocf_check attribute for cf-protection fine tuning : pcc.
Tue, Feb 6, 8:35 AM
oren_ben_simhon added a reviewer for D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking: pcc.
Tue, Feb 6, 8:35 AM

Wed, Jan 31

oren_ben_simhon updated the diff for D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

Implemented comments posted until 01/30 (Thanks Craig)

Wed, Jan 31, 1:32 AM

Tue, Jan 30

oren_ben_simhon updated the diff for D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.
Tue, Jan 30, 12:58 AM

Mon, Jan 29

oren_ben_simhon updated the diff for D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

Implemented comments posted until 01/28 (Thanks Craig)

Mon, Jan 29, 8:12 AM
oren_ben_simhon added a comment to D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

I will add "notrack" to X86 ASM Parser (and also add symbolic test)

Mon, Jan 29, 7:39 AM

Tue, Jan 23

oren_ben_simhon updated the diff for D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

Thanks Craig for your comments, i made the following changes:

  • I print notrack prefix instead of ds prefix
  • I used same mechanism as lock/rep and created unified SDNode for the prefix and the jmp/call
Tue, Jan 23, 7:48 AM

Jan 17 2018

oren_ben_simhon added a comment to D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.

Should we be printing the DS_PREFIX as "notrack" like gcc?

Jan 17 2018, 6:10 AM

Jan 14 2018

oren_ben_simhon added inline comments to D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.
Jan 14 2018, 3:56 AM

Jan 9 2018

oren_ben_simhon added a comment to D41329: [X86][CET]: Adding full coverage of MC encoding for the CET instructions.<NFC>.

I added encoding test in the following review:
https://reviews.llvm.org/D40223

Jan 9 2018, 1:14 PM
oren_ben_simhon created D41880: Adding nocf_check attribute for cf-protection fine tuning .
Jan 9 2018, 12:48 PM
oren_ben_simhon updated the summary of D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.
Jan 9 2018, 12:42 PM
oren_ben_simhon updated the summary of D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.
Jan 9 2018, 12:41 PM
oren_ben_simhon created D41879: [X86] Added support for nocf_check attribute for indirect Branch Tracking.
Jan 9 2018, 12:40 PM
oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Jan 9 2018, 7:38 AM
oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Jan 9 2018, 6:56 AM

Jan 4 2018

oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented comments posted until 01/04 (Thanks Craig)

Jan 4 2018, 1:08 AM

Dec 25 2017

oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Reverted clang-format whitespaces updates

Dec 25 2017, 6:42 AM
oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Implemented comments posted until 12/24 (Thanks Craig)

Dec 25 2017, 6:35 AM
oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented comments posted until 12/24 (Thanks Craig)
Moved cf-protection attributes from function attributes to module attributes.

Dec 25 2017, 6:33 AM
oren_ben_simhon added a comment to D40478: Added control flow architecture protection Flag.

Are we sure we want a different command line option name from gcc? From our internal conversations with the gcc folks I thought they were suggesting that -fcf-protection could imply a software mechanism if a hardware mechanism was not available thorugh -mibt or -march?

Should we emit an error to the user if -mibt isn't available? We should be able to add virtual methods on TargetInfo that X86 can customize to check for ibt and shstk.

Can you provide more information about the miscompile on MSVC? I think we should do more to understand that, this sounds like it could be a time bomb waiting to fail somewhere else.

Dec 25 2017, 6:28 AM

Dec 21 2017

oren_ben_simhon added a comment to D40478: Added control flow architecture protection Flag.

ping

Dec 21 2017, 12:00 AM
oren_ben_simhon added a comment to D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

ping

Dec 21 2017, 12:00 AM

Dec 19 2017

oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Updated attribute name

Dec 19 2017, 12:48 PM
oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented comments posted until 12/19 (Thanks Craig)

Dec 19 2017, 12:46 PM
oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Dec 19 2017, 12:44 PM

Dec 17 2017

oren_ben_simhon added a comment to D40478: Added control flow architecture protection Flag.

-mibt is currently in discussions with other compilers, any change will be uploaded to a different review.
If you have more comments i will appreciate it.

Dec 17 2017, 6:11 AM

Dec 14 2017

oren_ben_simhon retitled D40478: Added control flow architecture protection Flag from Added Instrument Control Flow Flag to Added control flow architecture protection Flag.
Dec 14 2017, 12:12 PM
oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented all comments posted until 12/14 (Thanks Peter)

Dec 14 2017, 12:12 PM
oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Implemented all comments posted until 12/14 (Thanks Peter).

Dec 14 2017, 12:06 PM

Dec 13 2017

oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Dec 13 2017, 6:02 AM
oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Implemented some of the comments posted until 12/12 (Thanks Peter)

Dec 13 2017, 5:52 AM
oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented some of the comments posted until 12/12 (Thanks Peter)

Dec 13 2017, 5:49 AM
oren_ben_simhon added a reviewer for D40478: Added control flow architecture protection Flag: DavidKreitzer.
Dec 13 2017, 1:37 AM
oren_ben_simhon added a reviewer for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking: DavidKreitzer.
Dec 13 2017, 1:36 AM

Dec 12 2017

oren_ben_simhon added a reviewer for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking: AndreiGrischenko.
Dec 12 2017, 3:16 AM
oren_ben_simhon added a reviewer for D40478: Added control flow architecture protection Flag: AndreiGrischenko.
Dec 12 2017, 3:16 AM
oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Dec 12 2017, 3:16 AM
oren_ben_simhon added inline comments to D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.
Dec 12 2017, 3:15 AM

Dec 7 2017

oren_ben_simhon added inline comments to D40478: Added control flow architecture protection Flag.
Dec 7 2017, 12:52 AM
oren_ben_simhon added inline comments to D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.
Dec 7 2017, 12:50 AM

Nov 30 2017

oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Implemented comments posted until 11/30 (Thank you Craig and Peter)

Nov 30 2017, 6:18 AM
oren_ben_simhon added inline comments to D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.
Nov 30 2017, 6:16 AM

Nov 29 2017

oren_ben_simhon updated the diff for D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.

Implemented comments posted till 11/29 (Thanks Craig)

Nov 29 2017, 7:49 AM
oren_ben_simhon updated the diff for D40478: Added control flow architecture protection Flag.

Implemented comments posted until 11/29 (Thanks Craig)

Nov 29 2017, 6:39 AM

Nov 27 2017

oren_ben_simhon created D40482: [X86] Instrument Control Flow For Indirect Branch Tracking.
Nov 27 2017, 3:19 AM
oren_ben_simhon created D40478: Added control flow architecture protection Flag.
Nov 27 2017, 12:51 AM

Nov 22 2017

oren_ben_simhon updated the diff for D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side).

Implemented comments posted until 11/21 (Thanks Craig)

Nov 22 2017, 7:00 AM
oren_ben_simhon updated the diff for D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side).

Implemented comments posted until 11/21 (Thanks Craig)

Nov 22 2017, 6:59 AM

Nov 21 2017

oren_ben_simhon updated the diff for D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side).

Removed redundant FeatureCET flag.

Nov 21 2017, 12:15 PM
oren_ben_simhon updated the diff for D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side).

Implemented comments posted until 11/20 (Thanks Craig and Erich).

Nov 21 2017, 12:13 PM
oren_ben_simhon added inline comments to D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side).
Nov 21 2017, 12:09 PM

Nov 20 2017

oren_ben_simhon updated the diff for D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side).

Implemented comments posted until 11/19 (Thanks Craig)

Nov 20 2017, 1:17 AM

Nov 19 2017

oren_ben_simhon created D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side).
Nov 19 2017, 5:29 AM
oren_ben_simhon created D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side).
Nov 19 2017, 5:15 AM

Oct 11 2017

oren_ben_simhon added a comment to D37885: [x86] Bring back the MOVZX64rr* pseudo instructions so that they can be coalesced using X86InstrInfo::isCoalescableExtInstr.

I imagine it would be possible, but we'd also need a new target hook to indicate that MOV32rr is coalescable. It just seemed easier to use the existing stuff rather than implement a second way to do it.

Oct 11 2017, 9:53 AM

Oct 10 2017

oren_ben_simhon added a comment to D37885: [x86] Bring back the MOVZX64rr* pseudo instructions so that they can be coalesced using X86InstrInfo::isCoalescableExtInstr.

Is it possible to change InstrEmitter/peephole pass to coalesce even in cases of SUBREG_TO_REG?

Oct 10 2017, 5:57 AM

Aug 3 2017

oren_ben_simhon accepted D36081: [X86] Improved X86::CMOV to Branch heuristic.

LGTM

Aug 3 2017, 7:23 AM

Jul 17 2017

oren_ben_simhon accepted D35466: [llvm] Remove redundant check-prefix=CHECK from tests. NFC..

LGTM

Jul 17 2017, 4:15 AM

Jul 16 2017

oren_ben_simhon accepted D34602: [GlobalISel][X86] Support call ABI..

LGTM

Jul 16 2017, 7:22 AM

Jul 11 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 11 2017, 3:55 AM

Jul 3 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 3 2017, 12:23 PM

Jul 2 2017

oren_ben_simhon added inline comments to D34602: [GlobalISel][X86] Support call ABI..
Jul 2 2017, 3:56 AM

May 25 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/25 (Thanks Simon and Craig)

May 25 2017, 2:07 AM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Any idea why phabricator is showing so many unchanged lines from X86InstrInfo.cpp? Have you changed the line endings or something? They aren't appearing in the the downloaded diff FWIW.

May 25 2017, 1:57 AM

May 24 2017

oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

I will appreciate any additional comments.
Please help me finish the review.

May 24 2017, 6:37 AM

May 21 2017

oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 21 2017, 3:34 AM
oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 21 2017, 3:32 AM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/20 (Thanks Craig)

May 21 2017, 12:06 AM

May 18 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Updated the tests (Thanks Simon)

May 18 2017, 12:47 AM

May 17 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Removed TB_NO_REVERSE flag (Thanks Simon)

May 17 2017, 7:09 AM
oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/16 (Thanks again Simon and Craig)

May 17 2017, 6:57 AM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

A possible addition would be to custom lower i8/i16 vectors with a trunc(popcnt(zext))) pattern.

I agree with you, Will it be OK to create a separate patch for it?

May 17 2017, 6:56 AM
oren_ben_simhon added inline comments to D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 17 2017, 5:41 AM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/16 (Thanks Craig)

May 17 2017, 5:41 AM

May 15 2017

oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Reverted clang-format for lib/Target/X86/X86InstrInfo.cpp and removed NoVLX predicate (Thanks Simon)

May 15 2017, 1:11 PM
oren_ben_simhon added inline comments to D33169: [X86] Adding vpopcntd and vpopcntq instructions.
May 15 2017, 12:52 PM
oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Implemented comments posted until 05/15 (Thanks Craig and Simon)

May 15 2017, 12:50 PM
oren_ben_simhon added a comment to D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Please notice that clang-format reformatted some lists that I modified in the file lib/Target/X86/X86InstrInfo.cpp.
It caused major cosmetic changes which introduce many diffs in that file.

May 15 2017, 12:44 PM
oren_ben_simhon updated the diff for D33169: [X86] Adding vpopcntd and vpopcntq instructions.

Implemented comments posted until 05/15 (Thanks Simon and Craig)

May 15 2017, 12:35 PM

May 14 2017

oren_ben_simhon updated the diff for D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.

Removed files properties

May 14 2017, 5:44 AM
oren_ben_simhon created D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics.
May 14 2017, 5:17 AM
oren_ben_simhon added a reviewer for D33169: [X86] Adding vpopcntd and vpopcntq instructions: m_zuckerman.
May 14 2017, 5:11 AM
oren_ben_simhon created D33169: [X86] Adding vpopcntd and vpopcntq instructions.
May 14 2017, 5:09 AM

May 3 2017

oren_ben_simhon updated the diff for D32430: [X86] Disabling PLT in Regcall CC Functions.

Added the fix to all SystemV ELF based operating systems (Thanks Rafael and David)

May 3 2017, 7:00 AM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Updated the tests.

May 3 2017, 5:17 AM
oren_ben_simhon updated the diff for D32697: Reusing an existing attribute diagnostic.

Implemented comments posted until 05/02 (Thanks Aaron)

May 3 2017, 12:13 AM

May 1 2017

oren_ben_simhon created D32697: Reusing an existing attribute diagnostic.
May 1 2017, 1:43 AM
oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/30 (Thanks Amjad)

May 1 2017, 12:10 AM
oren_ben_simhon added inline comments to D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.
May 1 2017, 12:03 AM

Apr 30 2017

oren_ben_simhon updated the diff for D32430: [X86] Disabling PLT in Regcall CC Functions.

Implemented comments posted until 04/30 (Thanks Amjad)

Apr 30 2017, 11:12 PM

Apr 27 2017

oren_ben_simhon updated the diff for D31876: [X86] Support of no_caller_saved_registers attribute (LLVM part) - restart.

Implemented comments posted until 04/28 (Thanks Amjad and Matthias)

Apr 27 2017, 2:19 PM