Page MenuHomePhabricator

oneraynyday (Ray Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2020, 10:03 PM (6 w, 2 d)

Recent Activity

Nov 1 2020

oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Retain (void) casts
  • Fix bug where we didn't realize ImplicitCastExpr is doing all of the cast in the CStyleCastExpr in clang
  • Typedef wrapping whenever possible
Nov 1 2020, 3:09 PM · Restricted Project, Restricted Project

Oct 20 2020

oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Wrong test name
Oct 20 2020, 9:05 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Windows tests doesn't classify the test case as a dependent cast
Oct 20 2020, 8:35 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Duplicated C-style cast removed (why is this failing in windows?)
  • Addressed clang-tidy
Oct 20 2020, 6:47 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Address clang-tidy warnings
Oct 20 2020, 3:47 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • It appears symlinks are directly copied over, here are the actual file contents
Oct 20 2020, 2:25 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Address clang-tidy
  • Address using C++17 left-fold expression in C++14
  • Address minor style issues
Oct 20 2020, 2:18 PM · Restricted Project, Restricted Project
oneraynyday added a comment to D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
Oct 20 2020, 1:53 PM · Restricted Project, Restricted Project
oneraynyday updated the summary of D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
Oct 20 2020, 12:54 AM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
  • Don't use C++17 features
Oct 20 2020, 12:26 AM · Restricted Project, Restricted Project
oneraynyday abandoned D89770: Don't use C++17 features.
Oct 20 2020, 12:24 AM · Restricted Project
oneraynyday updated the diff for D89770: Don't use C++17 features.

C++17 features cause buildkite to fail.

Oct 20 2020, 12:23 AM · Restricted Project
oneraynyday requested review of D89770: Don't use C++17 features.
Oct 20 2020, 12:20 AM · Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Reverting previous update

Oct 20 2020, 12:16 AM · Restricted Project, Restricted Project
oneraynyday added a comment to D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Hi there,

Oct 20 2020, 12:05 AM · Restricted Project, Restricted Project

Oct 19 2020

oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Don't use C++17 features as clang currently uses C++14.

Oct 19 2020, 11:53 PM · Restricted Project, Restricted Project
oneraynyday updated the summary of D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
Oct 19 2020, 11:22 PM · Restricted Project, Restricted Project
oneraynyday updated the diff for D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Updated description

Oct 19 2020, 11:08 PM · Restricted Project, Restricted Project
oneraynyday requested review of D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..
Oct 19 2020, 10:54 PM · Restricted Project, Restricted Project