Page MenuHomePhabricator

olga.chupina (Olga Chupina)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2017, 3:56 AM (118 w, 5 d)

Recent Activity

Apr 30 2019

olga.chupina added a comment to rL359609: [NFC][InlineCost] cleanup - comments, overflow handling..

There are also two appearances of "Cost -= ... ": one in the visitCallBase() and one in the updateThreshold().

Apr 30 2019, 4:46 PM
olga.chupina added inline comments to rL359609: [NFC][InlineCost] cleanup - comments, overflow handling..
Apr 30 2019, 4:23 PM

Jul 25 2018

olga.chupina added a comment to D49403: More aggressively complete RecordTypes with Function Pointers.

I should probably add one more example to explain my point of view.
Suppose we have an indirect call in the program and we need to know all possible goals for this indirect call. Then we would like to know that one of the structure fields is a function pointer and it can be a candidate for indirect call resolution.

Jul 25 2018, 9:24 AM

Jul 23 2018

olga.chupina added a comment to D49403: More aggressively complete RecordTypes with Function Pointers.

Yes, correct.

Jul 23 2018, 1:51 PM
olga.chupina added a comment to D49403: More aggressively complete RecordTypes with Function Pointers.

Since the structure field which is a function pointer appears in the assignment statement, it messes up the type analysis.
If it would really be a pointer to a structure then the corresponding assignment could be treated as bad type casting and potentially lead to unauthorized structure field access.

Jul 23 2018, 10:11 AM

Aug 7 2017

olga.chupina added a reviewer for D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default: hfinkel.

Adding Hal Finkel as he was the last person updating llvm/tools/clang/test/Frontend/optimization-remark-options.c

Aug 7 2017, 5:02 AM
olga.chupina added a comment to D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.

Please, review updated patch and tests. Thanks.

Aug 7 2017, 4:59 AM

Jul 24 2017

olga.chupina added a comment to D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.

Kindly ping.
Please, review updated patch and tests. Thanks.

Jul 24 2017, 11:59 PM

Jul 12 2017

olga.chupina requested review of D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.
Jul 12 2017, 10:36 PM
olga.chupina updated the diff for D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.

updated patch is attached.

Jul 12 2017, 9:23 AM
olga.chupina reopened D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.

Commit was reverted due to failing clang test.
After commit was reverted the test that was supposed to check my change was deleted from testing system.

Jul 12 2017, 9:20 AM

Jun 12 2017

olga.chupina created D34101: [ValueTracking] Enabling the patch 'an improvement for non-negative phi bits' by default.
Jun 12 2017, 3:55 AM