Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

okkwon (Okwan Kwon)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2022, 3:19 PM (93 w, 6 d)

Recent Activity

May 2 2023

okkwon added a comment to D149688: [mlir][linalg] check if a function has a body during detensorizing.

Submitted.

May 2 2023, 3:40 PM · Restricted Project, Restricted Project
okkwon committed rG0fac44d80715: [mlir][linalg] check if a function has a body during detensorizing (authored by okkwon).
[mlir][linalg] check if a function has a body during detensorizing
May 2 2023, 3:40 PM · Restricted Project, Restricted Project
okkwon closed D149688: [mlir][linalg] check if a function has a body during detensorizing.
May 2 2023, 3:39 PM · Restricted Project, Restricted Project
okkwon requested review of D149688: [mlir][linalg] check if a function has a body during detensorizing.
May 2 2023, 1:48 PM · Restricted Project, Restricted Project

Sep 14 2022

okkwon accepted D133879: [mlir][emacs] Enable loading bytecode files as text.

It works great. Thanks!

Sep 14 2022, 11:05 AM · Restricted Project, Restricted Project

Jun 22 2022

okkwon added inline comments to D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC).
Jun 22 2022, 4:52 PM · Restricted Project, Restricted Project
okkwon updated the diff for D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC).

Recover the missing r.

Jun 22 2022, 4:47 PM · Restricted Project, Restricted Project
okkwon added a comment to D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC).

Thanks for the review. BTW, how can I test the changes on the cmake and bazel files? I usually run "ninja check-mlir" for testing.

Jun 22 2022, 4:38 PM · Restricted Project, Restricted Project
okkwon updated the diff for D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC).
  • Expose hasOnlyScalarElementwiseOp as a global function.
  • Specify a dependency to FuncDialect in the CMake and Bazel files.
Jun 22 2022, 4:37 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC): mravishankar.
Jun 22 2022, 4:13 PM · Restricted Project, Restricted Project
okkwon requested review of D128398: [mlir][linalg] move isElementwise() to Linalg/Utils (NFC).
Jun 22 2022, 4:13 PM · Restricted Project, Restricted Project

Jun 15 2022

okkwon updated the diff for D127891: [mlir] add createPrintOpStatsPass() with explicit params.

Make the commit title more explicit.

Jun 15 2022, 12:09 PM · Restricted Project, Restricted Project
okkwon retitled D127891: [mlir] add createPrintOpStatsPass() with explicit params from [mlir] add createPrintOpStatsPass with explicit params to [mlir] add createPrintOpStatsPass() with explicit params.
Jun 15 2022, 12:07 PM · Restricted Project, Restricted Project
okkwon retitled D127891: [mlir] add createPrintOpStatsPass() with explicit params from [mlir] add a create function with explicit params to [mlir] add createPrintOpStatsPass with explicit params.
Jun 15 2022, 12:06 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D127891: [mlir] add createPrintOpStatsPass() with explicit params: mehdi_amini.
Jun 15 2022, 11:51 AM · Restricted Project, Restricted Project
okkwon added a reviewer for D127891: [mlir] add createPrintOpStatsPass() with explicit params: jpienaar.
Jun 15 2022, 11:51 AM · Restricted Project, Restricted Project
okkwon requested review of D127891: [mlir] add createPrintOpStatsPass() with explicit params.
Jun 15 2022, 11:50 AM · Restricted Project, Restricted Project
okkwon updated the diff for D127691: [mlir] add an option to print op stats in JSON.

rebase to fix a build error for bazel

Jun 15 2022, 9:01 AM · Restricted Project, Restricted Project

Jun 14 2022

okkwon updated the diff for D127691: [mlir] add an option to print op stats in JSON.

update the python pass manager test

Jun 14 2022, 2:34 PM · Restricted Project, Restricted Project
okkwon reopened D127691: [mlir] add an option to print op stats in JSON.

I reverted the commit because there is a test failure for the python pass manager. Looking into it.

Jun 14 2022, 2:10 PM · Restricted Project, Restricted Project

Jun 13 2022

okkwon added a comment to D127691: [mlir] add an option to print op stats in JSON.

The debian failure is caused by "OSError: [Errno 28] No space left on device".

Jun 13 2022, 4:45 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D127691: [mlir] add an option to print op stats in JSON: mravishankar.
Jun 13 2022, 2:11 PM · Restricted Project, Restricted Project
okkwon updated the diff for D127691: [mlir] add an option to print op stats in JSON.

Update to use a json object instead of an array

Jun 13 2022, 2:09 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D127691: [mlir] add an option to print op stats in JSON: mehdi_amini.
Jun 13 2022, 1:43 PM · Restricted Project, Restricted Project
okkwon requested review of D127691: [mlir] add an option to print op stats in JSON.
Jun 13 2022, 1:42 PM · Restricted Project, Restricted Project

Jun 9 2022

okkwon added a comment to D127449: [mlir] Support passing ostream as argument for the create function..

The build failed because there is no space available.

Jun 9 2022, 4:29 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D127449: [mlir] Support passing ostream as argument for the create function.: mravishankar.
Jun 9 2022, 3:18 PM · Restricted Project, Restricted Project
okkwon requested review of D127449: [mlir] Support passing ostream as argument for the create function..
Jun 9 2022, 3:17 PM · Restricted Project, Restricted Project

Jun 7 2022

okkwon added a comment to D127004: [mlir][vector] Allow unroll of vector.contract, vector.transfer_read/write in arbitrary order.

It would be nice if you don't mind reverting.

Jun 7 2022, 1:27 PM · Restricted Project, Restricted Project
okkwon added a comment to D127004: [mlir][vector] Allow unroll of vector.contract, vector.transfer_read/write in arbitrary order.

Hi, just for heads-up, this change caused many failures in IREE tests including compilation errors and accuracy errors.

Jun 7 2022, 11:55 AM · Restricted Project, Restricted Project

Apr 22 2022

okkwon committed rGee285faed2e8: [mlir] Do not bubble up extract slice when it is rank-reducing. (authored by okkwon).
[mlir] Do not bubble up extract slice when it is rank-reducing.
Apr 22 2022, 12:26 PM · Restricted Project, Restricted Project
okkwon closed D124283: [mlir] Does not bubble up extract slice when it is rank-reducing..
Apr 22 2022, 12:25 PM · Restricted Project, Restricted Project
okkwon added a comment to D124283: [mlir] Does not bubble up extract slice when it is rank-reducing..

Thanks Mahesh. Much cleaner!

Apr 22 2022, 12:18 PM · Restricted Project, Restricted Project
okkwon updated the diff for D124283: [mlir] Does not bubble up extract slice when it is rank-reducing..

address the comment

Apr 22 2022, 12:18 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D124283: [mlir] Does not bubble up extract slice when it is rank-reducing.: maheshkhanwalkar.
Apr 22 2022, 10:59 AM · Restricted Project, Restricted Project
okkwon requested review of D124283: [mlir] Does not bubble up extract slice when it is rank-reducing..
Apr 22 2022, 10:59 AM · Restricted Project, Restricted Project

Apr 20 2022

okkwon accepted D124145: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns..

LGTM. Thanks!

Apr 20 2022, 11:42 PM · Restricted Project, Restricted Project

Apr 13 2022

okkwon committed rG18a01527eab6: [mlir] Fix a typo to load lsp-mode correctly. (authored by okkwon).
[mlir] Fix a typo to load lsp-mode correctly.
Apr 13 2022, 5:05 PM · Restricted Project, Restricted Project
okkwon closed D123745: [mlir] Fix a typo to load lsp-mode correctly..
Apr 13 2022, 5:04 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D123745: [mlir] Fix a typo to load lsp-mode correctly.: tschuett.
Apr 13 2022, 5:03 PM · Restricted Project, Restricted Project
okkwon added a reviewer for D123745: [mlir] Fix a typo to load lsp-mode correctly.: mehdi_amini.
Apr 13 2022, 4:58 PM · Restricted Project, Restricted Project
okkwon requested review of D123745: [mlir] Fix a typo to load lsp-mode correctly..
Apr 13 2022, 4:57 PM · Restricted Project, Restricted Project

Apr 12 2022

okkwon added inline comments to D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
Apr 12 2022, 10:54 PM · Restricted Project, Restricted Project
okkwon added inline comments to D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
Apr 12 2022, 6:24 PM · Restricted Project, Restricted Project

Apr 8 2022

okkwon added a comment to D123153: [mlir][Linalg] Allow collapsing subset of the reassociations when fusing by collapsing..

Adding more comments.

Apr 8 2022, 3:59 PM · Restricted Project, Restricted Project

Apr 7 2022

okkwon accepted D123236: [mlir][Linalg] Split `populateElementwiseOpsFusionPatterns`..

Adding minor comments. LGTM.

Apr 7 2022, 4:45 PM · Restricted Project, Restricted Project

Apr 6 2022

okkwon added a comment to D123153: [mlir][Linalg] Allow collapsing subset of the reassociations when fusing by collapsing..

Adding more comments.

Apr 6 2022, 3:49 PM · Restricted Project, Restricted Project
okkwon edited reviewers for D123153: [mlir][Linalg] Allow collapsing subset of the reassociations when fusing by collapsing., added: okkwon; removed: okwank.
Apr 6 2022, 8:55 AM · Restricted Project, Restricted Project

Apr 5 2022

okkwon added a comment to D123153: [mlir][Linalg] Allow collapsing subset of the reassociations when fusing by collapsing..

I left a few comments mostly related to naming and comments. I will review the rest later.

Apr 5 2022, 7:41 PM · Restricted Project, Restricted Project

Mar 31 2022

okkwon committed rG65bdeddb1e5c: [mlir] Bubble up tensor.extract_slice above linalg operation (authored by okkwon).
[mlir] Bubble up tensor.extract_slice above linalg operation
Mar 31 2022, 9:58 AM · Restricted Project, Restricted Project
okkwon closed D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.
Mar 31 2022, 9:58 AM · Restricted Project, Restricted Project

Mar 30 2022

okkwon updated the diff for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Rebased onto origin/main

Mar 30 2022, 2:16 PM · Restricted Project, Restricted Project
okkwon added a comment to D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Thanks Tobias for the info. I believe if the padding is added as an optimization for vectorization. We need to make this transformation happens before it.
If we see more cases that need a fine control, we can add a control function to this pass. Thanks!

Mar 30 2022, 1:54 PM · Restricted Project, Restricted Project
okkwon updated the diff for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Revert an unnecessary change on a comment.

Mar 30 2022, 10:09 AM · Restricted Project, Restricted Project
okkwon added a comment to D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Thanks for the review! Addressed all the TODO items.

Mar 30 2022, 10:00 AM · Restricted Project, Restricted Project
okkwon updated the diff for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Address the comments

Mar 30 2022, 9:57 AM · Restricted Project, Restricted Project

Mar 29 2022

okkwon added a reviewer for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation: gysit.
Mar 29 2022, 2:57 PM · Restricted Project, Restricted Project

Mar 25 2022

okkwon added inline comments to D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.
Mar 25 2022, 9:51 AM · Restricted Project, Restricted Project
okkwon updated the diff for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.

Replace getAsValues with getValueOrCreateConstantIndexOp.

Mar 25 2022, 9:51 AM · Restricted Project, Restricted Project

Mar 24 2022

okkwon edited reviewers for D122437: [mlir] Bubble up tensor.extract_slice above linalg operation, added: mravishankar; removed: rriddle, aartbik.
Mar 24 2022, 2:48 PM · Restricted Project, Restricted Project
okkwon requested review of D122437: [mlir] Bubble up tensor.extract_slice above linalg operation.
Mar 24 2022, 2:44 PM · Restricted Project, Restricted Project

Mar 21 2022

okkwon abandoned D121416: [mlir] bubble up tensor.extract_slice above linalg op.

The plan is changed because

  1. I made a big code change to support matmul cases, and
  2. Mahesh pointed me to the tiling implementation, which works for any Linalg operations. I need to take a look at the code and understand how it works for all without any restrictions on the linalg operation, and
  3. Apply the same or similar approach to my implementation.
Mar 21 2022, 2:44 PM · Restricted Project, Restricted Project

Mar 18 2022

okkwon added inline comments to D121416: [mlir] bubble up tensor.extract_slice above linalg op.
Mar 18 2022, 10:05 AM · Restricted Project, Restricted Project
okkwon updated the diff for D121416: [mlir] bubble up tensor.extract_slice above linalg op.

Address Mahesh's comments

Mar 18 2022, 10:04 AM · Restricted Project, Restricted Project

Mar 17 2022

okkwon updated the diff for D121416: [mlir] bubble up tensor.extract_slice above linalg op.

merge and rebase

Mar 17 2022, 5:16 PM · Restricted Project, Restricted Project

Mar 16 2022

okkwon updated the diff for D121416: [mlir] bubble up tensor.extract_slice above linalg op.

check projected permutation for inputs

Mar 16 2022, 2:28 PM · Restricted Project, Restricted Project

Mar 15 2022

okkwon published D121416: [mlir] bubble up tensor.extract_slice above linalg op for review.
Mar 15 2022, 1:14 PM · Restricted Project, Restricted Project

Mar 4 2022

okkwon accepted D120968: [mlir][Linalg] Modify `InferStaticShapeOfOperands` to work on Linalg Ops..

LGTM. Thanks

Mar 4 2022, 11:12 AM · Restricted Project, Restricted Project

Feb 28 2022

okkwon committed rG4c901bf44719: [mlir] Match Arithmetic::ConstantOp and Tensor::ExtractSliceOp. (authored by okkwon).
[mlir] Match Arithmetic::ConstantOp and Tensor::ExtractSliceOp.
Feb 28 2022, 3:09 PM
okkwon closed D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..
Feb 28 2022, 3:09 PM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Fix the bazel build error and rewrite the commit message.

Feb 28 2022, 1:43 PM · Restricted Project
okkwon reopened D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Reopening: The push to origin/main caused a build break due to a cyclic header inclusion between Tensor.h and Transforms.h. The issue didn't occur in my local machine, but it broke the testing system.

Feb 28 2022, 11:20 AM · Restricted Project
okkwon committed rG4f5eb53e68b1: Revert "[mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp." (authored by okkwon).
Revert "[mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp."
Feb 28 2022, 11:14 AM
okkwon added a reverting change for rG3104994104f0: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp.: rG4f5eb53e68b1: Revert "[mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp.".
Feb 28 2022, 11:14 AM
okkwon closed D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Merged to origin/main.

Feb 28 2022, 9:48 AM · Restricted Project
okkwon committed rG3104994104f0: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp. (authored by okkwon).
[mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp.
Feb 28 2022, 9:48 AM

Feb 26 2022

okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Addressed Uday's comments.

Feb 26 2022, 1:51 PM · Restricted Project
okkwon added a comment to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Thanks Uday for the comments. Please take another look.

Feb 26 2022, 1:51 PM · Restricted Project

Feb 25 2022

okkwon added inline comments to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..
Feb 25 2022, 11:30 AM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Address Mahesh's comments

Feb 25 2022, 11:28 AM · Restricted Project
okkwon added a comment to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

The code is updated with the control function approach. Please take a look.

Feb 25 2022, 9:16 AM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Add control function support

Feb 25 2022, 9:11 AM · Restricted Project

Feb 22 2022

okkwon closed D119985: [mlir] Fold Tensor.extract_slice into a constant splat..

Merged into the LLVM main.

Feb 22 2022, 1:42 PM · Restricted Project
okkwon committed rGf79f430d4b26: Fold Tensor.extract_slice into a constant splat. (authored by okkwon).
Fold Tensor.extract_slice into a constant splat.
Feb 22 2022, 1:40 PM

Feb 18 2022

okkwon added inline comments to D119985: [mlir] Fold Tensor.extract_slice into a constant splat..
Feb 18 2022, 10:13 AM · Restricted Project
okkwon updated the diff for D119985: [mlir] Fold Tensor.extract_slice into a constant splat..

Introduce resizeSplat instead of using reshape since reshape is not suppposed
to change the number of elements.

Feb 18 2022, 10:12 AM · Restricted Project

Feb 16 2022

okkwon added a comment to D119985: [mlir] Fold Tensor.extract_slice into a constant splat..

There is already reshape(), but it didn't support a shape with a different number of element even for a splat type.
I relaxed the assert condition to allow a type with a different number of elements.

Feb 16 2022, 5:16 PM · Restricted Project
okkwon updated the diff for D119985: [mlir] Fold Tensor.extract_slice into a constant splat..

Support a different shape for reshape for a splat type.

Feb 16 2022, 5:14 PM · Restricted Project
okkwon added inline comments to D119985: [mlir] Fold Tensor.extract_slice into a constant splat..
Feb 16 2022, 4:49 PM · Restricted Project
okkwon updated the diff for D119985: [mlir] Fold Tensor.extract_slice into a constant splat..

Use the attribute operand instead of matching.

Feb 16 2022, 4:29 PM · Restricted Project
okkwon added a reviewer for D119985: [mlir] Fold Tensor.extract_slice into a constant splat.: mravishankar.
Feb 16 2022, 3:21 PM · Restricted Project
okkwon requested review of D119985: [mlir] Fold Tensor.extract_slice into a constant splat..
Feb 16 2022, 3:20 PM · Restricted Project

Feb 15 2022

okkwon added a comment to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Right. It does not handle the splat case yet.

Feb 15 2022, 9:49 PM · Restricted Project
okkwon added a comment to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

I have added two more unit tests.

Feb 15 2022, 4:04 PM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

add two more unit tests

Feb 15 2022, 3:59 PM · Restricted Project

Feb 14 2022

okkwon added inline comments to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..
Feb 14 2022, 6:55 PM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Fix a missing change for IterTy and ElemTy

Feb 14 2022, 3:45 PM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

rebase onto main

Feb 14 2022, 3:40 PM · Restricted Project
okkwon updated the diff for D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..

Resolve the patch error

Feb 14 2022, 3:30 PM · Restricted Project
okkwon added inline comments to D119605: [mlir] Fold Arithmetic::ConstantOp and Tensor::ExtractSliceOp..
Feb 14 2022, 3:28 PM · Restricted Project