Page MenuHomePhabricator
People oToToT

oToToT (Tommy Chiang)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2021, 8:43 PM (9 w, 1 d)

Recent Activity
View All

Wed, Apr 7

oToToT committed rGfc1117df5b87: [clang] Check AuxTarget exists when creating target in CompilerInstance (authored by oToToT).
[clang] Check AuxTarget exists when creating target in CompilerInstance
Wed, Apr 7, 6:01 AM
oToToT closed D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Wed, Apr 7, 6:01 AM · Restricted Project
oToToT updated the diff for D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..

Simply use !getAuxTarget() to check the existence of AuxTarget.

Wed, Apr 7, 4:28 AM · Restricted Project
oToToT added inline comments to D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Wed, Apr 7, 3:53 AM · Restricted Project
oToToT requested review of D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Wed, Apr 7, 12:52 AM · Restricted Project

Tue, Apr 6

oToToT committed rG14a7296c0120: [clang][clangd] Avoid inconsistent target creation (authored by oToToT).
[clang][clangd] Avoid inconsistent target creation
Tue, Apr 6, 8:25 AM
oToToT closed D98128: [clang][clangd] Avoid inconsistent target creation.
Tue, Apr 6, 8:24 AM · Restricted Project, Restricted Project

Fri, Apr 2

oToToT committed rGa89fb29398dc: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (authored by oToToT).
[clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType
Fri, Apr 2, 12:34 AM
oToToT closed D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Fri, Apr 2, 12:34 AM · Restricted Project

Thu, Apr 1

oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Remove redundant trailing spaces.

Thu, Apr 1, 4:18 PM · Restricted Project
oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Updated tests to check mangled type name.

Thu, Apr 1, 3:49 PM · Restricted Project

Tue, Mar 30

oToToT committed rG1363fb8ca6ce: [Docs] Update googletest docs link. (authored by oToToT).
[Docs] Update googletest docs link.
Tue, Mar 30, 8:25 AM
oToToT closed D99559: [Docs] Update googletest docs link.
Tue, Mar 30, 8:25 AM · Restricted Project
oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

After some investigation, I think it is quite hard to add tests to avoid inconsistency between clang and clangd. Maybe I could add some tests for CUDA, OpenMP if needed.

Tue, Mar 30, 6:35 AM · Restricted Project, Restricted Project

Mon, Mar 29

oToToT requested review of D99559: [Docs] Update googletest docs link.
Mon, Mar 29, 9:03 PM · Restricted Project

Sat, Mar 27

oToToT added inline comments to D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Sat, Mar 27, 3:46 AM · Restricted Project

Fri, Mar 26

oToToT added inline comments to D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Fri, Mar 26, 11:52 AM · Restricted Project
oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Remove redundant whitespace in comment.

Fri, Mar 26, 3:58 AM · Restricted Project
oToToT requested review of D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Fri, Mar 26, 3:32 AM · Restricted Project

Mon, Mar 22

oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

ping!

Mon, Mar 22, 1:16 AM · Restricted Project, Restricted Project

Wed, Mar 17

oToToT added a comment to D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h.

I found this patch occasionally, I think D98128 is what you need to solve this problem.

Wed, Mar 17, 12:52 AM · Restricted Project

Fri, Mar 12

oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

Kindly ping.

Fri, Mar 12, 6:01 AM · Restricted Project, Restricted Project

Mar 6 2021

oToToT updated the diff for D98128: [clang][clangd] Avoid inconsistent target creation.
Mar 6 2021, 1:33 PM · Restricted Project, Restricted Project
oToToT requested review of D98128: [clang][clangd] Avoid inconsistent target creation.
Mar 6 2021, 1:26 PM · Restricted Project, Restricted Project
oToToT abandoned D97561: [clang] Use CompilerInstance::createTarget to createTarget.

Since, originally, I think it is OK to submit patch just by project, but I agree that it's better to make patch as minimal as possible.
Thus, I will abandon this and resubmit another patch.
(I think reuploading patch and changing the whole patch logic here might not be great?)

Mar 6 2021, 1:11 PM · Restricted Project

Mar 1 2021

oToToT added a comment to D97561: [clang] Use CompilerInstance::createTarget to createTarget.

Kindly ping.

Mar 1 2021, 7:15 PM · Restricted Project

Feb 26 2021

oToToT added a reviewer for D97561: [clang] Use CompilerInstance::createTarget to createTarget: spyffe.
Feb 26 2021, 8:46 AM · Restricted Project
oToToT added inline comments to D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:45 AM · Restricted Project
oToToT updated the summary of D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:40 AM · Restricted Project
oToToT requested review of D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:40 AM · Restricted Project

Feb 25 2021

oToToT added a comment to D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.

Since I don't have commit access currently, might @sammccall commit this for me with --author="Yu-Hsun Chiang <ty1208chiang@gmail.com>"?

Feb 25 2021, 7:49 PM · Restricted Project
oToToT updated the diff for D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.

Fix typo and rename function to createTarget.

Feb 25 2021, 7:16 PM · Restricted Project
oToToT requested review of D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.
Feb 25 2021, 12:04 PM · Restricted Project

Feb 23 2021

oToToT abandoned D97109: [clangd] Add support for auxiliary triple specification.

Thanks sammccall for reviewing this and for the great idea of the whole plan.

Feb 23 2021, 8:29 AM · Restricted Project, Restricted Project

Feb 22 2021

oToToT edited reviewers for D97109: [clangd] Add support for auxiliary triple specification, added: jlebar, rsmith; removed: jdoerfert.
Feb 22 2021, 5:08 AM · Restricted Project, Restricted Project

Feb 20 2021

oToToT added inline comments to D97109: [clangd] Add support for auxiliary triple specification.
Feb 20 2021, 4:09 AM · Restricted Project, Restricted Project
oToToT updated the diff for D97109: [clangd] Add support for auxiliary triple specification.

re-upload diff with full context, sorry for that.

Feb 20 2021, 4:03 AM · Restricted Project, Restricted Project

Feb 19 2021

oToToT requested review of D97109: [clangd] Add support for auxiliary triple specification.
Feb 19 2021, 9:39 PM · Restricted Project, Restricted Project

Feb 5 2021

oToToT abandoned D96102: [clangd] Fix missing __syncthreads..

OK, I've found what's wrong with my fix here. I should check for the clangd compile mechanism with more detail to fix this problem.

Feb 5 2021, 10:36 AM · Restricted Project

Feb 4 2021

oToToT updated the diff for D96102: [clangd] Fix missing __syncthreads..

I guess __nvvm_bar_sync is the right instruction.

Feb 4 2021, 9:08 PM · Restricted Project
oToToT requested review of D96102: [clangd] Fix missing __syncthreads..
Feb 4 2021, 9:05 PM · Restricted Project