Page MenuHomePhabricator

oToToT (Tommy Chiang)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2021, 8:43 PM (95 w, 6 d)

Recent Activity

Oct 6 2022

oToToT committed rG87883740ebb3: [ASTMatchers][NFC] Fix wrong code ending command in documentation comments (authored by oToToT).
[ASTMatchers][NFC] Fix wrong code ending command in documentation comments
Oct 6 2022, 7:32 AM · Restricted Project, Restricted Project

Oct 5 2022

oToToT committed rG0da59bb8650a: [libc++] Fix wrong implementation of CityHash (authored by oToToT).
[libc++] Fix wrong implementation of CityHash
Oct 5 2022, 1:33 PM · Restricted Project, Restricted Project
oToToT closed D134124: [libc++] Fix wrong implementation of CityHash.
Oct 5 2022, 1:33 PM · Restricted Project, Restricted Project

Sep 22 2022

oToToT updated the diff for D134124: [libc++] Fix wrong implementation of CityHash.

Fix the endianess issue of the test.

Sep 22 2022, 12:12 PM · Restricted Project, Restricted Project

Sep 21 2022

oToToT added a comment to D134124: [libc++] Fix wrong implementation of CityHash.

Technically, changing the hash means that we'd violate http://eel.is/c++draft/hash.requirements#2

Sep 21 2022, 8:37 PM · Restricted Project, Restricted Project

Sep 19 2022

oToToT added a comment to D134124: [libc++] Fix wrong implementation of CityHash.

Besides using a new hash algorithm, would we want to upgrade our CityHash version to v1.1 [1]?
The v1.1 version claims to have a better hash quality. (I haven't test it though)
And, IIUC, upgrading to v1.1 wouldn't change the ABI.

Sep 19 2022, 7:41 PM · Restricted Project, Restricted Project
oToToT updated the diff for D134124: [libc++] Fix wrong implementation of CityHash.

Add basic test cases.

Sep 19 2022, 11:48 AM · Restricted Project, Restricted Project
oToToT added a comment to D134124: [libc++] Fix wrong implementation of CityHash.

I'm not familiar with this code, but I find it concerning that the change causes no tests to fail.

Sep 19 2022, 9:32 AM · Restricted Project, Restricted Project

Sep 18 2022

oToToT added a comment to D134124: [libc++] Fix wrong implementation of CityHash.

As mentioned in PR56606, CityHash seems not being actively maintained anymore.
Do we want to change our hash implementation to FarmHash or other hash functions?

Sep 18 2022, 12:19 AM · Restricted Project, Restricted Project
oToToT requested review of D134124: [libc++] Fix wrong implementation of CityHash.
Sep 18 2022, 12:12 AM · Restricted Project, Restricted Project

Jun 3 2022

oToToT committed rG8df2b1a86680: [pp-trace] Print HashLoc in InclusionDirective callback (authored by oToToT).
[pp-trace] Print HashLoc in InclusionDirective callback
Jun 3 2022, 4:30 AM · Restricted Project, Restricted Project
oToToT closed D125373: [pp-trace] Print HashLoc in InclusionDirective callback.
Jun 3 2022, 4:30 AM · Restricted Project, Restricted Project

Jun 2 2022

oToToT added a comment to D125373: [pp-trace] Print HashLoc in InclusionDirective callback.

Thanks for reviewing!
I will commit it myself later. :)

Jun 2 2022, 11:40 AM · Restricted Project, Restricted Project
oToToT updated the diff for D125373: [pp-trace] Print HashLoc in InclusionDirective callback.

Added a release note for the change.

Jun 2 2022, 5:34 AM · Restricted Project, Restricted Project
oToToT added a reviewer for D125373: [pp-trace] Print HashLoc in InclusionDirective callback: aaron.ballman.
Jun 2 2022, 2:42 AM · Restricted Project, Restricted Project

May 26 2022

oToToT added a comment to D125373: [pp-trace] Print HashLoc in InclusionDirective callback.

ping :)

May 26 2022, 5:42 PM · Restricted Project, Restricted Project

May 11 2022

oToToT requested review of D125373: [pp-trace] Print HashLoc in InclusionDirective callback.
May 11 2022, 4:21 AM · Restricted Project, Restricted Project
oToToT committed rGba7b6f46b37b: [docs][pp-trace] Remove FileNotFound callback (authored by oToToT).
[docs][pp-trace] Remove FileNotFound callback
May 11 2022, 3:15 AM · Restricted Project, Restricted Project
oToToT closed D125258: [docs][pp-trace] Remove FileNotFound callback.
May 11 2022, 3:14 AM · Restricted Project, Restricted Project

May 9 2022

oToToT requested review of D125258: [docs][pp-trace] Remove FileNotFound callback.
May 9 2022, 12:16 PM · Restricted Project, Restricted Project

Apr 28 2022

oToToT committed rG4a31af88a267: [MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo (authored by oToToT).
[MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo
Apr 28 2022, 1:55 PM · Restricted Project, Restricted Project
oToToT closed D124319: [MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo.
Apr 28 2022, 1:54 PM · Restricted Project, Restricted Project

Apr 27 2022

oToToT updated the diff for D124319: [MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo.

Fix typo

Apr 27 2022, 9:45 AM · Restricted Project, Restricted Project
oToToT added a comment to D124319: [MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo.

Is this good enough for https://github.com/llvm/llvm-project/issues/53956 or do we want to check whether FS contains +v8r?

Apr 27 2022, 9:42 AM · Restricted Project, Restricted Project

Apr 23 2022

oToToT requested review of D124319: [MC][AArch64] Enable '+v8a' when nothing specified for MCSubtargetInfo.
Apr 23 2022, 12:04 AM · Restricted Project, Restricted Project

Sep 6 2021

oToToT closed D108756: [clang] Add '-ast-dump-filter=' support.
Sep 6 2021, 7:54 PM · Restricted Project
oToToT committed rG95299019e35b: [clang] Add '-ast-dump-filter=' support (authored by oToToT).
[clang] Add '-ast-dump-filter=' support
Sep 6 2021, 7:43 PM

Sep 1 2021

oToToT added a comment to D108756: [clang] Add '-ast-dump-filter=' support.

ping

Sep 1 2021, 8:47 PM · Restricted Project

Aug 26 2021

oToToT requested review of D108756: [clang] Add '-ast-dump-filter=' support.
Aug 26 2021, 4:05 AM · Restricted Project

Jul 14 2021

oToToT committed rG56e6d4742e69: [docs] Update CMake cross compiling guide link (authored by oToToT).
[docs] Update CMake cross compiling guide link
Jul 14 2021, 6:22 AM
oToToT closed D104996: [docs] Update CMake cross compiling guide link..
Jul 14 2021, 6:22 AM · Restricted Project

Jul 13 2021

oToToT updated the diff for D104996: [docs] Update CMake cross compiling guide link..

add 'the' before section name

Jul 13 2021, 1:21 PM · Restricted Project
oToToT added a comment to D104996: [docs] Update CMake cross compiling guide link..

kindly ping

Jul 13 2021, 11:56 AM · Restricted Project

Jun 27 2021

oToToT requested review of D104996: [docs] Update CMake cross compiling guide link..
Jun 27 2021, 1:30 PM · Restricted Project

Apr 7 2021

oToToT committed rGfc1117df5b87: [clang] Check AuxTarget exists when creating target in CompilerInstance (authored by oToToT).
[clang] Check AuxTarget exists when creating target in CompilerInstance
Apr 7 2021, 6:01 AM
oToToT closed D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Apr 7 2021, 6:01 AM · Restricted Project
oToToT updated the diff for D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..

Simply use !getAuxTarget() to check the existence of AuxTarget.

Apr 7 2021, 4:28 AM · Restricted Project
oToToT added inline comments to D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Apr 7 2021, 3:53 AM · Restricted Project
oToToT requested review of D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance..
Apr 7 2021, 12:52 AM · Restricted Project

Apr 6 2021

oToToT committed rG14a7296c0120: [clang][clangd] Avoid inconsistent target creation (authored by oToToT).
[clang][clangd] Avoid inconsistent target creation
Apr 6 2021, 8:25 AM
oToToT closed D98128: [clang][clangd] Avoid inconsistent target creation.
Apr 6 2021, 8:24 AM · Restricted Project, Restricted Project

Apr 2 2021

oToToT committed rGa89fb29398dc: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (authored by oToToT).
[clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType
Apr 2 2021, 12:34 AM
oToToT closed D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Apr 2 2021, 12:34 AM · Restricted Project

Apr 1 2021

oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Remove redundant trailing spaces.

Apr 1 2021, 4:18 PM · Restricted Project
oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Updated tests to check mangled type name.

Apr 1 2021, 3:49 PM · Restricted Project

Mar 30 2021

oToToT committed rG1363fb8ca6ce: [Docs] Update googletest docs link. (authored by oToToT).
[Docs] Update googletest docs link.
Mar 30 2021, 8:25 AM
oToToT closed D99559: [Docs] Update googletest docs link.
Mar 30 2021, 8:25 AM · Restricted Project
oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

After some investigation, I think it is quite hard to add tests to avoid inconsistency between clang and clangd. Maybe I could add some tests for CUDA, OpenMP if needed.

Mar 30 2021, 6:35 AM · Restricted Project, Restricted Project

Mar 29 2021

oToToT requested review of D99559: [Docs] Update googletest docs link.
Mar 29 2021, 9:03 PM · Restricted Project

Mar 27 2021

oToToT added inline comments to D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Mar 27 2021, 3:46 AM · Restricted Project

Mar 26 2021

oToToT added inline comments to D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Mar 26 2021, 11:52 AM · Restricted Project
oToToT updated the diff for D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).

Remove redundant whitespace in comment.

Mar 26 2021, 3:58 AM · Restricted Project
oToToT requested review of D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478).
Mar 26 2021, 3:32 AM · Restricted Project

Mar 22 2021

oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

ping!

Mar 22 2021, 1:16 AM · Restricted Project, Restricted Project

Mar 17 2021

oToToT added a comment to D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h.

I found this patch occasionally, I think D98128 is what you need to solve this problem.

Mar 17 2021, 12:52 AM · Restricted Project

Mar 12 2021

oToToT added a comment to D98128: [clang][clangd] Avoid inconsistent target creation.

Kindly ping.

Mar 12 2021, 6:01 AM · Restricted Project, Restricted Project

Mar 6 2021

oToToT updated the diff for D98128: [clang][clangd] Avoid inconsistent target creation.
Mar 6 2021, 1:33 PM · Restricted Project, Restricted Project
oToToT requested review of D98128: [clang][clangd] Avoid inconsistent target creation.
Mar 6 2021, 1:26 PM · Restricted Project, Restricted Project
oToToT abandoned D97561: [clang] Use CompilerInstance::createTarget to createTarget.

Since, originally, I think it is OK to submit patch just by project, but I agree that it's better to make patch as minimal as possible.
Thus, I will abandon this and resubmit another patch.
(I think reuploading patch and changing the whole patch logic here might not be great?)

Mar 6 2021, 1:11 PM · Restricted Project

Mar 1 2021

oToToT added a comment to D97561: [clang] Use CompilerInstance::createTarget to createTarget.

Kindly ping.

Mar 1 2021, 7:15 PM · Restricted Project

Feb 26 2021

oToToT added a reviewer for D97561: [clang] Use CompilerInstance::createTarget to createTarget: spyffe.
Feb 26 2021, 8:46 AM · Restricted Project
oToToT added inline comments to D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:45 AM · Restricted Project
oToToT updated the summary of D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:40 AM · Restricted Project
oToToT requested review of D97561: [clang] Use CompilerInstance::createTarget to createTarget.
Feb 26 2021, 8:40 AM · Restricted Project

Feb 25 2021

oToToT added a comment to D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.

Since I don't have commit access currently, might @sammccall commit this for me with --author="Yu-Hsun Chiang <ty1208chiang@gmail.com>"?

Feb 25 2021, 7:49 PM · Restricted Project
oToToT updated the diff for D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.

Fix typo and rename function to createTarget.

Feb 25 2021, 7:16 PM · Restricted Project
oToToT requested review of D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function.
Feb 25 2021, 12:04 PM · Restricted Project

Feb 23 2021

oToToT abandoned D97109: [clangd] Add support for auxiliary triple specification.

Thanks sammccall for reviewing this and for the great idea of the whole plan.

Feb 23 2021, 8:29 AM · Restricted Project, Restricted Project

Feb 22 2021

oToToT edited reviewers for D97109: [clangd] Add support for auxiliary triple specification, added: jlebar, rsmith; removed: jdoerfert.
Feb 22 2021, 5:08 AM · Restricted Project, Restricted Project

Feb 20 2021

oToToT added inline comments to D97109: [clangd] Add support for auxiliary triple specification.
Feb 20 2021, 4:09 AM · Restricted Project, Restricted Project
oToToT updated the diff for D97109: [clangd] Add support for auxiliary triple specification.

re-upload diff with full context, sorry for that.

Feb 20 2021, 4:03 AM · Restricted Project, Restricted Project

Feb 19 2021

oToToT requested review of D97109: [clangd] Add support for auxiliary triple specification.
Feb 19 2021, 9:39 PM · Restricted Project, Restricted Project

Feb 5 2021

oToToT abandoned D96102: [clangd] Fix missing __syncthreads..

OK, I've found what's wrong with my fix here. I should check for the clangd compile mechanism with more detail to fix this problem.

Feb 5 2021, 10:36 AM · Restricted Project

Feb 4 2021

oToToT updated the diff for D96102: [clangd] Fix missing __syncthreads..

I guess __nvvm_bar_sync is the right instruction.

Feb 4 2021, 9:08 PM · Restricted Project
oToToT requested review of D96102: [clangd] Fix missing __syncthreads..
Feb 4 2021, 9:05 PM · Restricted Project