Page MenuHomePhabricator

npjdesres (Nick Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
May 6 2015, 7:57 AM (240 w, 22 h)

Recent Activity

Oct 3 2017

npjdesres added a comment to D35431: Extend FindAllMemoryUses for target intrinsics.

Thanks for the review. I do not have commit access. Could you please commit this? Thanks

Oct 3 2017, 10:52 AM

Jul 19 2017

npjdesres added a comment to D35437: Don't break bundles when adding DBG_VALUE.

Thank you so far, and sorry for the radio silence. I'll work on a testcase and revising this patch, but things just picked up in my office, so it may be next week.

Jul 19 2017, 6:58 AM

Jul 14 2017

npjdesres created D35437: Don't break bundles when adding DBG_VALUE.
Jul 14 2017, 1:19 PM
npjdesres created D35431: Extend FindAllMemoryUses for target intrinsics.
Jul 14 2017, 12:02 PM

Jun 21 2017

npjdesres added a comment to D34391: [RegisterCoalescer] Fix for SubRange join unreachable.

FYI I tried this patch in my out-of-tree backend (hoping to resolve http://llvm.org/PR32773). I observed a segfault SR.removeValNo(RmValNo) because RmValNo may be null.

Jun 21 2017, 9:10 AM

Jun 13 2017

npjdesres added a comment to D34041: [MIPS] BuildCondBr should preserve MO flags.

I do not have commit access, so if you could commit this I would appreciate it. Thank you.

Jun 13 2017, 6:33 AM

Jun 12 2017

npjdesres updated the diff for D34041: [MIPS] BuildCondBr should preserve MO flags.

Update to reflect reviews. Shorter testcase.

Jun 12 2017, 3:22 PM

Jun 8 2017

npjdesres updated the diff for D33947: No *reserved* physical registers in the VirtRegMap.

Remove superfluous ident metadata from testcase.

Jun 8 2017, 12:57 PM
npjdesres updated the diff for D33947: No *reserved* physical registers in the VirtRegMap.

Added testcase.

Jun 8 2017, 12:34 PM
npjdesres updated the diff for D34041: [MIPS] BuildCondBr should preserve MO flags.

Updated patch to include greater context.

Jun 8 2017, 10:21 AM
npjdesres created D34041: [MIPS] BuildCondBr should preserve MO flags.
Jun 8 2017, 9:55 AM
npjdesres updated the diff for D33947: No *reserved* physical registers in the VirtRegMap.

Updated the patch to clang-format style guidelines. Updated the test in MachineVerifier.

Jun 8 2017, 8:33 AM

Jun 6 2017

npjdesres added a comment to D33947: No *reserved* physical registers in the VirtRegMap.

I am addressing your comments. I might be able to make a mips testcase...

Jun 6 2017, 1:31 PM
npjdesres created D33947: No *reserved* physical registers in the VirtRegMap.
Jun 6 2017, 10:34 AM

Jun 5 2017

npjdesres added a comment to D33886: Reduce the size of output with -print-before/after-all by avoid duplicated dump.

This looks useful. One suggestion might be to change this diagnostic:

Jun 5 2017, 10:36 AM

Oct 7 2016

npjdesres added a comment to D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..

You are correct. I'm still waiting for someone/anyone with commit to put this in.

Oct 7 2016, 8:52 AM

May 11 2016

npjdesres added a comment to D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..

Ping. Can someone please commit this diff?

May 11 2016, 11:03 AM

Mar 28 2016

npjdesres added a comment to D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..

This patch has been approved but not yet committed. Is there anything else I need to do?

Mar 28 2016, 7:02 AM

Mar 18 2016

npjdesres added a comment to D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..

Thanks. I do not have commit access. Could you please commit it for me?

Mar 18 2016, 11:48 AM

Feb 25 2016

npjdesres added a comment to D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..

I should also mention that my target works fine in releases 3.5 and 3.6, but breaks now in 3.7. The critical difference was the introduction rewriteBuiltinFunctionDecl.

Feb 25 2016, 11:53 AM

Feb 24 2016

npjdesres updated subscribers of D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..
Feb 24 2016, 1:28 PM
npjdesres retitled D17577: rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand. from to rewriteBuiltinFunctionDecl incorrectly tests for address-space-qualified pointer operand..
Feb 24 2016, 11:20 AM

Nov 24 2015

npjdesres updated the diff for D14875: LiveVariables should not clobber MachineOperand::IsDead, ::IsKill on reserved physical registers.

Thanks for looking it over. Andy Trick agrees on the llvm-dev list.

Nov 24 2015, 6:45 AM

Nov 20 2015

npjdesres accepted D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

Sorry, I had forgotten about this diff.

Nov 20 2015, 8:58 AM
npjdesres retitled D14875: LiveVariables should not clobber MachineOperand::IsDead, ::IsKill on reserved physical registers from to LiveVariables should not clobber MachineOperand::IsDead, ::IsKill on reserved physical registers.
Nov 20 2015, 8:45 AM

May 14 2015

npjdesres updated the diff for D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

@dberlin: I'm unable to recreate your crash. However, I have a hunch that it pertains to aliases to global variables, rather than aliases to functions.

May 14 2015, 11:35 AM
npjdesres updated the diff for D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

@dberlin: your testcase demonstrates that a GlobalAlias may refer to any kind of ConstantExpr, whereas my previous patch incorrectly assumed that the aliasee must be an llvm::Function.

May 14 2015, 7:18 AM

May 13 2015

npjdesres added a comment to D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

I thought my updated diff #25062 fixed the all issues. Are there other issues?

May 13 2015, 2:24 PM
npjdesres added a comment to D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

How should I recruit an appropriate reviewer?

May 13 2015, 1:34 PM

May 6 2015

npjdesres updated the diff for D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .

LLVM style guidelines

May 6 2015, 10:07 AM
npjdesres changed the visibility for D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .
May 6 2015, 8:06 AM
npjdesres retitled D9529: Bug 20788 - bugpoint does not respect the "Alias must point to a definition" from to Bug 20788 - bugpoint does not respect the "Alias must point to a definition" .
May 6 2015, 8:05 AM