- User Since
- May 6 2015, 7:57 AM (240 w, 22 h)
Oct 3 2017
Thanks for the review. I do not have commit access. Could you please commit this? Thanks
Jul 19 2017
Thank you so far, and sorry for the radio silence. I'll work on a testcase and revising this patch, but things just picked up in my office, so it may be next week.
Jul 14 2017
Jun 21 2017
FYI I tried this patch in my out-of-tree backend (hoping to resolve http://llvm.org/PR32773). I observed a segfault SR.removeValNo(RmValNo) because RmValNo may be null.
Jun 13 2017
I do not have commit access, so if you could commit this I would appreciate it. Thank you.
Jun 12 2017
Update to reflect reviews. Shorter testcase.
Jun 8 2017
Remove superfluous ident metadata from testcase.
Updated patch to include greater context.
Updated the patch to clang-format style guidelines. Updated the test in MachineVerifier.
Jun 6 2017
I am addressing your comments. I might be able to make a mips testcase...
Jun 5 2017
This looks useful. One suggestion might be to change this diagnostic:
Oct 7 2016
You are correct. I'm still waiting for someone/anyone with commit to put this in.
May 11 2016
Ping. Can someone please commit this diff?
Mar 28 2016
This patch has been approved but not yet committed. Is there anything else I need to do?
Mar 18 2016
Thanks. I do not have commit access. Could you please commit it for me?
Feb 25 2016
I should also mention that my target works fine in releases 3.5 and 3.6, but breaks now in 3.7. The critical difference was the introduction rewriteBuiltinFunctionDecl.
Feb 24 2016
Nov 24 2015
Thanks for looking it over. Andy Trick agrees on the llvm-dev list.
Nov 20 2015
Sorry, I had forgotten about this diff.
May 14 2015
@dberlin: I'm unable to recreate your crash. However, I have a hunch that it pertains to aliases to global variables, rather than aliases to functions.
@dberlin: your testcase demonstrates that a GlobalAlias may refer to any kind of ConstantExpr, whereas my previous patch incorrectly assumed that the aliasee must be an llvm::Function.
May 13 2015
I thought my updated diff #25062 fixed the all issues. Are there other issues?
How should I recruit an appropriate reviewer?
May 6 2015
LLVM style guidelines