Page MenuHomePhabricator

npanchen (Nikolay Panchenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 4:24 PM (26 w, 1 d)

Recent Activity

Feb 4 2019

npanchen added inline comments to D57598: [VPLAN] Determine Vector Width programmatically..
Feb 4 2019, 6:05 PM · Restricted Project

Feb 1 2019

npanchen added inline comments to D57598: [VPLAN] Determine Vector Width programmatically..
Feb 1 2019, 4:08 PM · Restricted Project

Jan 22 2019

npanchen updated the diff for D53355: Introducing VPPHINode .
Jan 22 2019, 3:48 PM
npanchen added a comment to D53355: Introducing VPPHINode .

Hi Nikolay,

For what you describe, the patch looks good, ie. create a VPPHIInst. But it doesn't clearly show the benefits of doing so.

I can imagine that it would simplify reasoning and, as you say, avoid creating temporary instructions if not needed, but it would be good to have an example to base that claim.

Do you have the next patch somewhere? Would be good to put it in Phab, so we could look at it and make this review easier.

Thanks!
--renato

Jan 22 2019, 3:27 PM

Oct 16 2018

npanchen created D53355: Introducing VPPHINode .
Oct 16 2018, 7:05 PM