Page MenuHomePhabricator

nomanous (Chuyang Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2020, 1:05 AM (19 w, 5 d)

Recent Activity

Mon, Jan 18

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri

Mon, Jan 18, 3:25 AM · Restricted Project
nomanous added a reviewer for D90448: [clang] Add type check for explicit instantiation of static data members: lebedev.ri.
Mon, Jan 18, 3:23 AM · Restricted Project
nomanous set the repository for D90448: [clang] Add type check for explicit instantiation of static data members to rG LLVM Github Monorepo.
Mon, Jan 18, 2:54 AM · Restricted Project
nomanous updated the diff for D90448: [clang] Add type check for explicit instantiation of static data members.
Mon, Jan 18, 2:19 AM · Restricted Project

Sun, Jan 17

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

The tests failed though

Sun, Jan 17, 7:23 PM · Restricted Project

Fri, Jan 15

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

Tests missing

Fri, Jan 15, 5:41 AM · Restricted Project

Nov 24 2020

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

Ping @rsmith @dblaikie

Nov 24 2020, 8:42 PM · Restricted Project
nomanous edited reviewers for D90448: [clang] Add type check for explicit instantiation of static data members, added: MaskRay, haowei, Xiangling_L; removed: chandlerc, majnemer, aaron.ballman.
Nov 24 2020, 8:41 PM · Restricted Project

Nov 15 2020

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

Ping @rsmith @chandlerc @majnemer @aaron.ballman @dblaikie

Nov 15 2020, 10:03 PM · Restricted Project

Nov 8 2020

nomanous updated the diff for D90448: [clang] Add type check for explicit instantiation of static data members.

Some more format fixes.

Nov 8 2020, 8:49 PM · Restricted Project
nomanous updated the diff for D90448: [clang] Add type check for explicit instantiation of static data members.

Some format fixes.

Nov 8 2020, 5:15 AM · Restricted Project
nomanous updated the diff for D90448: [clang] Add type check for explicit instantiation of static data members.

In this update I delete some extra test code, move several comments and split the new type comparing code into a new function to make sure that the commonly used old type comparing function not affected by it.

Nov 8 2020, 5:12 AM · Restricted Project

Nov 6 2020

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

How's this compare to the similar checks for variable templates? Is there some code/checking we could share here?

Nov 6 2020, 3:55 AM · Restricted Project

Nov 5 2020

nomanous edited reviewers for D90448: [clang] Add type check for explicit instantiation of static data members, added: aaron.ballman, dblaikie; removed: lvoufo.
Nov 5 2020, 5:37 AM · Restricted Project

Nov 4 2020

nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

Ping @rsmith @chandlerc @majnemer @lvoufo

Nov 4 2020, 7:25 PM · Restricted Project

Oct 30 2020

nomanous updated the summary of D90448: [clang] Add type check for explicit instantiation of static data members.
Oct 30 2020, 11:11 PM · Restricted Project
nomanous added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.
Oct 30 2020, 10:20 PM · Restricted Project
nomanous updated the diff for D90448: [clang] Add type check for explicit instantiation of static data members.

Change some format.

Oct 30 2020, 6:22 AM · Restricted Project
nomanous requested review of D90448: [clang] Add type check for explicit instantiation of static data members.
Oct 30 2020, 2:36 AM · Restricted Project

Oct 5 2020

nomanous added a comment to D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

LGTM! Do you need someone to commit on your behalf?

Oct 5 2020, 7:54 PM · Restricted Project
nomanous updated the diff for D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

In this revision I delete the useless main function in the new test case and rename ext_multichar_character_literal & ext_four_char_character_literal to warn_multichar_character_literal & warn_four_char_character_literal.

Oct 5 2020, 2:00 AM · Restricted Project

Oct 2 2020

nomanous updated the diff for D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

I restore some needless modification in the previous patch.

Oct 2 2020, 2:35 AM · Restricted Project
nomanous updated the diff for D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

I change the four-char constants back to "Warning" in this revision, but set it to be ignored by default.

Oct 2 2020, 2:25 AM · Restricted Project

Oct 1 2020

nomanous updated the diff for D87962: [clang] Change the multi-character character constants from extension to implementation-defined..
Oct 1 2020, 6:54 AM · Restricted Project
nomanous added a comment to D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

Multichar literals are implementation-defined in C and conditionally supported with implementation-defined semantics in C++. I agree that it may make sense to warn about their use for portability reasons, but I'm not certain whether it makes sense to promote their use to be always-on diagnostics. I'm curious to know if this change causes any issues with system headers (which may or may not still define four char codes) or popular libraries.

I was curious as to why this was an extension in the first place and found the original commits (https://github.com/llvm/llvm-project/commit/74c95e20af4838152a63010292d1063835176711 and https://github.com/llvm/llvm-project/commit/8577f62622d50183c7413d7507ec783d3c1486fc) but there's no justification as to why this was picked as an extension.

Oct 1 2020, 1:13 AM · Restricted Project

Sep 27 2020

nomanous added a comment to D87962: [clang] Change the multi-character character constants from extension to implementation-defined..

Ping @rsmith

Sep 27 2020, 11:52 PM · Restricted Project

Sep 19 2020

nomanous requested review of D87962: [clang] Change the multi-character character constants from extension to implementation-defined..
Sep 19 2020, 4:12 AM · Restricted Project