Page MenuHomePhabricator

nlguillemot (Nicolas Guillemot)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2019, 10:24 AM (31 w, 3 d)

Recent Activity

Mon, Jan 6

nlguillemot added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

How about the following commit message:

(...)

Mon, Jan 6, 9:27 AM · Restricted Project

Nov 21 2019

nlguillemot added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

Not committing to remove the ability to call match/sub on an invalid regex implies that the addition of the new API needs to be justified independently of the extra check that needs to be performed in match/sub to allow the current behaviour. And in fact, the only motivation for this patch I could think of was consistency with other languages and I was finding it a hard sell and was about to apologise for the extra work I made you do.

However I overlooked one benefit of removing the ability to match an invalid regex: robustness. All the cases where a call to match/sub is guards a code other than throwing an error is likely to result in wrong behaviour in case the regex is invalid. So I think it would be safer to use a separate API for combined regex creation + match/sub as per the previous revision of this patch and prevent the existing approach, so that users are mindful when not doing separate checks.

What do you think? If you agree that would mean reverting to the previous version of this patch and the simultaneous apologies from me for requesting the current version.

Nov 21 2019, 9:25 AM · Restricted Project

Nov 19 2019

nlguillemot added a comment to D68155: [clang][NFC] Make various uses of Regex const.

My sincere apologies, I forgot to change the author in the commit. I don't often commit on behalf of others so didn't think enough.

Nov 19 2019, 10:06 AM · Restricted Project
nlguillemot updated the summary of D68054: Regex: Add static convenience functions for "match" and "sub".
Nov 19 2019, 10:06 AM · Restricted Project
nlguillemot added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

Removed the assert inside match() that made it crash when match() is called with a regex pattern that isn't successfully compiled. Also removed the "death test" unit tests that tested that this assert was triggering.

Can you reword the description along the line of this new API being a convenience when one does not care about distinguishing validity of a regex from whether it matches?

Nov 19 2019, 10:06 AM · Restricted Project

Nov 18 2019

nlguillemot updated the diff for D68054: Regex: Add static convenience functions for "match" and "sub".

Removed the assert inside match() that made it crash when match() is called with a regex pattern that isn't successfully compiled. Also removed the "death test" unit tests that tested that this assert was triggering.

Nov 18 2019, 4:11 PM · Restricted Project

Sep 27 2019

nlguillemot added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

Opened a review that just increases the const-correctness of Regex in clang: https://reviews.llvm.org/D68155

Sep 27 2019, 12:17 PM · Restricted Project
nlguillemot created D68155: [clang][NFC] Make various uses of Regex const.
Sep 27 2019, 12:17 PM · Restricted Project
nlguillemot added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

The following clang unit tests fail with your patch:

Format/./FormatTests/FormatTest.FunctionAnnotations
Format/./FormatTests/FormatTest.UnderstandsFunctionRefQualification

Can you have a look?

Sep 27 2019, 11:09 AM · Restricted Project

Sep 26 2019

nlguillemot added inline comments to D68054: Regex: Add static convenience functions for "match" and "sub".
Sep 26 2019, 10:35 AM · Restricted Project
nlguillemot created D68091: [sancov][NFC] Make filename Regexes "const".
Sep 26 2019, 10:35 AM · Restricted Project
nlguillemot added inline comments to D68054: Regex: Add static convenience functions for "match" and "sub".
Sep 26 2019, 10:15 AM · Restricted Project
nlguillemot updated the diff for D68054: Regex: Add static convenience functions for "match" and "sub".
  • Added more comments to static match and static sub to clarify the return value and the error's value.
  • Remove updates of "static Regex" -> "static const Regex", to do them in a future separate patch instead.
  • Switch order of test lines in "ConvenienceFunctions" test.
Sep 26 2019, 10:15 AM · Restricted Project

Sep 25 2019

nlguillemot added inline comments to D68054: Regex: Add static convenience functions for "match" and "sub".
Sep 25 2019, 2:50 PM · Restricted Project
nlguillemot created D68054: Regex: Add static convenience functions for "match" and "sub".
Sep 25 2019, 2:41 PM · Restricted Project

Sep 23 2019

nlguillemot added a comment to D67241: Regex: Make "match" and "sub" const member functions.

friendly reminder ping

My bad, I misunderstood you and thought you'd do a patch to implement the "Create a Regex and immediately throw it away" idiom and rebase that one on top of it.

Sep 23 2019, 4:07 PM · Restricted Project
nlguillemot added a comment to D67241: Regex: Make "match" and "sub" const member functions.

friendly reminder ping

Sep 23 2019, 9:22 AM · Restricted Project

Sep 18 2019

nlguillemot updated the diff for D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.

Refactored loop over the list of vectors to avoid the tricky array/pointer loops.

Sep 18 2019, 1:51 PM · Restricted Project
nlguillemot added inline comments to D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.
Sep 18 2019, 1:01 PM · Restricted Project
nlguillemot added a reviewer for D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses: bogner.
Sep 18 2019, 11:40 AM · Restricted Project
nlguillemot added a reviewer for D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses: dsanders.
Sep 18 2019, 10:17 AM · Restricted Project

Sep 11 2019

nlguillemot added a reviewer for D67241: Regex: Make "match" and "sub" const member functions: thopre.
Sep 11 2019, 9:15 AM · Restricted Project

Sep 10 2019

nlguillemot added inline comments to D67241: Regex: Make "match" and "sub" const member functions.
Sep 10 2019, 1:30 PM · Restricted Project

Sep 6 2019

nlguillemot added inline comments to D67241: Regex: Make "match" and "sub" const member functions.
Sep 6 2019, 2:50 PM · Restricted Project
nlguillemot updated the diff for D67241: Regex: Make "match" and "sub" const member functions.

Added note in the comments for match and sub to explicitly note that the Error string is cleared when there is no error.

Sep 6 2019, 9:49 AM · Restricted Project
nlguillemot added inline comments to D67241: Regex: Make "match" and "sub" const member functions.
Sep 6 2019, 9:42 AM · Restricted Project

Sep 5 2019

nlguillemot created D67241: Regex: Make "match" and "sub" const member functions.
Sep 5 2019, 2:59 PM · Restricted Project

Aug 26 2019

nlguillemot added a reviewer for D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses: ab.
Aug 26 2019, 4:22 PM · Restricted Project
nlguillemot created D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.
Aug 26 2019, 4:19 PM · Restricted Project

Aug 16 2019

nlguillemot created D66369: [TableGen] Make MCInst decoding more table-driven.
Aug 16 2019, 4:03 PM · Restricted Project

Aug 9 2019

nlguillemot updated the summary of D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Aug 9 2019, 10:27 AM · Restricted Project
nlguillemot added a comment to D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.

I don't have commit privileges yet. Could somebody commit this for me?

Aug 9 2019, 9:06 AM · Restricted Project

Aug 1 2019

nlguillemot added inline comments to D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Aug 1 2019, 1:18 PM · Restricted Project

Jul 19 2019

nlguillemot added inline comments to D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Jul 19 2019, 9:11 AM · Restricted Project

Jul 18 2019

nlguillemot added inline comments to D63374: [TableGen] Add "MCInstValidatorEmitter" TableGen backend.
Jul 18 2019, 10:15 AM

Jul 16 2019

nlguillemot added a comment to D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.

Could somebody do the commit for me? I don’t have commit access yet.

Jul 16 2019, 2:44 PM · Restricted Project

Jul 9 2019

nlguillemot added a comment to D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.

ping

Jul 9 2019, 9:12 AM · Restricted Project
nlguillemot added a comment to D63374: [TableGen] Add "MCInstValidatorEmitter" TableGen backend.

ping

Jul 9 2019, 9:12 AM
nlguillemot added a comment to D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.

ping

Jul 9 2019, 9:12 AM · Restricted Project

Jun 25 2019

nlguillemot added a reviewer for D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods: fhahn.
Jun 25 2019, 11:01 AM · Restricted Project

Jun 24 2019

nlguillemot created D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Jun 24 2019, 3:14 PM · Restricted Project

Jun 18 2019

nlguillemot added a comment to D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.

Can the enum be used without this? I'm trying to understand why the enum was there to begin with. Only one in tree target, AVR, defines GET_INSTRINFO_OPERAND_TYPES_ENUM. Its not built by default so I could't really check, but looking through the file that included it, I couldn't prove it was being used.

Jun 18 2019, 3:38 PM · Restricted Project
nlguillemot updated the diff for D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.

some syntax nits:
OpcodeOperandTypes [] -> OpcodeOperandTypes[] (removed unnecessary space)
OS << "-1"; -> OS << -1; (don't use string where not necessary

Jun 18 2019, 2:20 PM · Restricted Project

Jun 15 2019

nlguillemot created D63374: [TableGen] Add "MCInstValidatorEmitter" TableGen backend.
Jun 15 2019, 1:19 AM

Jun 14 2019

nlguillemot updated the diff for D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
  • Fix some syntax mistakes.
  • Map only records that derive from Operand and are not anonymous. This exactly matches the condition used to generate GET_INSTRINFO_OPERAND_TYPES_ENUM.
Jun 14 2019, 10:04 AM · Restricted Project
nlguillemot added a reviewer for D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx: ab.
Jun 14 2019, 9:06 AM · Restricted Project
nlguillemot created D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
Jun 14 2019, 12:50 AM · Restricted Project

Jun 11 2019

Herald added a project to D52369: [tblgen][disasm] Allow multiple encodings to disassemble to the same instruction: Restricted Project.
Jun 11 2019, 11:15 AM · Restricted Project