Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People nirvedhmeshram

nirvedhmeshram (Nirvedh Meshram)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 3 2022, 1:48 PM (94 w, 5 d)

Recent Activity
View All

Jun 22 2023

nirvedhmeshram added inline comments to D153477: [NVPTX] Correctly lower extending loads for fp16 vectors..
Jun 22 2023, 10:10 AM · Restricted Project, Restricted Project

Jun 21 2023

nirvedhmeshram added inline comments to D153477: [NVPTX] Correctly lower extending loads for fp16 vectors..
Jun 21 2023, 4:39 PM · Restricted Project, Restricted Project

May 3 2023

nirvedhmeshram accepted D148965: [mlir][GPU] Allow specifying alignment of memory attributions.
May 3 2023, 10:44 AM · Restricted Project, Unknown Object (Project)
nirvedhmeshram accepted D148724: [mlir][AMDGPU] Add emulation pass for atomics on AMDGPU targets.
May 3 2023, 10:37 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram accepted D148722: [mlir][AMDGPU] Define atomic compare-and-swap for raw buffers.
May 3 2023, 9:40 AM · Unknown Object (Project), Restricted Project

Nov 18 2022

nirvedhmeshram added inline comments to D138146: [mlir][AMDGPU] Remove buffer ops that are statically out of bounds.
Nov 18 2022, 2:02 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram accepted D138146: [mlir][AMDGPU] Remove buffer ops that are statically out of bounds.

LGTM! just some minor nits.

Nov 18 2022, 2:00 PM · Restricted Project, Unknown Object (Project)

Oct 22 2022

nirvedhmeshram committed rGc44107066550: [mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix (authored by nirvedhmeshram).
[mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix
Oct 22 2022, 6:32 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D136521: [mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix.
Oct 22 2022, 6:32 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram updated the diff for D136521: [mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix.
Oct 22 2022, 6:19 AM · Restricted Project, Unknown Object (Project)

Oct 21 2022

nirvedhmeshram updated the diff for D136521: [mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix.
Oct 21 2022, 9:14 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram requested review of D136521: [mlir][spirv] Add conversion from GPU WMMA ops to SPIRV Cooperative matrix.
Oct 21 2022, 9:07 PM · Restricted Project, Unknown Object (Project)

Sep 29 2022

nirvedhmeshram committed rGd6de6dde8245: [mlir][spirv] Handle dynamic/static cases differntly for kernel capability (authored by nirvedhmeshram).
[mlir][spirv] Handle dynamic/static cases differntly for kernel capability
Sep 29 2022, 7:35 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D134908: [mlir][spirv] Handle dynamic/static cases differntly for kernel capability.
Sep 29 2022, 7:35 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D134908: [mlir][spirv] Handle dynamic/static cases differntly for kernel capability.
Sep 29 2022, 7:17 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D134908: [mlir][spirv] Handle dynamic/static cases differntly for kernel capability.
Sep 29 2022, 7:13 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram requested review of D134908: [mlir][spirv] Handle dynamic/static cases differntly for kernel capability.
Sep 29 2022, 2:17 PM · Unknown Object (Project), Restricted Project

Sep 20 2022

nirvedhmeshram committed rG7f19e59a6e4c: [mlir][spirv] Add casting ops to/from generic storage space (authored by nirvedhmeshram).
[mlir][spirv] Add casting ops to/from generic storage space
Sep 20 2022, 2:59 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D134217: [mlir][spirv] Add casting ops to/from generic storage space.
Sep 20 2022, 2:59 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram added inline comments to D134217: [mlir][spirv] Add casting ops to/from generic storage space.
Sep 20 2022, 2:03 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram updated the diff for D134217: [mlir][spirv] Add casting ops to/from generic storage space.
Sep 20 2022, 2:01 PM · Restricted Project, Unknown Object (Project)

Sep 19 2022

nirvedhmeshram requested review of D134217: [mlir][spirv] Add casting ops to/from generic storage space.
Sep 19 2022, 1:03 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram committed rG8a5c7e36c0ab: [mlir][spirv] fix ordering in Intel joint matrix ops (authored by nirvedhmeshram).
[mlir][spirv] fix ordering in Intel joint matrix ops
Sep 19 2022, 11:10 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D134069: [mlir][spirv] fix ordering in Intel joint matrix ops.
Sep 19 2022, 11:10 AM · Unknown Object (Project), Restricted Project

Sep 16 2022

nirvedhmeshram updated the summary of D134069: [mlir][spirv] fix ordering in Intel joint matrix ops.
Sep 16 2022, 1:02 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram requested review of D134069: [mlir][spirv] fix ordering in Intel joint matrix ops.
Sep 16 2022, 12:53 PM · Unknown Object (Project), Restricted Project

Aug 31 2022

nirvedhmeshram accepted D132956: [mlir][AMDGPU] Define amdgpu.mfma operator.
Aug 31 2022, 11:40 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram added inline comments to D132956: [mlir][AMDGPU] Define amdgpu.mfma operator.
Aug 31 2022, 1:29 AM · Unknown Object (Project), Restricted Project

Aug 17 2022

nirvedhmeshram committed rG6b8952554cd7: [mlir][spirv] Modify intel joint matrix ops (authored by nirvedhmeshram).
[mlir][spirv] Modify intel joint matrix ops
Aug 17 2022, 11:42 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D132039: [mlir][spirv] Modify intel joint matrix ops.
Aug 17 2022, 11:42 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram requested review of D132039: [mlir][spirv] Modify intel joint matrix ops.
Aug 17 2022, 10:04 AM · Unknown Object (Project), Restricted Project

Aug 15 2022

nirvedhmeshram committed rGb8f62dc22a93: [MLIR][SPIRV] Add intel joint matrix ops (authored by nirvedhmeshram).
[MLIR][SPIRV] Add intel joint matrix ops
Aug 15 2022, 4:52 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 15 2022, 4:52 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram added a comment to D131586: [MLIR][SPIRV] Add intel joint matrix ops.
In D131586#3724518, @antiagainst wrote:

Awesome! Do you have write access to llvm repo? Do you need me to land it?

Aug 15 2022, 3:11 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 15 2022, 3:01 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 15 2022, 1:07 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 15 2022, 1:02 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram added inline comments to D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 15 2022, 12:58 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D131586: [MLIR][SPIRV] Add intel joint matrix ops.

Addressing reviewer comments

Aug 15 2022, 12:52 PM · Unknown Object (Project), Restricted Project

Aug 10 2022

nirvedhmeshram requested review of D131586: [MLIR][SPIRV] Add intel joint matrix ops.
Aug 10 2022, 9:02 AM · Unknown Object (Project), Restricted Project

Jul 14 2022

nirvedhmeshram accepted D129522: [mlir][AMDGPU] Add lds_barrier op.
Jul 14 2022, 9:21 AM · Unknown Object (Project), Restricted Project

Jul 13 2022

nirvedhmeshram added inline comments to D129522: [mlir][AMDGPU] Add lds_barrier op.
Jul 13 2022, 2:22 PM · Unknown Object (Project), Restricted Project

Jul 12 2022

nirvedhmeshram added inline comments to D129522: [mlir][AMDGPU] Add lds_barrier op.
Jul 12 2022, 8:15 AM · Unknown Object (Project), Restricted Project

Jul 11 2022

nirvedhmeshram committed rG4dc8cf3a8686: Fix an issue with grouped conv2d op (authored by gpetters94).
Fix an issue with grouped conv2d op
Jul 11 2022, 1:14 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D128880: Bugfix for grouped convolution op.
Jul 11 2022, 1:13 PM · Restricted Project, Unknown Object (Project)
nirvedhmeshram added a reverting change for rG45ef20ca71aa: Fix an issue with grouped conv2d op: rGf0cd53898505: Revert "Fix an issue with grouped conv2d op".
Jul 11 2022, 1:10 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram committed rGf0cd53898505: Revert "Fix an issue with grouped conv2d op" (authored by nirvedhmeshram).
Revert "Fix an issue with grouped conv2d op"
Jul 11 2022, 1:10 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram committed rG45ef20ca71aa: Fix an issue with grouped conv2d op (authored by gpetters94).
Fix an issue with grouped conv2d op
Jul 11 2022, 1:00 PM · Unknown Object (Project), Restricted Project

May 6 2022

nirvedhmeshram accepted D124533: [mlir][NvGpu] Fix nvgpu.mma.sync lowering to NVVM for f32, tf32 types.

LGTM

May 6 2022, 2:12 PM · Unknown Object (Project), Restricted Project

May 4 2022

nirvedhmeshram accepted D124975: [mlir][nvvm] Fix support for tf32 data type in mma.sync.
May 4 2022, 7:45 PM · Unknown Object (Project), Restricted Project

May 2 2022

nirvedhmeshram added inline comments to D122940: [MLIR][GPU] Add NvGpu mma.sync path to the VectorToGPU pass.
May 2 2022, 2:11 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram added inline comments to D122940: [MLIR][GPU] Add NvGpu mma.sync path to the VectorToGPU pass.
May 2 2022, 1:46 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram added inline comments to D122940: [MLIR][GPU] Add NvGpu mma.sync path to the VectorToGPU pass.
May 2 2022, 1:22 PM · Unknown Object (Project), Restricted Project

Apr 21 2022

Herald added a project to D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions: Restricted Project.

Hello, I was interested in using llvm.nvvm.cp.async.cg.shared.global.8 and llvm.nvvm.cp.async.cg.shared.global.4 and was wondering if there is some fundamental reason they were not added here. I only see the ca variants for these.

Apr 21 2022, 5:54 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

nirvedhmeshram accepted D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

LGTM for my comments.

Apr 13 2022, 6:45 AM · Restricted Project, Unknown Object (Project)

Apr 12 2022

nirvedhmeshram requested changes to D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
Apr 12 2022, 4:58 PM · Restricted Project, Unknown Object (Project)

Apr 5 2022

nirvedhmeshram committed rG01055ed1d72d: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern from… (authored by nirvedhmeshram).
[mlir][linalg] Move linalg.fill folding into linalg.generic pattern from…
Apr 5 2022, 1:13 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram closed D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.
Apr 5 2022, 1:13 PM · Unknown Object (Project), Restricted Project

Apr 4 2022

nirvedhmeshram updated the diff for D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.
Apr 4 2022, 11:52 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.

There was a bug that was found by @benvanik in the folding pattern where it would trigger infinitely if the fill already did not have a use in the generic op.
Fixing that in this revision. With this change also dead args get dropped automatically with the transform pattern because it calls canonicalization within the pass. The fact that this was not happening initially was due to this bug.

Apr 4 2022, 9:07 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.

Addressing reviewer comments and rebase

Apr 4 2022, 8:16 AM · Unknown Object (Project), Restricted Project

Apr 1 2022

nirvedhmeshram added inline comments to D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.
Apr 1 2022, 7:46 AM · Unknown Object (Project), Restricted Project
nirvedhmeshram updated the diff for D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.

Addressing reviewer comments

Apr 1 2022, 7:44 AM · Unknown Object (Project), Restricted Project

Mar 31 2022

nirvedhmeshram added a reviewer for D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion: hanchung.
Mar 31 2022, 2:33 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram added inline comments to D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.
Mar 31 2022, 2:21 PM · Unknown Object (Project), Restricted Project
nirvedhmeshram requested review of D122847: [mlir][linalg] Move linalg.fill folding into linalg.generic pattern to elementwise op fusion.
Mar 31 2022, 12:40 PM · Unknown Object (Project), Restricted Project

Mar 19 2022

nirvedhmeshram added inline comments to D122045: [mlir][linalg] Add pattern to split reduction dimension in a linalg op.
Mar 19 2022, 8:41 AM · Restricted Project, Unknown Object (Project)

Mar 15 2022

nirvedhmeshram committed rG59582adc3dfb: [MLIR][Linalg] Canonicalization patterns for linalg.generic. (authored by nirvedhmeshram).
[MLIR][Linalg] Canonicalization patterns for linalg.generic.
Mar 15 2022, 11:50 AM · Restricted Project
nirvedhmeshram closed D121535: [MLIR][Linalg] Canonicalization patterns for linalg.generic..
Mar 15 2022, 11:50 AM · Restricted Project, Unknown Object (Project)
nirvedhmeshram updated the diff for D121535: [MLIR][Linalg] Canonicalization patterns for linalg.generic..

using ArrayRef in helper function

Mar 15 2022, 11:25 AM · Restricted Project, Unknown Object (Project)
nirvedhmeshram updated the diff for D121535: [MLIR][Linalg] Canonicalization patterns for linalg.generic..

rebase

Mar 15 2022, 11:05 AM · Restricted Project, Unknown Object (Project)

Mar 12 2022

nirvedhmeshram requested review of D121535: [MLIR][Linalg] Canonicalization patterns for linalg.generic..
Mar 12 2022, 3:57 PM · Restricted Project, Unknown Object (Project)

Feb 9 2022

nirvedhmeshram updated the diff for D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 12:11 PM · Unknown Object (Project)
nirvedhmeshram updated the diff for D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 11:43 AM · Unknown Object (Project)
nirvedhmeshram updated the diff for D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 11:30 AM · Unknown Object (Project)
nirvedhmeshram added inline comments to D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 6:51 AM · Unknown Object (Project)
nirvedhmeshram updated the diff for D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 6:50 AM · Unknown Object (Project)
nirvedhmeshram added inline comments to D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 6:39 AM · Unknown Object (Project)
nirvedhmeshram added inline comments to D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 6:37 AM · Unknown Object (Project)
nirvedhmeshram updated the diff for D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 9 2022, 6:34 AM · Unknown Object (Project)

Feb 7 2022

nirvedhmeshram updated the summary of D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 7 2022, 5:39 PM · Unknown Object (Project)
nirvedhmeshram requested review of D119206: [mlir][vector] Add pattern to drop lead unit dim for Contraction Op.
Feb 7 2022, 5:38 PM · Unknown Object (Project)