- User Since
- Jul 18 2012, 2:16 AM (377 w, 4 d)
Mar 26 2018
Oct 10 2017
Apr 25 2017
Mar 22 2017
Commit r298574, thanks for woking on this folks!
Sep 13 2016
Sep 12 2016
This should address Hans' comments, as for the code get I have no idea. I was hoping someone more knowledgeable would tell me if this made sense or not?
Sep 11 2016
Thanks for letting me know, that patch looks more complete so I'll abandon this. I hope it lands soon!
Sep 9 2016
Sep 2 2016
Jul 6 2016
This looks good to me, +1 for RELEASE_TESTERS.txt as it seems more consistent.
Apr 15 2016
Would anyone be kind enough to review this?
Feb 15 2016
Dec 17 2015
Dec 16 2015
Dec 14 2015
Dec 13 2015
Sep 16 2015
Jul 15 2015
Committed in r242371 with minor changes to preserve nullability attribute.
Jul 14 2015
I'm a small potato but LGTM.
Jul 8 2015
Jun 30 2015
Jun 28 2015
Jun 18 2015
Jun 14 2015
Jun 12 2015
It's been some time since we looked at this.
May 25 2015
May 12 2015
I have no idea to be honest, the fact that we have only one svn repository but checkout different parts separately makes things confusing. And since I'm using git it's even more complicated ;)
LGTM, would you like me to commit this if you don't have access?
May 11 2015
No worries. This looks good, just fix the ParentFile reference I mentioned.
May 7 2015
Apr 20 2015
Your original patch had changes in the clang-extra repo as well but those are missing in this review, was that intentional?
Apr 14 2015
Oct 13 2014
You can drop the const altogether, we know that the pointer won't change.
Oct 12 2014
It looks good ignoring two style nitpicks. I'll have more confidence when you add the test for this, code review can stay open until you get to it.
Sep 25 2014
Done in r218484. Thanks for the review and all suggestions.
Sep 24 2014
Sep 16 2014
Aug 31 2014
Modified tests to cover two issues I found when I ran the patch over our code base at work.
Aug 24 2014
Done in r216352.
Aug 20 2014
We have to extend the check to cover type aliases as well. I've also updated the comment because TypeAliasDecl::Create never calls this constructor overload.
Aug 12 2014
This patch addresses issues raised by Aaron.
Aug 11 2014
I've gone full circle on this, Richard suggested resolving 'super' right away. I consumed tokens and annotated the trailing identifier as either type or primary expression. It was so simple and worked perfectly, until dependent bases showed up...
Jul 22 2014
Jul 16 2014
Committed in r213220.
This covers all test cases.
Jul 14 2014
Jul 13 2014
Thanks for the input guys, I have two questions:
Jul 10 2014
Jun 30 2014
r212090. Thanks for the review.
Good catch Richard, I had the feeling that I've missed something... This patch should address issues you raised.
Jun 19 2014
Jun 18 2014
I thought you were talking about file, not class. Ignore me, I'm stupid :)
What file should I use, they all seem to be very specialized?
Tests fail with original code. Tests don't compile if only conversion operator is marked as explicit. Const qualifying comparison operators gets the tests to compile and pass.
Jun 12 2014
Turns out we didn't have correct location and range for class template friend. The same was true for case where friend is not the first token as in Richard's inline example.
Jun 5 2014
Committed these tests in r210306 but I'll leave this review request open in case the following code produces something in the next week or so :)
Thanks for your valuable guidance. Committed in r210304.
You might have missed the last part of my comment, I clicked submit too soon and had to edit it. In any case I think you're right, it's not hard to detect redundant ellipsis and provide more accurate recovery. Here it is, with tests for this scenario.
Jun 4 2014
That's sooo much better. I'm still not checking if ellipsis exist on template parameter and template template paremeter, but I don't expect anyone to write something like
I'm not too happy with DiagnoseMisplacedEllipsis but it's still better than having it in two places. The rest should be good.
May 30 2014
Done in r209955.
May 29 2014
Done in r209869.
Done in r209867.
May 26 2014
Yep, the one with friend class fails without my patch.
May 25 2014
In what situation would FunctionType show up? In this case x is a PointerType which is not sugared.
Now with tests.
May 22 2014
Are you happy with the message or should we go for something more specific mentioning bitwise operators?