Page MenuHomePhabricator

nikola (Nikola Smiljanić)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 2:16 AM (377 w, 4 d)

Recent Activity

Mar 26 2018

nikola resigned from D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).
Mar 26 2018, 3:36 PM

Oct 10 2017

nikola removed a reviewer for D38717: Wunused-variable does not detect unused condition variable in if statement: nikola.
Oct 10 2017, 3:59 PM

Apr 25 2017

nikola accepted D32519: [Sema] Avoid using a null type pointer (fixes PR32750).

LGTM

Apr 25 2017, 10:13 PM

Mar 22 2017

nikola added a comment to D21279: Fix some issues in clang-format's AlignConsecutive modes.

Commit r298574, thanks for woking on this folks!

Mar 22 2017, 8:04 PM · Restricted Project
nikola committed rL298574: Fix issues in clang-format's AlignConsecutive modes..
Fix issues in clang-format's AlignConsecutive modes.
Mar 22 2017, 8:03 PM

Sep 13 2016

nikola closed D24193: Allow variables with asm labels in naked functions.

r281298

Sep 13 2016, 12:11 AM
nikola committed rL281298: Allow register variables in naked functions..
Allow register variables in naked functions.
Sep 13 2016, 12:10 AM

Sep 12 2016

nikola updated the diff for D24193: Allow variables with asm labels in naked functions.

This should address Hans' comments, as for the code get I have no idea. I was hoping someone more knowledgeable would tell me if this made sense or not?

Sep 12 2016, 3:03 AM

Sep 11 2016

nikola abandoned D24395: Align declarations that are preceded by different number of commas..

Thanks for letting me know, that patch looks more complete so I'll abandon this. I hope it lands soon!

Sep 11 2016, 1:48 AM
nikola added inline comments to D21279: Fix some issues in clang-format's AlignConsecutive modes.
Sep 11 2016, 1:47 AM · Restricted Project

Sep 9 2016

nikola retitled D24395: Align declarations that are preceded by different number of commas. from to Align declarations that are preceded by different number of commas..
Sep 9 2016, 7:07 AM

Sep 2 2016

nikola retitled D24193: Allow variables with asm labels in naked functions from to Allow variables with asm labels in naked functions.
Sep 2 2016, 7:35 AM

Jul 6 2016

nikola accepted D22037: [RFC] Refactoring release docs.

This looks good to me, +1 for RELEASE_TESTERS.txt as it seems more consistent.

Jul 6 2016, 9:45 PM

Apr 15 2016

nikola added a comment to D15509: Suggest missing 'template' for dependent member templates.

Would anyone be kind enough to review this?

Apr 15 2016, 5:18 AM

Feb 15 2016

nikola added a comment to D15509: Suggest missing 'template' for dependent member templates.

Ping.

Feb 15 2016, 9:54 PM
nikola added a comment to D15588: PR25356 - False positive with -Wreturn-stack-address.

Ping.

Feb 15 2016, 9:53 PM

Dec 17 2015

nikola updated subscribers of D15588: PR25356 - False positive with -Wreturn-stack-address.
Dec 17 2015, 12:13 PM

Dec 16 2015

nikola retitled D15588: PR25356 - False positive with -Wreturn-stack-address from to PR25356 - False positive with -Wreturn-stack-address.
Dec 16 2015, 2:39 PM
nikola abandoned D10431: PR21174 - clang only searches current working directory for precompiled include file.
Dec 16 2015, 2:36 PM

Dec 14 2015

nikola retitled D15509: Suggest missing 'template' for dependent member templates from to Suggest missing 'template' for dependent member templates.
Dec 14 2015, 2:49 PM

Dec 13 2015

nikola resigned from D5744: Partial specialization after class template instantiation..
Dec 13 2015, 6:54 PM

Sep 16 2015

nikola resigned from D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch.
Sep 16 2015, 4:53 PM

Jul 15 2015

nikola closed D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

Committed in r242371 with minor changes to preserve nullability attribute.

Jul 15 2015, 6:07 PM
nikola committed rL242371: PR10405 - Desugar FunctionType and TemplateSpecializationType if any type….
PR10405 - Desugar FunctionType and TemplateSpecializationType if any type…
Jul 15 2015, 6:06 PM

Jul 14 2015

nikola accepted D11012: Add a target environment for CoreCLR..

I'm a small potato but LGTM.

Jul 14 2015, 4:24 AM

Jul 8 2015

nikola added a comment to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

Ding.

Jul 8 2015, 8:52 PM
nikola added a comment to D10431: PR21174 - clang only searches current working directory for precompiled include file.

Ping.

Jul 8 2015, 8:51 PM

Jun 30 2015

nikola added a reviewer for D10431: PR21174 - clang only searches current working directory for precompiled include file: rsmith.
Jun 30 2015, 7:08 PM
nikola updated the diff for D10431: PR21174 - clang only searches current working directory for precompiled include file.

Added test.

Jun 30 2015, 7:08 PM

Jun 28 2015

nikola added a comment to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

Pong.

Jun 28 2015, 4:17 PM

Jun 18 2015

nikola added a comment to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

Ping.

Jun 18 2015, 6:21 PM

Jun 14 2015

nikola retitled D10431: PR21174 - clang only searches current working directory for precompiled include file from to PR21174 - clang only searches current working directory for precompiled include file.
Jun 14 2015, 1:27 AM

Jun 12 2015

nikola updated the diff for D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

It's been some time since we looked at this.

Jun 12 2015, 3:08 AM

May 25 2015

nikola closed D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.
May 25 2015, 5:12 PM

May 12 2015

nikola added a comment to D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

I have no idea to be honest, the fact that we have only one svn repository but checkout different parts separately makes things confusing. And since I'm using git it's even more complicated ;)

May 12 2015, 4:54 AM
nikola committed rL237116: Fix misleading parameter name for PPCallbacks::FileSkipped..
Fix misleading parameter name for PPCallbacks::FileSkipped.
May 12 2015, 4:51 AM
nikola committed rL237115: Fix misleading parameter name for PPCallbacks::FileSkipped..
Fix misleading parameter name for PPCallbacks::FileSkipped.
May 12 2015, 4:51 AM
nikola accepted D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

LGTM, would you like me to commit this if you don't have access?

May 12 2015, 4:11 AM

May 11 2015

nikola added a comment to D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

No worries. This looks good, just fix the ParentFile reference I mentioned.

May 11 2015, 10:57 PM

May 7 2015

nikola committed rL236806: Revert "Fix path separator issue on Windows.".
Revert "Fix path separator issue on Windows."
May 7 2015, 11:06 PM
nikola committed rL236804: Fix path separator issue on Windows..
Fix path separator issue on Windows.
May 7 2015, 8:30 PM

Apr 20 2015

nikola added a comment to D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped.

Your original patch had changes in the clang-extra repo as well but those are missing in this review, was that intentional?

Apr 20 2015, 4:58 PM
nikola added a reviewer for D9109: Fixed misleading parameter name for PPCallbacks::FileSkipped: nikola.
Apr 20 2015, 3:01 PM

Apr 14 2015

nikola committed rL234881: Remove useless statement..
Remove useless statement.
Apr 14 2015, 5:36 AM

Oct 13 2014

nikola added a comment to D5744: Partial specialization after class template instantiation..

You can drop the const altogether, we know that the pointer won't change.

Oct 13 2014, 3:30 PM

Oct 12 2014

nikola added a comment to D5744: Partial specialization after class template instantiation..

It looks good ignoring two style nitpicks. I'll have more confidence when you add the test for this, code review can stay open until you get to it.

Oct 12 2014, 10:16 PM

Sep 25 2014

nikola closed D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

Done in r218484. Thanks for the review and all suggestions.

Sep 25 2014, 5:42 PM

Sep 24 2014

nikola updated the diff for D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

Fingers crossed.

Sep 24 2014, 6:40 PM

Sep 16 2014

nikola added inline comments to D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.
Sep 16 2014, 8:34 PM

Aug 31 2014

nikola updated the diff for D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

Modified tests to cover two issues I found when I ran the patch over our code base at work.

Aug 31 2014, 8:05 PM

Aug 24 2014

nikola closed D4992: PR20716 - Crash when recovering from type in known dependent base (ms-compatibility) .

Done in r216352.

Aug 24 2014, 4:38 PM

Aug 20 2014

nikola updated the diff for D4992: PR20716 - Crash when recovering from type in known dependent base (ms-compatibility) .

We have to extend the check to cover type aliases as well. I've also updated the comment because TypeAliasDecl::Create never calls this constructor overload.

Aug 20 2014, 11:31 PM
nikola retitled D4992: PR20716 - Crash when recovering from type in known dependent base (ms-compatibility) from to PR20716 - Crash when recovering from type in known dependent base (ms-compatibility) .
Aug 20 2014, 5:19 PM

Aug 12 2014

nikola updated the diff for D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

This patch addresses issues raised by Aaron.

Aug 12 2014, 5:23 PM

Aug 11 2014

nikola updated the diff for D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

I've gone full circle on this, Richard suggested resolving 'super' right away. I consumed tokens and annotated the trailing identifier as either type or primary expression. It was so simple and worked perfectly, until dependent bases showed up...

Aug 11 2014, 11:09 PM

Jul 22 2014

nikola closed D3906: Location and Range unittests for FriendDecl.
Jul 22 2014, 4:57 PM

Jul 16 2014

nikola accepted D3906: Location and Range unittests for FriendDecl.

Committed in r213220.

Jul 16 2014, 7:08 PM
nikola updated the diff for D3906: Location and Range unittests for FriendDecl.

This covers all test cases.

Jul 16 2014, 7:00 PM

Jul 14 2014

nikola added inline comments to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.
Jul 14 2014, 6:36 PM
nikola added a comment to D3906: Location and Range unittests for FriendDecl.

Ping.

Jul 14 2014, 6:29 PM
nikola edited reviewers for D3906: Location and Range unittests for FriendDecl, added: rsmith; removed: klimek.
Jul 14 2014, 6:29 PM

Jul 13 2014

nikola added a comment to D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.

Thanks for the input guys, I have two questions:

Jul 13 2014, 6:42 PM

Jul 10 2014

nikola retitled D4468: PR13236 - Microsoft compatibility: support __super specifier to access members of base classes from to PR13236 - Microsoft compatibility: support __super specifier to access members of base classes.
Jul 10 2014, 9:57 PM

Jun 30 2014

nikola added inline comments to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.
Jun 30 2014, 11:07 PM
nikola added inline comments to D3906: Location and Range unittests for FriendDecl.
Jun 30 2014, 10:52 PM
nikola closed D4226: PR15677 - Crash in template diffing..

r212090. Thanks for the review.

Jun 30 2014, 9:26 PM
nikola added inline comments to D4226: PR15677 - Crash in template diffing..
Jun 30 2014, 7:47 PM
nikola updated the diff for D4226: PR15677 - Crash in template diffing..

Good catch Richard, I had the feeling that I've missed something... This patch should address issues you raised.

Jun 30 2014, 7:28 PM

Jun 19 2014

nikola updated D4226: PR15677 - Crash in template diffing..
Jun 19 2014, 7:23 PM
nikola retitled D4226: PR15677 - Crash in template diffing. from to PR15677 - Crash in template diffing..
Jun 19 2014, 7:22 PM

Jun 18 2014

nikola closed D4194: PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.

r211244. Thanks.

Jun 18 2014, 5:35 PM
nikola added a comment to D4194: PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.

I thought you were talking about file, not class. Ignore me, I'm stupid :)

Jun 18 2014, 5:23 PM
nikola added a comment to D4194: PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.

What file should I use, they all seem to be very specialized?

Jun 18 2014, 5:22 PM
nikola updated the diff for D4194: PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.

Tests fail with original code. Tests don't compile if only conversion operator is marked as explicit. Const qualifying comparison operators gets the tests to compile and pass.

Jun 18 2014, 5:11 PM
nikola retitled D4194: PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result from to PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.
Jun 18 2014, 6:23 AM

Jun 12 2014

nikola updated the diff for D3906: Location and Range unittests for FriendDecl.

Turns out we didn't have correct location and range for class template friend. The same was true for case where friend is not the first token as in Richard's inline example.

Jun 12 2014, 4:54 PM

Jun 5 2014

nikola added a comment to D3906: Location and Range unittests for FriendDecl.

Committed these tests in r210306 but I'll leave this review request open in case the following code produces something in the next week or so :)

Jun 5 2014, 9:50 PM
nikola closed D3604: PR11306 - Variadic template fix-it suggestion.

Thanks for your valuable guidance. Committed in r210304.

Jun 5 2014, 8:08 PM
nikola updated the diff for D3604: PR11306 - Variadic template fix-it suggestion.

You might have missed the last part of my comment, I clicked submit too soon and had to edit it. In any case I think you're right, it's not hard to detect redundant ellipsis and provide more accurate recovery. Here it is, with tests for this scenario.

Jun 5 2014, 6:46 PM

Jun 4 2014

nikola updated the diff for D3604: PR11306 - Variadic template fix-it suggestion.

That's sooo much better. I'm still not checking if ellipsis exist on template parameter and template template paremeter, but I don't expect anyone to write something like

Jun 4 2014, 10:33 PM
nikola updated the diff for D3604: PR11306 - Variadic template fix-it suggestion.

I'm not too happy with DiagnoseMisplacedEllipsis but it's still better than having it in two places. The rest should be good.

Jun 4 2014, 5:28 PM

May 30 2014

nikola closed D3966: PR12961 - Extend DR532 to cover C++98/03.
May 30 2014, 7:19 PM
nikola accepted D3966: PR12961 - Extend DR532 to cover C++98/03.

Done in r209955.

May 30 2014, 7:19 PM

May 29 2014

nikola retitled D3966: PR12961 - Extend DR532 to cover C++98/03 from to PR12961 - Extend DR532 to cover C++98/03.
May 29 2014, 10:14 PM
nikola requested review of D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.
May 29 2014, 8:25 PM
nikola closed D3739: PR11410 - Confusing diagnostic when trailing array element tries to call deleted default constructor.

Done in r209869.

May 29 2014, 6:36 PM
nikola closed D3753: PR12214 - warn on suspicious self-compound-assignments.

Done in r209867.

May 29 2014, 5:23 PM
nikola closed D3917: FIXME in ActionResult.

r209800

May 29 2014, 4:05 AM

May 26 2014

nikola retitled D3917: FIXME in ActionResult from to FIXME in ActionResult.
May 26 2014, 9:10 PM
nikola added a comment to D3906: Location and Range unittests for FriendDecl.

Yep, the one with friend class fails without my patch.

May 26 2014, 2:41 AM
nikola retitled D3906: Location and Range unittests for FriendDecl from to Location and Range unittests for FriendDecl.
May 26 2014, 2:28 AM

May 25 2014

nikola updated subscribers of D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.
May 25 2014, 8:40 PM
nikola planned changes to D3588: PR10405 Missing actual type (aka) in error message when using decltype as a template parameter.

In what situation would FunctionType show up? In this case x is a PointerType which is not sugared.

May 25 2014, 8:39 PM
nikola updated subscribers of D3739: PR11410 - Confusing diagnostic when trailing array element tries to call deleted default constructor.

Added test.

May 25 2014, 8:28 PM
nikola updated the diff for D3753: PR12214 - warn on suspicious self-compound-assignments.

Now with tests.

May 25 2014, 6:39 PM
nikola updated subscribers of D3753: PR12214 - warn on suspicious self-compound-assignments.
May 25 2014, 6:37 PM

May 22 2014

nikola added a comment to D3753: PR12214 - warn on suspicious self-compound-assignments.

Are you happy with the message or should we go for something more specific mentioning bitwise operators?

May 22 2014, 5:18 PM

May 21 2014

nikola added inline comments to D3604: PR11306 - Variadic template fix-it suggestion.
May 21 2014, 8:52 PM

May 20 2014

nikola added inline comments to D3604: PR11306 - Variadic template fix-it suggestion.
May 20 2014, 9:32 PM

May 13 2014

nikola retitled D3753: PR12214 - warn on suspicious self-compound-assignments from to PR12214 - warn on suspicious self-compound-assignments.
May 13 2014, 10:53 PM