Ping :)

Nevermind, this was fixed as I was looking at it. LGTM.

This is becoming repetitive, but I guess that's the nature of those things. Maybe something like this would help clean it up, not sure if any better for right now.

Ping.

@njames93 If you have a minute, could you please take a second look at this? Let me know what's needed to get this change landed.

Ping.

Thank you for the feedback!

Rename OnlyWarnInLoops to WarnOutsideLoops, cover missed cxxForRangeStmt

Ping.

Ping.

Rebase.

Mid-CppCon ping.

Ping.

In D131939#3755399, @Eugene.Zelenko wrote:

I got notification.

I feel like Phabricator is not sending notifications for this patch like it usually does (I'm not getting any emails).
I'll create a new, identical patch tomorrow if there's still no activity.

Ping.

I do not have commit access for the LLVM repository, could one of you commit this for me (Nicolas van Kempen <nvankempen@fb.com>)?

Did some digging, looks like this was added in rG7f92a1a84b96, most likely to also fix that CI build error with misc-misleading-identifier.

Ping, adding one more person who has history changing this script.

Looks like registerPPCallbacks / Result.Context->getSourceManager() gives me the information I need. Thank you @gribozavr2 for your help!

Thanks! Looks like registerPPCallbacks might be what I am looking for, I was not aware of it. I will mark this as planning changes temporarily, then abandon if solved.

Looks like this causes the misc-misleading-identifier test to fail on the BuildKite Windows setup because it uses cp1252 and not utf-8. I think this is why the encode was added in the first place. This workaround should hopefully fix this, it will display unicode characters as '?' when stdout does not support utf-8.

Fix formatting issues

Update!

1. Rebased.
2. Fixed a minor bug which occasionaly caused false negatives.
3. Cleared up fix/hint generation and another nit following comments.
4. Re-organized and added a couple tests.
5. Made a note of this extension in documentation.

Fix some style comments

Thank you for the feedback, I appreciate it! Let me know if there is any other I missed, AFAIK all auto uses introduced by me should be good now.

Explicitely specify one more type

Fix a couple variable names and explicitely specify a couple types

As you can see, this will fail some tests as there is one corner case which is tricky to handle:

std::vector<std::tuple<std::tuple<int, int>>> vec;
// This is valid and should not be changed.
vec.emplace_back(std::make_tuple(13, 31));