Page MenuHomePhabricator

nicovank (Nicolas van Kempen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2021, 3:29 PM (79 w, 3 d)

Recent Activity

Tue, Sep 20

nicovank added a comment to D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

Ping.

Tue, Sep 20, 9:36 AM · Restricted Project, Restricted Project
nicovank updated the diff for D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

Rebase.

Tue, Sep 20, 9:36 AM · Restricted Project, Restricted Project

Tue, Sep 13

nicovank added a comment to D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

Mid-CppCon ping.

Tue, Sep 13, 10:21 AM · Restricted Project, Restricted Project

Tue, Sep 6

nicovank added a comment to D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

Ping.

Tue, Sep 6, 12:00 PM · Restricted Project, Restricted Project

Mon, Aug 29

nicovank added a comment to D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

I got notification.

Mon, Aug 29, 7:17 AM · Restricted Project, Restricted Project
nicovank added a comment to D131939: [clang-tidy] Add performance-expensive-flat-container-operation check.

I feel like Phabricator is not sending notifications for this patch like it usually does (I'm not getting any emails).
I'll create a new, identical patch tomorrow if there's still no activity.

Mon, Aug 29, 7:03 AM · Restricted Project, Restricted Project

Aug 23 2022

nicovank added a reviewer for D131939: [clang-tidy] Add performance-expensive-flat-container-operation check: alexfh.

Ping.

Aug 23 2022, 8:34 AM · Restricted Project, Restricted Project

Aug 16 2022

nicovank published D131939: [clang-tidy] Add performance-expensive-flat-container-operation check for review.
Aug 16 2022, 8:40 AM · Restricted Project, Restricted Project

Jul 1 2022

nicovank added a comment to D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

I do not have commit access for the LLVM repository, could one of you commit this for me (Nicolas van Kempen <nvankempen@fb.com>)?

Jul 1 2022, 1:53 PM · Restricted Project, Restricted Project

Jun 30 2022

nicovank added a reviewer for D127807: [clang-tidy] Properly forward clang-tidy output when running tests: serge-sans-paille.

Did some digging, looks like this was added in rG7f92a1a84b96, most likely to also fix that CI build error with misc-misleading-identifier.

Jun 30 2022, 10:33 AM · Restricted Project, Restricted Project

Jun 29 2022

nicovank added a reviewer for D127807: [clang-tidy] Properly forward clang-tidy output when running tests: LegalizeAdulthood.

Ping, adding one more person who has history changing this script.

Jun 29 2022, 5:22 PM · Restricted Project, Restricted Project

Jun 20 2022

nicovank added reviewers for D127807: [clang-tidy] Properly forward clang-tidy output when running tests: aaron.ballman, njames93.
Jun 20 2022, 8:45 AM · Restricted Project, Restricted Project

Jun 16 2022

nicovank abandoned D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks.

Looks like registerPPCallbacks / Result.Context->getSourceManager() gives me the information I need. Thank you @gribozavr2 for your help!

Jun 16 2022, 8:40 AM · Restricted Project, Restricted Project

Jun 15 2022

nicovank planned changes to D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks.

Thanks! Looks like registerPPCallbacks might be what I am looking for, I was not aware of it. I will mark this as planning changes temporarily, then abandon if solved.

Jun 15 2022, 11:53 AM · Restricted Project, Restricted Project
nicovank published D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks for review.
Jun 15 2022, 11:33 AM · Restricted Project, Restricted Project
nicovank updated the diff for D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

Looks like this causes the misc-misleading-identifier test to fail on the BuildKite Windows setup because it uses cp1252 and not utf-8. I think this is why the encode was added in the first place. This workaround should hopefully fix this, it will display unicode characters as '?' when stdout does not support utf-8.

Jun 15 2022, 7:32 AM · Restricted Project, Restricted Project

Jun 14 2022

nicovank published D127807: [clang-tidy] Properly forward clang-tidy output when running tests for review.
Jun 14 2022, 5:01 PM · Restricted Project, Restricted Project

Jun 2 2022

nicovank added a reviewer for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace: ivanmurashko.
Jun 2 2022, 2:32 PM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

nicovank updated the diff for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Fix formatting issues

May 23 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
nicovank updated the diff for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Update!

  1. Rebased.
  2. Fixed a minor bug which occasionaly caused false negatives.
  3. Cleared up fix/hint generation and another nit following comments.
  4. Re-organized and added a couple tests.
  5. Made a note of this extension in documentation.
May 23 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2021

nicovank added inline comments to D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.
May 6 2021, 7:23 AM · Restricted Project, Restricted Project, Restricted Project
nicovank updated the diff for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Fix some style comments

May 6 2021, 7:18 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2021

nicovank added a comment to D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Thank you for the feedback, I appreciate it! Let me know if there is any other I missed, AFAIK all auto uses introduced by me should be good now.

Apr 28 2021, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
nicovank updated the diff for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Explicitely specify one more type

Apr 28 2021, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
nicovank updated the diff for D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

Fix a couple variable names and explicitely specify a couple types

Apr 28 2021, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
nicovank added a comment to D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.

As you can see, this will fail some tests as there is one corner case which is tricky to handle:

std::vector<std::tuple<std::tuple<int, int>>> vec;
// This is valid and should not be changed.
vec.emplace_back(std::make_tuple(13, 31));
Apr 28 2021, 9:54 AM · Restricted Project, Restricted Project, Restricted Project
nicovank requested review of D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace.
Apr 28 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project