User Details
- User Since
- Sep 3 2019, 3:29 PM (154 w, 21 h)
Apr 28 2021
Apr 19 2021
The compile time regression fix is up for review at https://reviews.llvm.org/D100738 .
Apr 18 2021
Apr 15 2021
Is hasParentContext(LLVMContext &C) an acceptable name for what it does? Is there a better one?
Apr 8 2021
Ping!
Apr 2 2021
Other than it not being "const" is there any reason you couldn't use FindNodeOrInsertPos to implement contains?
This patch includes a change to FoldingSet. Does it make sense for FoldingSet to have a Contains() method? Was it previously missing because we didn't need it yet, or was it missing because not having it makes for a better API? Should that be broken out into its own patch or
Mar 29 2021
Mar 25 2021
Apply clang-format suggestions, mostly just silence clang-tidy suggestions.
Apply clang-format suggestion.
Mar 24 2021
Mar 16 2021
I'm not sure about the intended usage for these APIs, but this looks like a straightforward extension of the existing functionality.
Mar 15 2021
Rebase on top of main after landing the formatting changes separately.
Mar 12 2021
Fix clang-tidy-diff complaints from the builder.
Phab mangled my patch from:
index 96d3672647e8..8d0e06a62d36 100644 --- llvm/unittests/IR/ConstantsTest.cpp +++ llvm/unittests/IR/ConstantsTest.cpp @@ -1,717 +1,725 @@
to
diff --git a/llvm/unittests/IR/ConstantsTest.cpp b/unittests/IR/ConstantsTest.cpp --- a/llvm/unittests/IR/ConstantsTest.cpp +++ b/unittests/IR/ConstantsTest.cpp @@ -23,11 +23,11 @@
breaking the build.
Mar 10 2021
Remove one blank line pointed out by clang-format.
Apply formatting changes raised by "llvm-premerge-checks".
Mar 9 2021
Jun 22 2020
Jun 9 2020
Ping!
Jun 1 2020
Ping!
May 26 2020
Ping!
May 18 2020
Ping!
May 7 2020
Ping!
Apr 30 2020
Sep 25 2019
Ping!
Sep 18 2019
Sep 17 2019
Added tests.
Sep 10 2019
Ping! It's been 1 week since I sent out this patch.
Sep 6 2019
Add the ability to update ordering on atomicrmw and fence.