Page MenuHomePhabricator

nick (Nikita Kniazev)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2019, 7:04 AM (76 w, 3 d)

Recent Activity

Aug 19 2020

nick added a comment to rG1cbdf932b41e: PR46231: Promote diagnostic for 'template<...>;' from ExtWarn to Error..

FYI: this breaks some msvc compatibility

template <class> class X {};
template X<int>;
Aug 19 2020, 10:11 AM

Jun 24 2020

nick added inline comments to D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body..
Jun 24 2020, 4:52 PM · Restricted Project
nick added a comment to D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body..

Thanks @zequanwu, much appreciated.

Jun 24 2020, 5:22 AM · Restricted Project

Jun 23 2020

nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

We didn't see it in the code bases I work with, so is boost a special case, or an example of a common practice?

Jun 23 2020, 5:16 PM · Restricted Project
nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

I feel like doing interprocedural analysis for this is overkill. What is the benefit of boost::ignore_unused(foo); rather than the more common (void) foo;? Any examples?

Jun 23 2020, 9:37 AM · Restricted Project

Jun 22 2020

nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

This warning can be turned off by the flag -Wno-uninitialized-const-reference.

Jun 22 2020, 4:40 PM · Restricted Project
nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

This diagnostic bring headaches because frequently -Wunused-variable suppression is done via no-op pseudo-consuming function like [boost::ignore_unused](https://www.boost.org/doc/libs/1_73_0/libs/core/doc/html/core/ignore_unused.html). Particularly, it fires in Boost here https://github.com/boostorg/concept_check/blob/e69c81326d5a4359ac53f9c6fe53fc2baf24df50/include/boost/concept_check.hpp#L135-L141.
Is it possible to make the diagnostic not fire for empty body consuming functions?

Jun 22 2020, 3:03 PM · Restricted Project

Jun 10 2020

nick added inline comments to D80867: [x86] form reduction intrinsics over raw IR.
Jun 10 2020, 3:39 PM · Restricted Project

May 26 2020

nick added inline comments to D79063: [ASTMatchers] Matchers related to C++ inheritance.
May 26 2020, 5:28 PM · Restricted Project

Apr 24 2020

nick added inline comments to D71214: [libc++] reduce <complex> parsing time.
Apr 24 2020, 11:20 AM · Restricted Project

Jan 29 2020

nick added a comment to D71214: [libc++] reduce <complex> parsing time.

No, I do not have commit rights.

Jan 29 2020, 5:18 PM · Restricted Project

Jan 13 2020

nick added a comment to D72643: [InstCombine] form copysign from select of FP constants (PR44153).

I cannot be a reviewer, just added some dummies questions. And, @spatel, thanks for working on this!

Jan 13 2020, 2:30 PM · Restricted Project

Dec 9 2019

nick created D71214: [libc++] reduce <complex> parsing time.
Dec 9 2019, 9:56 AM · Restricted Project

Nov 12 2019

Herald added a reviewer for D59035: [X86] Promote i8 CMOV's (PR40965): mclow.lists.
Nov 12 2019, 10:00 AM · Restricted Project, Restricted Project

Oct 20 2019

nick updated the diff for D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support.

Fixed typo.

Oct 20 2019, 7:21 AM · Restricted Project

Oct 19 2019

nick updated the diff for D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support.

Regenerated the docs, added more tests.

Oct 19 2019, 3:23 PM · Restricted Project
nick created D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support.
Oct 19 2019, 2:00 PM · Restricted Project

Oct 15 2019

nick added inline comments to D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.
Oct 15 2019, 4:50 PM · Restricted Project, Restricted Project
nick updated the diff for D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.

Addressed comments.

Oct 15 2019, 4:41 PM · Restricted Project, Restricted Project
nick created D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.
Oct 15 2019, 10:48 AM · Restricted Project, Restricted Project