Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

ngzhian (Ng Zhi An)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 22 2020, 4:23 PM (188 w, 6 d)

Recent Activity

Oct 27 2021

ngzhian added a comment to D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.

Good suggestion, done.

Oct 27 2021, 10:40 AM · Restricted Project, Restricted Project
ngzhian updated the diff for D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.

Make intrinsics monomorphic

Oct 27 2021, 10:39 AM · Restricted Project, Restricted Project

Oct 26 2021

ngzhian added inline comments to D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 26 2021, 1:43 PM · Restricted Project, Restricted Project
ngzhian added a reviewer for D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions: tlively.
Oct 26 2021, 1:43 PM · Restricted Project, Restricted Project
ngzhian updated the diff for D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.

No shuffles

Oct 26 2021, 1:41 PM · Restricted Project, Restricted Project

Oct 20 2021

ngzhian updated subscribers of D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 20 2021, 2:56 PM · Restricted Project, Restricted Project
ngzhian requested review of D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions.
Oct 20 2021, 2:54 PM · Restricted Project, Restricted Project
ngzhian requested review of D112146: [WebAssembly] Add prototype relaxed float min max instructions.
Oct 20 2021, 9:00 AM · Restricted Project, Restricted Project

Oct 19 2021

ngzhian updated the diff for D112022: [WebAssembly] Add prototype relaxed swizzle instructions.
  • Remove RELAXED_SWIZZLE sdnode
Oct 19 2021, 3:02 PM · Restricted Project, Restricted Project
ngzhian updated the diff for D112022: [WebAssembly] Add prototype relaxed swizzle instructions.

Wrong commits

Oct 19 2021, 2:27 PM · Restricted Project, Restricted Project

Oct 18 2021

ngzhian updated the diff for D112022: [WebAssembly] Add prototype relaxed swizzle instructions.

Add title for relaxed swizzle instruction

Oct 18 2021, 4:16 PM · Restricted Project, Restricted Project
ngzhian added inline comments to D112022: [WebAssembly] Add prototype relaxed swizzle instructions.
Oct 18 2021, 10:53 AM · Restricted Project, Restricted Project
ngzhian requested review of D112022: [WebAssembly] Add prototype relaxed swizzle instructions.
Oct 18 2021, 10:52 AM · Restricted Project, Restricted Project

Oct 15 2021

ngzhian requested review of D111914: [WebAssembly] Add prototype relaxed laneselect instructions.
Oct 15 2021, 4:25 PM · Restricted Project, Restricted Project

Sep 22 2021

ngzhian accepted D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions.

The binary opcodes LGTM, not too sure about the tablegen stuff, tests look good too.

Sep 22 2021, 4:28 PM · Restricted Project, Restricted Project
ngzhian added a comment to D110111: [WebAssembly] Add relaxed-simd feature.

Nice! Thanks for writing this :D Do you know what happens when you actually try to compile some code with -mrelaxed-simd? I'm concerned that it will throw an error because the "relaxed-simd" target feature has not yet been defined in the backend (specifically in WebAssembly.td and in WebAssemblySubtarget.{h,cpp}).

Sep 22 2021, 9:27 AM · Restricted Project, Restricted Project
ngzhian updated the diff for D110111: [WebAssembly] Add relaxed-simd feature.

Fix fallthrough, add feature to WebAssembly subtarget

Sep 22 2021, 9:27 AM · Restricted Project, Restricted Project

Sep 20 2021

ngzhian added a comment to D110111: [WebAssembly] Add relaxed-simd feature.

I followed https://reviews.llvm.org/rGb7b9fdc114c1f9c788da914dac5c343277805446 for this, hope it's right, ptal Thomas.

Sep 20 2021, 4:14 PM · Restricted Project, Restricted Project
ngzhian requested review of D110111: [WebAssembly] Add relaxed-simd feature.
Sep 20 2021, 4:12 PM · Restricted Project, Restricted Project

Apr 29 2020

ngzhian added a comment to D49890: Clang-Tidy Export Problem.

I found this patch while searching for a similar problem I faced while tryin to use clang-tidy to fix some warnings in V8 (Chrome's JavaScript engine).
The setup for our compilation is as such:

Apr 29 2020, 3:06 PM · Restricted Project, Restricted Project

Apr 27 2020

ngzhian added a comment to D78686: [PowerPC] Fix downcast from nullptr.

Thanks Steven, I do not have commit access, can you please help me commit this?

Apr 27 2020, 10:11 AM · Restricted Project, Restricted Project

Apr 24 2020

ngzhian added a comment to D78686: [PowerPC] Fix downcast from nullptr.

Thanks for the advice, Steven. I found some existing tests that exercised the particular downcasting logic, and found that if I set -filetype=null in those RUN: directives, I could trigger a crash. So I added a line to those tests. Also made the same fix to PPCAsmParser and PPCAIXAsmPrinter.

Apr 24 2020, 12:58 PM · Restricted Project, Restricted Project
ngzhian updated the diff for D78686: [PowerPC] Fix downcast from nullptr.

Add some tests for null streamer. Fix more instances of downcast from nullptr.

Apr 24 2020, 12:58 PM · Restricted Project, Restricted Project

Apr 23 2020

ngzhian updated the diff for D78686: [PowerPC] Fix downcast from nullptr.

Add null check

Apr 23 2020, 9:43 AM · Restricted Project, Restricted Project
ngzhian added a comment to D78686: [PowerPC] Fix downcast from nullptr.

I don't have a good idea how to add test for this. With an ASAN build with -fsanitize=null, we get an error when running inlined-strings.ll.

Apr 23 2020, 9:43 AM · Restricted Project, Restricted Project

Apr 22 2020

ngzhian updated subscribers of D78686: [PowerPC] Fix downcast from nullptr.
Apr 22 2020, 4:52 PM · Restricted Project, Restricted Project
ngzhian added a reviewer for D78686: [PowerPC] Fix downcast from nullptr: nemanjai.
Apr 22 2020, 4:52 PM · Restricted Project, Restricted Project
ngzhian created D78686: [PowerPC] Fix downcast from nullptr.
Apr 22 2020, 4:52 PM · Restricted Project, Restricted Project