Page MenuHomePhabricator

nealsid (Neal)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 28 2018, 5:03 PM (71 w, 2 d)

Recent Activity

Aug 31 2018

nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.

Ran clang-format

Aug 31 2018, 10:30 AM
nealsid retitled D50299: Migrate to llvm::unique_function instead of static member functions for callbacks from Migrate to std::function instead of static member functions for callbacks to Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 31 2018, 9:11 AM
nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.

Fix 80 char line length violations

Aug 31 2018, 9:11 AM
nealsid updated the summary of D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 31 2018, 9:00 AM
nealsid updated the summary of D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 31 2018, 9:00 AM

Aug 6 2018

nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 6 2018, 2:25 PM
nealsid added a comment to D49963: Preliminary patch to support prompt interpolation.

This will be very cool. Biggest issues to watch out for is to make sure it doesn't return incorrect values when running for things like the thread count. If you switch to use the "m_debugger.GetCommandInterpreter().GetExecutionContext()" it should solve this by making sure the frame and thread are not filled in when the process is running. It might also be racy. For example if you say "continue", hopefully the process will be resumed by the time the prompt is asked to refresh itself. Since we get events asynchronously this might be a problem.

Aug 6 2018, 12:21 PM
nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 6 2018, 9:27 AM
nealsid added inline comments to D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 6 2018, 9:24 AM
nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.

Addressed code review feedback to move to llvm::unique_function instead of function pointers for callbacks and type aliases instead of typedefs.

Aug 6 2018, 9:23 AM

Aug 5 2018

nealsid added inline comments to D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 5 2018, 3:31 PM

Aug 4 2018

nealsid planned changes to D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.

Thanks for the comments! Will address and resend for review.

Aug 4 2018, 10:02 PM
nealsid updated the diff for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.

Fix unit test build

Aug 4 2018, 3:39 PM
nealsid created D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 4 2018, 3:31 PM

Aug 3 2018

nealsid planned changes to D49963: Preliminary patch to support prompt interpolation.
Aug 3 2018, 1:49 PM
nealsid accepted D49963: Preliminary patch to support prompt interpolation.
Aug 3 2018, 1:47 PM

Jul 28 2018

nealsid updated subscribers of D49963: Preliminary patch to support prompt interpolation.
Jul 28 2018, 9:53 PM
nealsid created D49963: Preliminary patch to support prompt interpolation.
Jul 28 2018, 9:50 PM