Page MenuHomePhabricator

nalimilan (Milan Bouchet-Valat)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 1 2016, 2:43 AM (201 w, 2 d)

Recent Activity

Dec 20 2018

nalimilan added a comment to D28234: Support for custom install dirs in CMake build.

Well, I'm all for using standard solutions in general. But I'm afraid GNUInstallDirs won't play very well with LLVM_LIBDIR_SUFFIX. Let me investigate that again (last time you asked me this was almost two years ago...).

Dec 20 2018, 2:54 AM
nalimilan added a comment to D28234: Support for custom install dirs in CMake build.

Given that the PR works as-is and doesn't add too much code, I don't really see the advantage of moving to an "ugly" solution just to use GNUInstallDirs. Is there a strong advantage to that?

Dec 20 2018, 2:35 AM
nalimilan added a comment to D28234: Support for custom install dirs in CMake build.

Re-re-bump!

Dec 20 2018, 1:45 AM

Oct 9 2018

nalimilan added a comment to D28234: Support for custom install dirs in CMake build.

Re-bump. ;-)

Oct 9 2018, 12:47 AM

Sep 7 2018

nalimilan updated the diff for D28234: Support for custom install dirs in CMake build.

Bump. I have rebased against current master.

Sep 7 2018, 4:57 AM

Feb 11 2017

nalimilan updated the diff for D28234: Support for custom install dirs in CMake build.

Done.

Feb 11 2017, 9:32 AM

Feb 3 2017

nalimilan added inline comments to D28234: Support for custom install dirs in CMake build.
Feb 3 2017, 2:56 AM
nalimilan updated the diff for D28234: Support for custom install dirs in CMake build.

Sorry for the delay. I think this new revision takes into account all remarks. Though the naming of the variables is still open for discussion.

Feb 3 2017, 2:49 AM

Jan 10 2017

nalimilan added a comment to D28234: Support for custom install dirs in CMake build.

Thanks for the review!

Jan 10 2017, 4:09 AM

Jan 4 2017

nalimilan added a comment to D28221: Add check for AVX512 support before assuming skylake processor is SKX..

Is the skylake-avx512 family even worth having? Wouldn't it be better in all cases to check specifically for AVX-512 support?

Jan 4 2017, 10:27 AM

Jan 3 2017

nalimilan added a reviewer for D28234: Support for custom install dirs in CMake build: beanz.
Jan 3 2017, 7:32 AM
nalimilan retitled D28234: Support for custom install dirs in CMake build from to Support for custom install dirs in CMake build.
Jan 3 2017, 7:29 AM
nalimilan added a comment to D28221: Add check for AVX512 support before assuming skylake processor is SKX..

(Though for clarity you could remove the // "skylake-avx512" comment and replace it with one comment for each branch.)

Jan 3 2017, 12:56 AM
nalimilan accepted D28221: Add check for AVX512 support before assuming skylake processor is SKX..

Fixes the incorrect detection of my i5-6300U CPU.

Jan 3 2017, 12:53 AM

Feb 1 2016

nalimilan updated subscribers of D16505: ScalarEvolutionExpander step scaling bug.
Feb 1 2016, 2:44 AM