Page MenuHomePhabricator

mzeren-vmw (Mark Zeren)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2017, 1:06 PM (107 w, 4 d)

Recent Activity

Mar 21 2019

mzeren-vmw added inline comments to D42034: [clang-format] In tests, expected code should be format-stable.
Mar 21 2019, 8:37 PM · Restricted Project

Mar 20 2019

mzeren-vmw added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Oh wow, wasn't aware how popular this is. Sigh. I'd like us to push them to change their style guide, but I guess that's not going to fly.

IDK. If the criteria is "public coding standard for widely used project", supporting all such things may be unsustainable. Some projects may need to fork or find another formatter. I speak as someone that maintains an internal fork with features that I do not deem worthy of foisting on trunk.
(And BTW @MyDeveloperDay, whoever you are, Thanks for all of your recent activity!)

Mar 20 2019, 6:38 AM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2018

Herald updated subscribers of D49317: Move __construct_forward (etc.) out of std::allocator_traits..
Oct 7 2018, 5:10 PM

Apr 4 2018

mzeren-vmw committed rC329231: [clang-format] In tests, expected code should be format-stable.
[clang-format] In tests, expected code should be format-stable
Apr 4 2018, 2:13 PM
mzeren-vmw committed rL329231: [clang-format] In tests, expected code should be format-stable.
[clang-format] In tests, expected code should be format-stable
Apr 4 2018, 2:13 PM
mzeren-vmw closed D42034: [clang-format] In tests, expected code should be format-stable.
Apr 4 2018, 2:13 PM · Restricted Project

Apr 3 2018

mzeren-vmw added a comment to D42034: [clang-format] In tests, expected code should be format-stable.

Update other verifyFormat implementations.

Apr 3 2018, 3:39 PM · Restricted Project

Mar 29 2018

mzeren-vmw updated the diff for D42034: [clang-format] In tests, expected code should be format-stable.

Update other verifyFormat implementations.

Mar 29 2018, 9:51 AM · Restricted Project

Feb 7 2018

Herald updated subscribers of D32479: clang-format: Introduce BreakConstructorInitializers option.
Feb 7 2018, 8:44 AM

Feb 5 2018

mzeren-vmw committed rC324246: [clang-format] Re-land: Fixup #include guard indents after parseFile().
[clang-format] Re-land: Fixup #include guard indents after parseFile()
Feb 5 2018, 8:00 AM
mzeren-vmw committed rL324246: [clang-format] Re-land: Fixup #include guard indents after parseFile().
[clang-format] Re-land: Fixup #include guard indents after parseFile()
Feb 5 2018, 8:00 AM
mzeren-vmw committed rL324239: Revert "[clang-format] Fixup #include guard indents after parseFile()".
Revert "[clang-format] Fixup #include guard indents after parseFile()"
Feb 5 2018, 6:50 AM
mzeren-vmw committed rC324239: Revert "[clang-format] Fixup #include guard indents after parseFile()".
Revert "[clang-format] Fixup #include guard indents after parseFile()"
Feb 5 2018, 6:50 AM
mzeren-vmw committed rC324238: [clang-format] Fixup #include guard indents after parseFile().
[clang-format] Fixup #include guard indents after parseFile()
Feb 5 2018, 6:39 AM
mzeren-vmw committed rL324238: [clang-format] Fixup #include guard indents after parseFile().
[clang-format] Fixup #include guard indents after parseFile()
Feb 5 2018, 6:39 AM
mzeren-vmw closed D42035: [clang-format] Fixup #include guard indents after parseFile().
Feb 5 2018, 6:39 AM

Feb 1 2018

mzeren-vmw updated the diff for D42034: [clang-format] In tests, expected code should be format-stable.
  • Reviewers: drop euhlmann, add djasper
  • Rebase
  • Ping
Feb 1 2018, 7:24 AM · Restricted Project
mzeren-vmw updated the diff for D42035: [clang-format] Fixup #include guard indents after parseFile().
  • Add comments to IncludeGuardState.
  • Fix re-initialization of IncludeGuard in UnwrappedLineParser::reset.
  • Remove unnecessary block after if.
  • Rebase
Feb 1 2018, 7:21 AM
mzeren-vmw added inline comments to D42035: [clang-format] Fixup #include guard indents after parseFile().
Feb 1 2018, 6:08 AM

Jan 31 2018

mzeren-vmw updated the diff for D42035: [clang-format] Fixup #include guard indents after parseFile().

rebase, ping.

Jan 31 2018, 8:11 PM
mzeren-vmw committed rC323904: [clang-format] Align preprocessor comments with #.
[clang-format] Align preprocessor comments with #
Jan 31 2018, 12:08 PM
mzeren-vmw committed rL323904: [clang-format] Align preprocessor comments with #.
[clang-format] Align preprocessor comments with #
Jan 31 2018, 12:08 PM
mzeren-vmw closed D42408: [clang-format] Align preprocessor comments with #.
Jan 31 2018, 12:08 PM

Jan 22 2018

mzeren-vmw created D42408: [clang-format] Align preprocessor comments with #.
Jan 22 2018, 10:26 PM
mzeren-vmw added a comment to D42036: [clang-format] Keep comments aligned to macros.

To me, aligning with the define seems fundamentally wrong.

we definitely have code that does that internally. It can also be seen in the wild e.g.:
https://github.com/boostorg/config/blob/develop/include/boost/config/detail/posix_features.hpp
However, it seems reasonable that clang-format's "default" be alignment with #. That will be a simpler patch, and it will resolve the toggling behavior. Let me work that up in a separate review.

Jan 22 2018, 4:14 PM

Jan 18 2018

mzeren-vmw added inline comments to D42036: [clang-format] Keep comments aligned to macros.
Jan 18 2018, 3:21 PM
mzeren-vmw removed a reviewer for D42036: [clang-format] Keep comments aligned to macros: euhlmann.
Jan 18 2018, 3:21 PM
mzeren-vmw updated the diff for D42036: [clang-format] Keep comments aligned to macros.

Documented CommentAlignment enumerators. Documenting them suggested better
enumerator names.

Jan 18 2018, 1:30 PM

Jan 16 2018

mzeren-vmw added a comment to D42036: [clang-format] Keep comments aligned to macros.

Just from a formatting point of view, why not:

//.   Comment
#.    define X

(assuming the '.'s are unintentional)
There is some logic in placing // in column 0, since we place # in column 0. However, we do not have examples of that style in our code base. We do have examples of aligning // above define:

   // Comment
#  define

Are you suggesting that c-f manage the indent after the // (or ///, etc.)? This seems more complex than managing the space between # and <directive>. I do want c-f to be able to re-indent aligned comments if an #if is inserted above.

Jan 16 2018, 7:21 AM

Jan 14 2018

mzeren-vmw created D42036: [clang-format] Keep comments aligned to macros.
Jan 14 2018, 7:49 AM
mzeren-vmw created D42035: [clang-format] Fixup #include guard indents after parseFile().
Jan 14 2018, 7:29 AM
mzeren-vmw created D42034: [clang-format] In tests, expected code should be format-stable.
Jan 14 2018, 7:13 AM · Restricted Project

Jan 13 2018

mzeren-vmw committed rL322448: [clang-format] [NFC] Remove comment.
[clang-format] [NFC] Remove comment
Jan 13 2018, 2:54 PM
mzeren-vmw committed rC322448: [clang-format] [NFC] Remove comment.
[clang-format] [NFC] Remove comment
Jan 13 2018, 2:53 PM

Aug 23 2017

mzeren-vmw added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 23 2017, 2:27 PM · Restricted Project

Aug 15 2017

mzeren-vmw added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 15 2017, 3:45 AM · Restricted Project

Aug 11 2017

mzeren-vmw added a comment to D35955: clang-format: Add preprocessor directive indentation.

Daniel's right. We need need substantially more tests!

Aug 11 2017, 5:35 PM · Restricted Project