- User Since
- Jul 25 2017, 1:06 PM (166 w, 1 d)
Thu, Sep 24
Perhaps PointerAlignment should be an enum of Left, Middle, Right?
We maintain an internal patch that adds "ReferenceAlignment" as separate from PointerAlignment. So one could have:
PointerAlignment: Middle ReferenceAlignment: Left
Mar 21 2019
Mar 20 2019
IDK. If the criteria is "public coding standard for widely used project", supporting all such things may be unsustainable. Some projects may need to fork or find another formatter. I speak as someone that maintains an internal fork with features that I do not deem worthy of foisting on trunk.
(And BTW @MyDeveloperDay, whoever you are, Thanks for all of your recent activity!)
Apr 4 2018
Apr 3 2018
Mar 29 2018
Update other verifyFormat implementations.
Feb 5 2018
Feb 1 2018
- Reviewers: drop euhlmann, add djasper
- Add comments to IncludeGuardState.
- Fix re-initialization of IncludeGuard in UnwrappedLineParser::reset.
- Remove unnecessary block after if.
Jan 31 2018
Jan 22 2018
we definitely have code that does that internally. It can also be seen in the wild e.g.:
However, it seems reasonable that clang-format's "default" be alignment with #. That will be a simpler patch, and it will resolve the toggling behavior. Let me work that up in a separate review.
Jan 18 2018
Documented CommentAlignment enumerators. Documenting them suggested better
Jan 16 2018
(assuming the '.'s are unintentional)
There is some logic in placing // in column 0, since we place # in column 0. However, we do not have examples of that style in our code base. We do have examples of aligning // above define:
// Comment # define
Are you suggesting that c-f manage the indent after the // (or ///, etc.)? This seems more complex than managing the space between # and <directive>. I do want c-f to be able to re-indent aligned comments if an #if is inserted above.
Jan 14 2018
Jan 13 2018
Aug 23 2017
Aug 15 2017
Aug 11 2017
Daniel's right. We need need substantially more tests!