Page MenuHomePhabricator

murrayc (Murray Cumming)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
May 17 2016, 6:34 AM (257 w, 10 h)

Recent Activity

Jul 22 2016

murrayc added inline comments to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..
Jul 22 2016, 2:38 AM · Restricted Project

Jun 30 2016

murrayc added a comment to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

I'd still be perfectly happy if just the simple check for implicit operator bool was accepted.

Jun 30 2016, 5:56 AM · Restricted Project
murrayc updated the diff for D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

Same as previous patch, but with a tiny suggested whitespace corretion.

Jun 30 2016, 5:53 AM · Restricted Project

Jun 4 2016

murrayc added a comment to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

Looks like a useful check to have. I'm not sure though, that it has anything to do with "modernize". I'd suggest adding a new "bugprone" module (should be added by http://reviews.llvm.org/D18821, hopefully soon) and moving the check there.

Jun 4 2016, 1:27 AM · Restricted Project

Jun 3 2016

murrayc updated the diff for D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

Combined into one check. Also specifies C++11 for the test.

Jun 3 2016, 5:41 AM · Restricted Project

Jun 2 2016

murrayc added inline comments to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..
Jun 2 2016, 5:47 AM · Restricted Project
murrayc added a comment to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

Enabling/disabling can be done with options (see SizeofExpressionCheck).

Jun 2 2016, 5:24 AM · Restricted Project
murrayc updated the diff for D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

With suggested changes. Ran clang-format (LLVM style). Used voidType() matcher.

Jun 2 2016, 5:20 AM · Restricted Project
murrayc added a comment to D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

I wonder if these two checks should not be merge in one checker.

Jun 2 2016, 1:10 AM · Restricted Project
murrayc updated the diff for D20857: [clang-tidy] Add modernize-explicit-operator-bool check..

These are the commits amended with the suggested changes.
Many thanks for the suggestions.

Jun 2 2016, 1:05 AM · Restricted Project

Jun 1 2016

murrayc retitled D20857: [clang-tidy] Add modernize-explicit-operator-bool check. from to [clang-tidy] Add modernize-explicit-operator-bool check..
Jun 1 2016, 4:11 AM · Restricted Project