Page MenuHomePhabricator

mteodor (Teodor MICU)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2017, 4:06 AM (133 w, 1 d)

Recent Activity

Sep 29 2017

mteodor updated the diff for D35066: Add "Skip files" option to clang-format plugin for VS.

No default value for the new skip files option (previously resource.h;).
Thus, this new option will not change the functionality for those who don't need to skip any specific files.

Sep 29 2017, 8:52 AM · Restricted Project

Sep 22 2017

mteodor added a comment to D37732: Add missing NL (new line) at EOF (end of file).
In D37732#878897, @hans wrote:

This looks good to me. Do you have commit access, or would you like me to commit for you?

Sep 22 2017, 10:40 AM · Restricted Project
mteodor added a comment to D37732: Add missing NL (new line) at EOF (end of file).
In D37732#876591, @hans wrote:

I wonder if we'll need to expose this as a plugin option though, in case some users (for weird reasons, but some people seem to like it that way) don't want newline at the end of the file..

Sep 22 2017, 12:40 AM · Restricted Project
mteodor added inline comments to D37732: Add missing NL (new line) at EOF (end of file).
Sep 22 2017, 12:33 AM · Restricted Project
mteodor updated the diff for D37732: Add missing NL (new line) at EOF (end of file).

Update patch for full context (U9999).

Sep 22 2017, 12:29 AM · Restricted Project

Sep 20 2017

mteodor added a comment to D37732: Add missing NL (new line) at EOF (end of file).
In D37732#869928, @hans wrote:

I don't know much about VS, but doesn't it already have an option to save files with newline at end of file?

Sep 20 2017, 8:39 AM · Restricted Project

Sep 12 2017

mteodor retitled D37732: Add missing NL (new line) at EOF (end of file) from Add missing "NL" (new line) at EOF (end of file) to Add missing NL (new line) at EOF (end of file).
Sep 12 2017, 1:49 AM · Restricted Project
mteodor created D37732: Add missing NL (new line) at EOF (end of file).
Sep 12 2017, 1:46 AM · Restricted Project

Aug 22 2017

mteodor added a comment to D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..

Just make clang-format always do this. I don't think anyone is relying on the current behavior.

Aug 22 2017, 5:28 AM · Restricted Project

Aug 21 2017

mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

ping?

Aug 21 2017, 5:36 AM · Restricted Project

Jul 7 2017

mteodor updated the diff for D35066: Add "Skip files" option to clang-format plugin for VS.

Just a better detection of file name from file path.

Jul 7 2017, 6:41 AM · Restricted Project
mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

If this is a generated file, won't regenerating that file overwrite your changes?

Jul 7 2017, 5:59 AM · Restricted Project
mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

are you making changes to the generated file, and want to not format those changes?

Jul 7 2017, 5:42 AM · Restricted Project
mteodor updated the summary of D35066: Add "Skip files" option to clang-format plugin for VS.
Jul 7 2017, 5:24 AM · Restricted Project
mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

Looking at the code, probably the dirty check should be done sooner than later:

if (!options.FormatOnSave || !Vsix.IsDocumentDirty(document))
    return;

Where are you seeing this? In ClangFormatPackge.cs it looks like we're returning if the document's not dirty?

Jul 7 2017, 5:21 AM · Restricted Project
mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

No, this was not changed and works just fine. Format on save triggers only if there are changes.

Jul 7 2017, 2:08 AM · Restricted Project
mteodor added a comment to D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk.

I think we'll want somebody to find out whether there are simpler ways to
implement this.

Jul 7 2017, 2:00 AM
mteodor added a comment to D35066: Add "Skip files" option to clang-format plugin for VS.

I'm wondering whether the real bug is that format-on-save triggers if nothing in the file changed?

Jul 7 2017, 1:38 AM · Restricted Project

Jul 6 2017

mteodor updated the summary of D35066: Add "Skip files" option to clang-format plugin for VS.
Jul 6 2017, 9:31 AM · Restricted Project
mteodor created D35066: Add "Skip files" option to clang-format plugin for VS.
Jul 6 2017, 9:27 AM · Restricted Project